[jira] Created: (OFBIZ-1827) Pagination controls should not be displayed on a single page list

[Nicolas Malin (Jira)]

Pagination controls should not be displayed on a single page list
-----------------------------------------------------------------

                 Key: OFBIZ-1827
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1827
             Project: OFBiz
          Issue Type: Improvement
          Components: ecommerce
    Affects Versions: SVN trunk
            Reporter: Bruno Busco
            Priority: Minor
         Attachments: product_pagination.patch

The attached product_pagination.patch prevents the product prevnext controls to be displayed in the e-commerce category browsing screens if there is only one page to be displayed.
Since there were two identical peaces of code to render the upper and the lower instances of the prevnext section a FTL macro has been used.
A <b> tag has also been replaced by an equivalent css segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1827:
-------------------------------

    Attachment: product_pagination.patch

> Pagination controls should not be displayed on a single page list
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-1827
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1827
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: product_pagination.patch
>
>
> The attached product_pagination.patch prevents the product prevnext controls to be displayed in the e-commerce category browsing screens if there is only one page to be displayed.
> Since there were two identical peaces of code to render the upper and the lower instances of the prevnext section a FTL macro has been used.
> A <b> tag has also been replaced by an equivalent css segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1827:
--------------------------------------

    Assignee: Jacques Le Roux

> Pagination controls should not be displayed on a single page list
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-1827
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1827
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: product_pagination.patch
>
>
> The attached product_pagination.patch prevents the product prevnext controls to be displayed in the e-commerce category browsing screens if there is only one page to be displayed.
> Since there were two identical peaces of code to render the upper and the lower instances of the prevnext section a FTL macro has been used.
> A <b> tag has also been replaced by an equivalent css segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603448#action_12603448 ]

Jacques Le Roux commented on OFBIZ-1827:
----------------------------------------

This works well and the patch sounds good to me. I will commit if nobody see a problem with that.

> Pagination controls should not be displayed on a single page list
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-1827
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1827
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: product_pagination.patch
>
>
> The attached product_pagination.patch prevents the product prevnext controls to be displayed in the e-commerce category browsing screens if there is only one page to be displayed.
> Since there were two identical peaces of code to render the upper and the lower instances of the prevnext section a FTL macro has been used.
> A <b> tag has also been replaced by an equivalent css segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603511#action_12603511 ]

Bilgin Ibryam commented on OFBIZ-1827:
--------------------------------------

+1

Bilgin

> Pagination controls should not be displayed on a single page list
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-1827
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1827
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: product_pagination.patch
>
>
> The attached product_pagination.patch prevents the product prevnext controls to be displayed in the e-commerce category browsing screens if there is only one page to be displayed.
> Since there were two identical peaces of code to render the upper and the lower instances of the prevnext section a FTL macro has been used.
> A <b> tag has also been replaced by an equivalent css segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1827.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Bruno,

Your patch is in trunk revision: 665899  

> Pagination controls should not be displayed on a single page list
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-1827
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1827
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_pagination.patch
>
>
> The attached product_pagination.patch prevents the product prevnext controls to be displayed in the e-commerce category browsing screens if there is only one page to be displayed.
> Since there were two identical peaces of code to render the upper and the lower instances of the prevnext section a FTL macro has been used.
> A <b> tag has also been replaced by an equivalent css segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.