[jira] Created: (OFBIZ-1839) Conversion of Screen Widget " Container to Screenlet" .

[Nicolas Malin (Jira)]

Conversion of Screen Widget " Container to Screenlet" .
-------------------------------------------------------

                 Key: OFBIZ-1839
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
            Reporter: Ratnesh Upadhyay
            Priority: Minor


Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1839:
----------------------------------

    Attachment: ConvertContainerToScreenlet.patch

Removed the Container option from all the screen definition of "accounting" component  wherever possible and put the screenlet there.

Thanks to Ratnesh Upadhayay and Rishi Solanki for their help.
Thanks and Regards
-Awdesh Parihar

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604190#action_12604190 ]

Vikas Mayur commented on OFBIZ-1839:
------------------------------------

Id names need improvements.

Like in <screenlet id="add-agreement-term" title="${uiLabelMap.PageTitleEditAgreementTerm}" collapsible="true">

it can be like id="addAgreementTerm" . I prefer this to use instead.


- Vikas

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604190#action_12604190 ]

vikasmayur edited comment on OFBIZ-1839 at 6/11/08 4:51 AM:
-------------------------------------------------------------

Id names need improvements.

Like in <screenlet id="add-agreement-term" title="${uiLabelMap.PageTitleEditAgreementTerm}" collapsible="true">

it can be like id="addAgreementTerm" . I prefer to use this instead.


- Vikas



      was (Author: vikasmayur):
    Id names need improvements.

Like in <screenlet id="add-agreement-term" title="${uiLabelMap.PageTitleEditAgreementTerm}" collapsible="true">

it can be like id="addAgreementTerm" . I prefer this to use instead.


- Vikas


 

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-1839:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1839:
----------------------------------

    Attachment: ConvertContainerToScreenlet.patch

Thanks Vilas For your suggestion
Here is updated patch.

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604241#action_12604241 ]

Adrian Crum commented on OFBIZ-1839:
------------------------------------

This looks great!

Regarding the upper/lower case issue: if you look at current implementations of HTML element IDs, you'll see both styles being used. The lower case, dashed style is used in the main style sheet and in some screens where they are specified. On the other hand, the screen widgets generate HTML element IDs by using the widget's name - which is typically camel case. So, there is no rule - either style should be fine.

Maybe we could discuss this subject on the dev mailing list and come up with a best practice for it.

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604422#action_12604422 ]

Vikas Mayur commented on OFBIZ-1839:
------------------------------------

Yeah - Its always good to have consensus over these issues which will lead us to make best practices / rules defined.
BTW, I have few guys working on each component one by one following the camel case pattern style - but yes we can always do changes afterwards to adhere to best practices (If this isn't come under best practice ;)).

- Vikas

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604424#action_12604424 ]

Ashish Vijaywargiya commented on OFBIZ-1839:
--------------------------------------------

Thanks Awdesh for your patch.
Its in rev # 666968.

--
Ashish

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1839:
----------------------------------

    Attachment: Party.patch

Removed the Container option from all the screen definition of "party" component wherever possible and put the screenlet there.

Thanks to Ratnesh Upadhayay
Thanks and Regards
-Awdesh Parihar

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

parimal gain updated OFBIZ-1839:
--------------------------------

    Attachment: Marketing.patch

Here is the patch for Marketing Component and I have Converted screen widget container to screenlet at all possible places.

Thanks to Ratnesh and Ashish .

Thanks & Regards
Parimal Gain

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsha Chadhar updated OFBIZ-1839:
----------------------------------

    Attachment: HumanRes.patch

Replaced the code with the new <screenlet -> tag in the Screens with Add-List Forms in the HumanRes Component .

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1839:
----------------------------------

    Attachment: Content.patch

Removed the Container option from all the screen definition of "Content" component wherever possible and put the screenlet there.

Thanks to Ratnesh Upadhayay and Rishi Solanki for their help.
Thanks and Regards
-Awdesh Parihar

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604458#action_12604458 ]

Ashish Vijaywargiya commented on OFBIZ-1839:
--------------------------------------------

Parimal Gain  thanks for your patch on Marketing component.
Its in rev # 667012.

Thanks Ratnesh.

--
Ashish

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604459#action_12604459 ]

Ashish Vijaywargiya commented on OFBIZ-1839:
--------------------------------------------

Thanks Awdesh for your patch on Content component.
Its in Trunk rev # 667013.

--
Ashish

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604460#action_12604460 ]

Ashish Vijaywargiya commented on OFBIZ-1839:
--------------------------------------------

Thanks Harsha Chadhar for your patch.
Its in trunk rev # 667014.

--
Ashish

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604461#action_12604461 ]

Ashish Vijaywargiya commented on OFBIZ-1839:
--------------------------------------------

Thanks Awdesh Singh Parihar for your patch.
Its now in trunk rev # 667016.

--
Ashish

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsha Chadhar updated OFBIZ-1839:
----------------------------------

    Attachment: Manufacturing.patch

Updated Manufacturing Component with the Screenlet tag replacing the old code with Container tag.

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Manufacturing.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604487#action_12604487 ]

Ashish Vijaywargiya commented on OFBIZ-1839:
--------------------------------------------

Thanks Harsha Chadhar for your patch on Manufacturing component.
Your changes are in Trunk rev # 667042.

--
Ashish

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, HumanRes.patch, Manufacturing.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

parimal gain updated OFBIZ-1839:
--------------------------------

    Attachment: Facility.patch

updated patch for Facility Component with screenlet.

Thanks to Ratnesh and Ashish.

Thanks & Regards
Parimal Gain

> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Content.patch, ConvertContainerToScreenlet.patch, ConvertContainerToScreenlet.patch, Facility.patch, HumanRes.patch, Manufacturing.patch, Marketing.patch, Party.patch
>
>
> Remove the Container option from all the screen definition wherever possible and put the screenlet  there.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.