[jira] Created: (OFBIZ-1842) Upgrade to Geronimo TXManager 2.1.1

[Nicolas Malin (Jira)]

Upgrade to Geronimo TXManager 2.1.1
-----------------------------------

                 Key: OFBIZ-1842
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Jacopo Cappellato
            Priority: Minor
         Attachments: geronimotx.patch

Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1

I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.

Thanks,

Jacopo
 

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1842:
-------------------------------------

    Attachment: geronimotx.patch

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605926#action_12605926 ]

Christian Geisert commented on OFBIZ-1842:
------------------------------------------

Just gave it a try (Revision: 669124, Java HotSpot(TM) Client VM (build 1.5.0_13-b05, mixed mode, sharing, Ubuntu Linux)

I put the following two jars into framework/geronimo/lib/

http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/geronimo/components/geronimo-transaction/2.1.1/geronimo-transaction-2.1.1.jar
http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/geronimo/components/geronimo-connector/2.1.1/geronimo-connector-2.1.1.jar

and removed geronimo-transaction-1.0.jar and jencks-1.1.3.jar


build is ok, but ant run-install gives the following error:
     [java] Exception in thread "main" java.lang.NoClassDefFoundError: javax/transaction/TransactionSynchronizationRegistry
     [java]     at java.lang.ClassLoader.defineClass1(Native Method)
     [java]     at java.lang.ClassLoader.defineClass(ClassLoader.java:620)
     [java]     at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124)
     [java]     at java.net.URLClassLoader.defineClass(URLClassLoader.java:260)
     [java]     at java.net.URLClassLoader.access$100(URLClassLoader.java:56)
     [java]     at java.net.URLClassLoader$1.run(URLClassLoader.java:195)
     [java]     at java.security.AccessController.doPrivileged(Native Method)
     [java]     at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
     [java]     at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
     [java]     at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
     [java]     at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
     [java]     at java.lang.ClassLoader.defineClass1(Native Method)
     [java]     at java.lang.ClassLoader.defineClass(ClassLoader.java:620)
     [java]     at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124)
     [java]     at java.net.URLClassLoader.defineClass(URLClassLoader.java:260)
     [java]     at java.net.URLClassLoader.access$100(URLClassLoader.java:56)
     [java]     at java.net.URLClassLoader$1.run(URLClassLoader.java:195)
     [java]     at java.security.AccessController.doPrivileged(Native Method)
     [java]     at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
     [java]     at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
     [java]     at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
     [java]     at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
     [java]     at org.ofbiz.geronimo.GeronimoTransactionFactory.<clinit>(GeronimoTransactionFactory.java:57)
     [java]     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
     [java]     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
     [java]     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
     [java]     at java.lang.reflect.Constructor.newInstance(Constructor.java:494)
     [java]     at java.lang.Class.newInstance0(Class.java:350)
     [java]     at java.lang.Class.newInstance(Class.java:303)
     [java]     at org.ofbiz.entity.transaction.TransactionFactory.getTransactionFactory(TransactionFactory.java:64)
     [java]     at org.ofbiz.entity.transaction.TransactionFactory.getConnection(TransactionFactory.java:95)
     [java]     at org.ofbiz.entity.jdbc.ConnectionFactory.getConnection(ConnectionFactory.java:73)
     [java]     at org.ofbiz.entity.jdbc.DatabaseUtil.getConnection(DatabaseUtil.java:98)
     [java]     at org.ofbiz.entity.jdbc.DatabaseUtil.getTableNames(DatabaseUtil.java:1056)
     [java]     at org.ofbiz.entity.jdbc.DatabaseUtil.checkDb(DatabaseUtil.java:136)
     [java]     at org.ofbiz.entity.jdbc.DatabaseUtil.checkDb(DatabaseUtil.java:125)
     [java]     at org.ofbiz.entity.datasource.GenericDAO.checkDb(GenericDAO.java:1062)
     [java]     at org.ofbiz.entity.datasource.GenericHelperDAO.checkDataSource(GenericHelperDAO.java:195)
     [java]     at org.ofbiz.entity.GenericDelegator.<init>(GenericDelegator.java:235)
     [java]     at org.ofbiz.entity.GenericDelegator.getGenericDelegator(GenericDelegator.java:130)
     [java]     at org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.java:194)
     [java]     at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
     [java]     at org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
     [java]     at org.ofbiz.base.start.Start.startServer(Start.java:312)
     [java]     at org.ofbiz.base.start.Start.start(Start.java:316)
     [java]     at org.ofbiz.base.start.Start.main(Start.java:399)
     [java] Java Result: 1


I guess there's a jar missing...

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605928#action_12605928 ]

Jacopo Cappellato commented on OFBIZ-1842:
------------------------------------------

Yes sorry I didn't mention it; here are the jars updates that are required:

A      framework/base/lib/j2eespecs/geronimo-jta_1.1_spec-1.1.1.jar
D      framework/base/lib/j2eespecs/geronimo-jta_1.0.1B_spec-1.0.jar
A      framework/geronimo/lib/geronimo-connector-2.1.1.jar
A      framework/geronimo/lib/geronimo-transaction-2.1.1.jar
D      framework/geronimo/lib/jencks-1.1.3.jar
D      framework/geronimo/lib/geronimo-transaction-1.0.jar

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605939#action_12605939 ]

Jacques Le Roux commented on OFBIZ-1842:
----------------------------------------

Jacopo,

Could we not have all in patch to facilitate testing ?

TIA

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605946#action_12605946 ]

Jacopo Cappellato commented on OFBIZ-1842:
------------------------------------------

Jacques,

here are the links to download the three new jars:

http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/geronimo/components/geronimo-connector/2.1.1/geronimo-connector-2.1.1.jar
http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/geronimo/components/geronimo-transaction/2.1.1/geronimo-transaction-2.1.1.jar
http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/geronimo/specs/geronimo-jta_1.1_spec/1.1.1/geronimo-jta_1.1_spec-1.1.1.jar

they should replace the following files in OFBiz:

framework/base/lib/j2eespecs/geronimo-jta_1.0.1B_spec-1.0.jar
framework/geronimo/lib/jencks-1.1.3.jar
framework/geronimo/lib/geronimo-transaction-1.0.jar

Hope it helps.

Thanks

Jacopo

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605974#action_12605974 ]

Jacques Le Roux commented on OFBIZ-1842:
----------------------------------------

Thanks Jacopo,

I will give it a try tomorrow...

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606776#action_12606776 ]

Christian Geisert commented on OFBIZ-1842:
------------------------------------------

I've done a bit of testing and didn't notice any problems

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606780#action_12606780 ]

Jacopo Cappellato commented on OFBIZ-1842:
------------------------------------------

Thanks Christian,

I too am running it without issues so far.
The only part I don't feel super comfortable with is the changes I did to the GeronimoContainer.java file.
Unfortunately I don't know much about the old TransactionContextManager class and I am not really sure if the old lines:

this.geronimoTcm = new TransactionContextManager();
this.geronimoTcm.getTransactionManager();

are equivalent to the new one:

new GeronimoTransactionManager();

A quick code review from you and others would really help.

Jacopo

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606831#action_12606831 ]

Jacques Le Roux commented on OFBIZ-1842:
----------------------------------------

It runs well here for 2 days now. Did no do any specific tests though.

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606901#action_12606901 ]

David E. Jones commented on OFBIZ-1842:
---------------------------------------

Jacopo,

I only have limited experience with Geronimo and its transaction manager, but I'd say if the new way of just constructing the object directly is working, then let's go for it.

In the old case we created a new object before getting the transaction manager from it, so I can imagine that this is the way it was intended to be done and it is just a clean up of the API.

-David

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1842.
------------------------------------

    Resolution: Fixed

Committed in rev. 670160

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1842:
----------------------------------------

    Assignee: Jacopo Cappellato

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager version 2.1.1
> I am testing it now in my box (no problems until now) but I would really appreciate your review (especially to the GeronimoContainer.java class file) because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.