Example application should use FindScreenDecorator
-------------------------------------------------- Key: OFBIZ-1846 URL: https://issues.apache.org/jira/browse/OFBIZ-1846 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Priority: Minor Attachments: Example-FindScreenDecorator.patch Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1846: ------------------------------- Attachment: Example-FindScreenDecorator.patch > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Priority: Minor > Attachments: Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1846. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and as it's done currently in Project contrary as how it's done in Party, that we should not render any result by default. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607083#action_12607083 ] Jacques Le Roux commented on OFBIZ-1846: ---------------------------------------- Oops, I thought that using Confluence markup syntax would work here also. I think I saw something like that used in another Apache project but it should be using another (unknown) syntax. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607082#action_12607082 ] jacques.le.roux edited comment on OFBIZ-1846 at 6/22/08 4:25 AM: ----------------------------------------------------------------- Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and how it's done currently in Project contrary as how it's done in Party, that we should not render any results by default. was (Author: jacques.le.roux): Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and as it's done currently in Project contrary as how it's done in Party, that we should not render any result by default. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607082#action_12607082 ] jacques.le.roux edited comment on OFBIZ-1846 at 6/22/08 4:28 AM: ----------------------------------------------------------------- Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and how it's done currently in Party contrary as how it's done in Project , that we should not render any results by default. So for me the good way to go is Party, not Project (even if I reckon that Party is maybe an intermediate situation, not sure though, maybe it's not necessary to use a collapsible screnlect when 1st opening). Much details isn'it ? :o) was (Author: jacques.le.roux): Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and how it's done currently in Project contrary as how it's done in Party, that we should not render any results by default. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607082#action_12607082 ] jacques.le.roux edited comment on OFBIZ-1846 at 6/22/08 4:32 AM: ----------------------------------------------------------------- Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and how it's done currently in Party contrary as how it's done in Project , that we should not render any results by default. So for me the good way to go is Party, not Project (even if I reckon that Party is maybe an intermediate situation, not sure though, maybe it's not necessary to use a collapsible screnlect when 1st opening). Much details isn'it ? :o) And maybe I should even elaborate a bit more the reason : to avoid pre-processing effort and useless stress to DB (most of the time we don't need to retrieve all when we search, this the goal...) Sorry to have not followed the rule which stipulates to not modify comments but add new comment :D was (Author: jacques.le.roux): Hi Bruno; I have commited your patch in trunk revision: 670340 . But I still think, like [David|https://issues.apache.org/jira/browse/OFBIZ-1841?focusedCommentId=12605189#action_12605189], and contrary as [Adrian|http://www.nabble.com/forum/Permalink.jtp?root=17837981&post=17837981&page=y] and how it's done currently in Party contrary as how it's done in Project , that we should not render any results by default. So for me the good way to go is Party, not Project (even if I reckon that Party is maybe an intermediate situation, not sure though, maybe it's not necessary to use a collapsible screnlect when 1st opening). Much details isn'it ? :o) > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1846: ------------------------------- Attachment: example-ajax.patch The Example-FindScreenDecorator.patch has broken the Ajax Example as reported by stamilo in the user ML. The attached example-ajax.patch fixes this problem. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-1846: -------------------------------- The example-ajax.patch need to be reviewed and commited to have the Ajax example working again. Sorry about this. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607669#action_12607669 ] Jacques Le Roux commented on OFBIZ-1846: ---------------------------------------- Bruno, Your patch is in trunk revision: 671230. I do not close this issue as there is still an issue with the Example Find page : no results are ever given. It should work like the Facility Find page I will try to adapt it if no one beats me on it. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-1846. ------------------------------ Resolution: Fixed I fixed it Jacques. > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607689#action_12607689 ] Jacques Le Roux commented on OFBIZ-1846: ---------------------------------------- Clean, thanks Adrian > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607710#action_12607710 ] Bruno Busco commented on OFBIZ-1846: ------------------------------------ This is for sure a newbie question but I am getting confused on the difference between having this "<set field="noConditionFind" value="Y"/>" in the actions of a find screen and having this "<field name="noConditionFind"><hidden value="Y"/></field>" in the search form. The effect is that in the first case when the screen is initially displayed the list is already filled with all records, in the second case the list in initially empty and then pushing the search button with all fields empty the list is filled but I cannot understand why. I thought the two were the same but it is evidentely not true. Could you please give me a little explanation of how it works? Thank you very much :-| . -Bruno > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607734#action_12607734 ] Jacques Le Roux commented on OFBIZ-1846: ---------------------------------------- Bruno, If you set the field from the screen it will be setled when you will loading the form, hence the find will perfom. I you set it (hidden) in the form it will be set only when you will submit the form (and perform the find in instance). > Example application should use FindScreenDecorator > -------------------------------------------------- > > Key: OFBIZ-1846 > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: example-ajax.patch, Example-FindScreenDecorator.patch > > > Please find attached a patch in which the Example application has been changed to use the new FindScreenDecorator (and the performFind service). > Using the FindScreenDecorator in Example should help to have a more omogeneus UI (since it is supposed to be a template from where to start from for new applications). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Thank you Jacques, now it's very clear.
BTW also the FindExampleFeatures form in ExampleFeatureForms.xml needs the additional <field name="noConditionFind"><hidden value="Y"/></field> line as done in FindExamples form. Many thanks -Bruno 2008/6/24 Jacques Le Roux (JIRA) <[hidden email]>: > > [ > https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607734#action_12607734] > > Jacques Le Roux commented on OFBIZ-1846: > ---------------------------------------- > > Bruno, > > If you set the field from the screen it will be setled when you will > loading the form, hence the find will perfom. I you set it (hidden) in the > form it will be set only when you will submit the form (and perform the find > in instance). > > > Example application should use FindScreenDecorator > > -------------------------------------------------- > > > > Key: OFBIZ-1846 > > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 > > Project: OFBiz > > Issue Type: Improvement > > Components: framework > > Affects Versions: SVN trunk > > Reporter: Bruno Busco > > Assignee: Jacques Le Roux > > Priority: Minor > > Fix For: SVN trunk > > > > Attachments: example-ajax.patch, > Example-FindScreenDecorator.patch > > > > > > Please find attached a patch in which the Example application has been > changed to use the new FindScreenDecorator (and the performFind service). > > Using the FindScreenDecorator in Example should help to have a more > omogeneus UI (since it is supposed to be a template from where to start from > for new applications). > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
Administrator
|
Bruno,
Yes, I saw and did it in rev. 671314 Thanks Jacques PS : I was in a hurry, when reading myself below it's obvious (sorry for this bad English :o) From: "Bruno Busco" <[hidden email]> > Thank you Jacques, now it's very clear. > > BTW also the FindExampleFeatures form in ExampleFeatureForms.xml needs the > additional > <field name="noConditionFind"><hidden value="Y"/></field> > line as done in FindExamples form. > > Many thanks > -Bruno > > 2008/6/24 Jacques Le Roux (JIRA) <[hidden email]>: > >> >> [ >> https://issues.apache.org/jira/browse/OFBIZ-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607734#action_12607734] >> >> Jacques Le Roux commented on OFBIZ-1846: >> ---------------------------------------- >> >> Bruno, >> >> If you set the field from the screen it will be setled when you will >> loading the form, hence the find will perfom. I you set it (hidden) in the >> form it will be set only when you will submit the form (and perform the find >> in instance). >> >> > Example application should use FindScreenDecorator >> > -------------------------------------------------- >> > >> > Key: OFBIZ-1846 >> > URL: https://issues.apache.org/jira/browse/OFBIZ-1846 >> > Project: OFBiz >> > Issue Type: Improvement >> > Components: framework >> > Affects Versions: SVN trunk >> > Reporter: Bruno Busco >> > Assignee: Jacques Le Roux >> > Priority: Minor >> > Fix For: SVN trunk >> > >> > Attachments: example-ajax.patch, >> Example-FindScreenDecorator.patch >> > >> > >> > Please find attached a patch in which the Example application has been >> changed to use the new FindScreenDecorator (and the performFind service). >> > Using the FindScreenDecorator in Example should help to have a more >> omogeneus UI (since it is supposed to be a template from where to start from >> for new applications). >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> > |
Free forum by Nabble | Edit this page |