[jira] Created: (OFBIZ-1875) Approve requirement screen label should say NOT YET approved requirements

[Nicolas Malin (Jira)]

Approve requirement screen label should say NOT YET approved requirements
-------------------------------------------------------------------------

                 Key: OFBIZ-1875
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1875
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: SVN trunk rev 676411
            Reporter: Bruno Busco
            Priority: Trivial


The Approve requirements screen label should be changed from "Find Approved Requirements" to "Find NOT Approved Requirements".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1875:
-------------------------------

    Attachment: approve_requirements.patch

In the attached patch there is the fix and also a change to make the screen use the FindScreenDecorator (yet partially)

> Approve requirement screen label should say NOT YET approved requirements
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-1875
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1875
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: SVN trunk rev 676411
>            Reporter: Bruno Busco
>            Priority: Trivial
>         Attachments: approve_requirements.patch
>
>
> The Approve requirements screen label should be changed from "Find Approved Requirements" to "Find NOT Approved Requirements".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1875:
----------------------------------------

    Assignee: Jacopo Cappellato

> Approve requirement screen label should say NOT YET approved requirements
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-1875
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1875
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: SVN trunk rev 676411
>            Reporter: Bruno Busco
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: approve_requirements.patch
>
>
> The Approve requirements screen label should be changed from "Find Approved Requirements" to "Find NOT Approved Requirements".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1875:
-------------------------------

    Attachment:     (was: approve_requirements.patch)

> Approve requirement screen label should say NOT YET approved requirements
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-1875
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1875
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: SVN trunk rev 676411
>            Reporter: Bruno Busco
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: approve_req_label_fix.patch, requirementScreen_FindScreenDecorator.patch
>
>
> The Approve requirements screen label should be changed from "Find Approved Requirements" to "Find NOT Approved Requirements".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1875:
-------------------------------

    Attachment: requirementScreen_FindScreenDecorator.patch
                approve_req_label_fix.patch

Following the patch guidelines I have splitted the previous patch in two simpler.
1) approve_req_label_fix.patch fixes a wrong label in approve requirements screen
2) requirementScreen_FindScreenDecorator.patch make the requirements screens use the FindScreenDecorator

hope this helps

> Approve requirement screen label should say NOT YET approved requirements
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-1875
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1875
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: SVN trunk rev 676411
>            Reporter: Bruno Busco
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: approve_req_label_fix.patch, requirementScreen_FindScreenDecorator.patch
>
>
> The Approve requirements screen label should be changed from "Find Approved Requirements" to "Find NOT Approved Requirements".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1875.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux  (was: Jacopo Cappellato)

Thanks Bruno,

I commited your fixing patch in trunk revision: 680070  (can't be in release4.0 because of translation) and your enhancing patch in trunk revision: 680072

> Approve requirement screen label should say NOT YET approved requirements
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-1875
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1875
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: SVN trunk rev 676411
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: approve_req_label_fix.patch, requirementScreen_FindScreenDecorator.patch
>
>
> The Approve requirements screen label should be changed from "Find Approved Requirements" to "Find NOT Approved Requirements".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.