OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1890) Matrix layout for Featured Products

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1890) Matrix layout for Featured Products

Matrix layout for Featured Products
-----------------------------------

Key: OFBIZ-1890
URL: https://issues.apache.org/jira/browse/OFBIZ-1890
Project: OFBiz
Issue Type: Improvement
Components: ecommerce
Affects Versions: SVN trunk
Reporter: Bruno Busco
Priority: Minor

Hi,
in the attached (FeaturedProducts_matrix.patch) patch I have done a change to have a different screen layout for the Featured Products.
I think that this can be useful for people to see the category detailScreen field in action in the OOTB ofbiz.
All other categories are still displayed as usual. The Featured Products appear has in the attached screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1890) Matrix layout for Featured Products

[ https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1890:
-------------------------------

Attachment: screenshot-1.jpg

> Matrix layout for Featured Products
> -----------------------------------
>
> Key: OFBIZ-1890
> URL: https://issues.apache.org/jira/browse/OFBIZ-1890
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
>
>
> Hi,
> in the attached (FeaturedProducts_matrix.patch) patch I have done a change to have a different screen layout for the Featured Products.
> I think that this can be useful for people to see the category detailScreen field in action in the OOTB ofbiz.
> All other categories are still displayed as usual. The Featured Products appear has in the attached screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1890) Matrix layout for Featured Products

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1890) Matrix layout for Featured Products

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616792#action_12616792 ]

Jacques Le Roux commented on OFBIZ-1890:
----------------------------------------

Hi Bruno,

IIRW there is currently a reflexion about Themes. Is this patch intended to be commited or only submitted as a POC ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Bruno Busco

Re: [jira] Commented: (OFBIZ-1890) Matrix layout for Featured Products

Jacques,
yes, IMO this patch is intended to be committed.

I do not know when the theme feature will be available and also AFAIK the
theme feature will only let to change the CSS and related gifs.
Moreover the detailScreen field is intended to let every single category to
be displayied with an own screen, the patch is IMO a good example to show
how to use it.

Thank you for reviewing and committing.
Bruno

2008/7/25 Jacques Le Roux (JIRA) <[hidden email]>:

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616792#action_12616792]
>
> Jacques Le Roux commented on OFBIZ-1890:
> ----------------------------------------
>
> Hi Bruno,
>
> IIRW there is currently a reflexion about Themes. Is this patch intended to
> be commited or only submitted as a POC ?
>
>
> > Matrix layout for Featured Products
> > -----------------------------------
> >
> > Key: OFBIZ-1890
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1890
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: ecommerce
> > Affects Versions: SVN trunk
> > Reporter: Bruno Busco
> > Priority: Minor
> > Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
> >
> >
> > Hi,
> > in the attached (FeaturedProducts_matrix.patch) patch I have done a
> change to have a different screen layout for the Featured Products.
> > I think that this can be useful for people to see the category
> detailScreen field in action in the OOTB ofbiz.
> > All other categories are still displayed as usual. The Featured Products
> appear has in the attached screenshot.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-1890) Matrix layout for Featured Products

Administrator

Bruno, All,

It's fine with me. I'd like to have other opinions before reviewing and possibly commiting. It's easy to check as Bruno provided a
screen copy.

Thanks

Jacques

From: "Bruno Busco" <[hidden email]>

> Jacques,
> yes, IMO this patch is intended to be committed.
>
> I do not know when the theme feature will be available and also AFAIK the
> theme feature will only let to change the CSS and related gifs.
> Moreover the detailScreen field is intended to let every single category to
> be displayied with an own screen, the patch is IMO a good example to show
> how to use it.
>
> Thank you for reviewing and committing.
> Bruno
>
> 2008/7/25 Jacques Le Roux (JIRA) <[hidden email]>:
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616792#action_12616792]
>>
>> Jacques Le Roux commented on OFBIZ-1890:
>> ----------------------------------------
>>
>> Hi Bruno,
>>
>> IIRW there is currently a reflexion about Themes. Is this patch intended to
>> be commited or only submitted as a POC ?
>>
>>
>> > Matrix layout for Featured Products
>> > -----------------------------------
>> >
>> > Key: OFBIZ-1890
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1890
>> > Project: OFBiz
>> > Issue Type: Improvement
>> > Components: ecommerce
>> > Affects Versions: SVN trunk
>> > Reporter: Bruno Busco
>> > Priority: Minor
>> > Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
>> >
>> >
>> > Hi,
>> > in the attached (FeaturedProducts_matrix.patch) patch I have done a
>> change to have a different screen layout for the Featured Products.
>> > I think that this can be useful for people to see the category
>> detailScreen field in action in the OOTB ofbiz.
>> > All other categories are still displayed as usual. The Featured Products
>> appear has in the attached screenshot.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1890) Matrix layout for Featured Products

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1890.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux

Thanks Bruno,

Your patch is in trunk revision: 680069 (I did a previous commit in 680068)

I slightly modified it to keep the same look than before when numCol is setted to 1 in categorydetailmatrix screen.
The problem was that the add button and optional amout to choose were not right aligned.
I also wondered about the Search in Category not showing by default but finally kept your setting.

BTW, I fixed the look I did not like much (I mean bolded words in a greater font) by adding the declarations of deprecated tabletext selector in the declaration-block of .productsummary .productinfo selector. It was a good thing to do for another reason ; there were 2 defintions for .productsummary .productinfo selector. This comes from this commit I guess http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl?r1=675831&r2=676212

> Matrix layout for Featured Products
> -----------------------------------
>
> Key: OFBIZ-1890
> URL: https://issues.apache.org/jira/browse/OFBIZ-1890
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
>
>
> Hi,
> in the attached (FeaturedProducts_matrix.patch) patch I have done a change to have a different screen layout for the Featured Products.
> I think that this can be useful for people to see the category detailScreen field in action in the OOTB ofbiz.
> All other categories are still displayed as usual. The Featured Products appear has in the attached screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1890) Matrix layout for Featured Products

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617254#action_12617254 ]

Jacques Le Roux commented on OFBIZ-1890:
----------------------------------------

Bruno,

I just notice that it"s a bit narrow when using 1024 pix wide, could you check please ?

> Matrix layout for Featured Products
> -----------------------------------
>
> Key: OFBIZ-1890
> URL: https://issues.apache.org/jira/browse/OFBIZ-1890
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
>
>
> Hi,
> in the attached (FeaturedProducts_matrix.patch) patch I have done a change to have a different screen layout for the Featured Products.
> I think that this can be useful for people to see the category detailScreen field in action in the OOTB ofbiz.
> All other categories are still displayed as usual. The Featured Products appear has in the attached screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1890) Matrix layout for Featured Products

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617256#action_12617256 ]

Bruno Busco commented on OFBIZ-1890:
------------------------------------

Yes Jacques,
I have seen it...
...I tryed adding the following in the ecommain.css

.productsummary-container table {
margin: 0px auto;
}

to have the table centered but it works only in FF and not in IE :-(

> Matrix layout for Featured Products
> -----------------------------------
>
> Key: OFBIZ-1890
> URL: https://issues.apache.org/jira/browse/OFBIZ-1890
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
>
>
> Hi,
> in the attached (FeaturedProducts_matrix.patch) patch I have done a change to have a different screen layout for the Featured Products.
> I think that this can be useful for people to see the category detailScreen field in action in the OOTB ofbiz.
> All other categories are still displayed as usual. The Featured Products appear has in the attached screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1890) Matrix layout for Featured Products

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617265#action_12617265 ]

Jacques Le Roux commented on OFBIZ-1890:
----------------------------------------

OK, we will see if someone comes with a better solution ;o)

> Matrix layout for Featured Products
> -----------------------------------
>
> Key: OFBIZ-1890
> URL: https://issues.apache.org/jira/browse/OFBIZ-1890
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: FeaturedProducts_matrix.patch, screenshot-1.jpg
>
>
> Hi,
> in the attached (FeaturedProducts_matrix.patch) patch I have done a change to have a different screen layout for the Featured Products.
> I think that this can be useful for people to see the category detailScreen field in action in the OOTB ofbiz.
> All other categories are still displayed as usual. The Featured Products appear has in the attached screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.