OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1879) A more compact FindScreenDecorator

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1879) A more compact FindScreenDecorator

A more compact FindScreenDecorator
----------------------------------

Key: OFBIZ-1879
URL: https://issues.apache.org/jira/browse/OFBIZ-1879
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Bruno Busco
Priority: Minor
Attachments: CompactFindScreenDecorator.patch

Please find attached a patch to change the FindScreenDecorator to make it use the screenlet tag.
I have also re-styled it to have it more compact with the "Search options" and "Search results" labels in the screenlet title bars instead that having them as separare titles.
I hope you will better like it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1879) A more compact FindScreenDecorator

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1879:
-------------------------------

Attachment: CompactFindScreenDecorator.patch

> A more compact FindScreenDecorator
> ----------------------------------
>
> Key: OFBIZ-1879
> URL: https://issues.apache.org/jira/browse/OFBIZ-1879
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: CompactFindScreenDecorator.patch
>
>
> Please find attached a patch to change the FindScreenDecorator to make it use the screenlet tag.
> I have also re-styled it to have it more compact with the "Search options" and "Search results" labels in the screenlet title bars instead that having them as separare titles.
> I hope you will better like it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613761#action_12613761 ]

Adrian Crum commented on OFBIZ-1879:
------------------------------------

Bruno,

We are trying to move away from the overuse of screenlets. The current Find Screen layout was already discussed and voted on - OFBIZ-1635.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Bruno Busco

Re: [jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

Adrian,
sorry but I thought we were moving TOward the use of the screenlet widget,
weren't we?
I often see commits with the "container to screenlet conversion" log
message.
Where we stated against this?

Thank you,
-Bruno

2008/7/16 Adrian Crum (JIRA) <[hidden email]>:

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613761#action_12613761]
>
> Adrian Crum commented on OFBIZ-1879:
> ------------------------------------
>
> Bruno,
>
> We are trying to move away from the overuse of screenlets. The current Find
> Screen layout was already discussed and voted on - OFBIZ-1635.
>
> > A more compact FindScreenDecorator
> > ----------------------------------
> >
> > Key: OFBIZ-1879
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1879
> > Project: OFBiz
> > Issue Type: Bug
> > Components: framework
> > Affects Versions: SVN trunk
> > Reporter: Bruno Busco
> > Priority: Minor
> > Attachments: CompactFindScreenDecorator.patch
> >
> >
> > Please find attached a patch to change the FindScreenDecorator to make it
> use the screenlet tag.
> > I have also re-styled it to have it more compact with the "Search
> options" and "Search results" labels in the screenlet title bars instead
> that having them as separare titles.
> > I hope you will better like it.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Adrian Crum

Re: [jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

Converting individual screen widget elements to the screenlet widget
element is fine. That is a widget XML issue. In other words, it's an
effort to reduce XML code.

What I was referring to is different. I was referring to *layout* and
how screenlets are added to screens when they aren't really needed.

What we are trying to get away from is the multiple dark blue bands that
fill the screen. There are other ways to divide content besides adding
another screenlet. The <h2> style header is a good example. The newly
created <horizontal-separator> screen widget is another example.

-Adrian

Bruno Busco wrote:

> Adrian,
> sorry but I thought we were moving TOward the use of the screenlet widget,
> weren't we?
> I often see commits with the "container to screenlet conversion" log
> message.
> Where we stated against this?
>
> Thank you,
> -Bruno
>
> 2008/7/16 Adrian Crum (JIRA) <[hidden email]>:
>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613761#action_12613761]
>>
>> Adrian Crum commented on OFBIZ-1879:
>> ------------------------------------
>>
>> Bruno,
>>
>> We are trying to move away from the overuse of screenlets. The current Find
>> Screen layout was already discussed and voted on - OFBIZ-1635.
>>
>>> A more compact FindScreenDecorator
>>> ----------------------------------
>>>
>>> Key: OFBIZ-1879
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-1879
>>> Project: OFBiz
>>> Issue Type: Bug
>>> Components: framework
>>> Affects Versions: SVN trunk
>>> Reporter: Bruno Busco
>>> Priority: Minor
>>> Attachments: CompactFindScreenDecorator.patch
>>>
>>>
>>> Please find attached a patch to change the FindScreenDecorator to make it
>> use the screenlet tag.
>>> I have also re-styled it to have it more compact with the "Search
>> options" and "Search results" labels in the screenlet title bars instead
>> that having them as separare titles.
>>> I hope you will better like it.
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613845#action_12613845 ]

Bruno Busco commented on OFBIZ-1879:
------------------------------------

Adrian,
as explained in the dev ML (http://www.nabble.com/Re%3A--jira--Commented%3A-%28OFBIZ-1879%29-A-more-compact-FindScreenDecorator-p18477086.html) we are still OK with the XML substitution of the container widget with the screenlet one (happy to be still on the right path! ;-) ).

This has been done in the attached patch (together with a move of the "Search options" and "Search results" labels in the screenlet title bars)
I do not see any change against the agreed guideline.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613977#action_12613977 ]

Adrian Crum commented on OFBIZ-1879:
------------------------------------

Bruno,

Please take some time to read the UI Layout Best Practices -

http://docs.ofbiz.org/display/OFBADMIN/User+Interface+Layout+Best+Practices

and then spend some time using the Asset Maintenance component (I recently updated it to follow the best practices). Notice how clean and uncluttered the UI is, and how there is very little use of screenlet title bars.

I really appreciate your willingness to work on layout issues - there are many areas of the back office UI that need work and we could sure use your help - but I don't believe the Find Screen Decorator is an area needing work.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613991#action_12613991 ]

Bruno Busco commented on OFBIZ-1879:
------------------------------------

OK Adrian,
no problem, it was only a trivial patch, but you know, when you go on UI
everything is so subjective....
(but we have UI themes coming soon for this! ;-)

Anyway, as suggested, I already started to work with the UI of Catalog
Manager and submitted a patch here
https://issues.apache.org/jira/browse/OFBIZ-1880.
This is only a partial work but it is better to go for steps.

Thank you,
-Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1879) A more compact FindScreenDecorator

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614437#action_12614437 ]

Jacques Le Roux commented on OFBIZ-1879:
----------------------------------------

Bruno,

A quick way too convince us (contributors, commiters, dev. at large) is to shown before/after screens ;o)

Anyway, from Adrian's remark, I think we can close this issue ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1879) A more compact FindScreenDecorator

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-1879.
------------------------------

Resolution: Won't Fix

Yes, sure we can close it.
Thank you for the hint. ;-)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.