OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1880) Using screenlets in Catalog Manager Application

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

15 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1880) Using screenlets in Catalog Manager Application

Using screenlets in Catalog Manager Application
-----------------------------------------------

Key: OFBIZ-1880
URL: https://issues.apache.org/jira/browse/OFBIZ-1880
Project: OFBiz
Issue Type: Improvement
Components: product
Affects Versions: SVN trunk
Reporter: Bruno Busco
Priority: Minor
Attachments: ScreenletCatalog.patch

Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
- The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
- The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
- The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
- A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1880) Using screenlets in Catalog Manager Application

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: ScreenletCatalog.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614383#action_12614383 ]

Jacques Le Roux commented on OFBIZ-1880:
----------------------------------------

Hi Bruno,

I just reviewed and tested your patch. It's ok but some minor things.

1. Please when you remove a file, don't empty it, really remove it. Actually this is not a problem using a tool like Tortoise, but it's a better way of doing it at large. For instance you are deleting 2 times webapp/catalog/includes/appheader.ftl in your patch :o)
2. I was ready to commit your file, but I think your forgot to put in the controller. For 2 reasons : I can't see a duplicated viewmap entry removed, and the link to FIndProduct you added here
+ <menu-item name="main" title="${uiLabelMap.ProductMain}"><link target="main"/></menu-item>
+ <menu-item name="products" title="${uiLabelMap.Products}"><link target="FindProduct"/></menu-item>
+ <menu-item name="featurecats" title="${uiLabelMap.ProductFeatureCats}"><link target="EditFeatureCategories"/></menu-item>
does not exist.

As soon as you will update the patch I will commit thanks

Thanks for you good work !

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614383#action_12614383 ]

jacques.le.roux edited comment on OFBIZ-1880 at 7/17/08 8:12 AM:
-----------------------------------------------------------------

Hi Bruno,

I just reviewed and tested your patch. It's ok but some minor things.

1. Please when you remove a file, don't empty it, really remove it. Actually this is not a problem using a tool like Tortoise, but it's a better way of doing it at large. For instance you are deleting 2 times webapp/catalog/includes/appheader.ftl in your patch :o)
2. I was ready to commit your file, but I think your forgot to put in the controller. For 2 reasons : I can't see a duplicated viewmap entry removed, and the link to FIndProduct you added here
+ <menu-item name="main" title="${uiLabelMap.ProductMain}"><link target="main"/></menu-item>
+ <menu-item name="products" title="${uiLabelMap.Products}"><link target="FindProduct"/></menu-item>
+ <menu-item name="featurecats" title="${uiLabelMap.ProductFeatureCats}"><link target="EditFeatureCategories"/></menu-item>
does not exist.

As soon as you will update the patch I will commit.

Thanks for you good work !

PS : if someone wants to see how it looks it's available on trunk alternate demo server (at least until tonight)

was (Author: jacques.le.roux):
Hi Bruno,

I just reviewed and tested your patch. It's ok but some minor things.

1. Please when you remove a file, don't empty it, really remove it. Actually this is not a problem using a tool like Tortoise, but it's a better way of doing it at large. For instance you are deleting 2 times webapp/catalog/includes/appheader.ftl in your patch :o)
2. I was ready to commit your file, but I think your forgot to put in the controller. For 2 reasons : I can't see a duplicated viewmap entry removed, and the link to FIndProduct you added here
+ <menu-item name="main" title="${uiLabelMap.ProductMain}"><link target="main"/></menu-item>
+ <menu-item name="products" title="${uiLabelMap.Products}"><link target="FindProduct"/></menu-item>
+ <menu-item name="featurecats" title="${uiLabelMap.ProductFeatureCats}"><link target="EditFeatureCategories"/></menu-item>
does not exist.

As soon as you will update the patch I will commit thanks

Thanks for you good work !

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1880:
-------------------------------

Attachment: ScreenletCatalog_1.patch

Jacques,
please find attached a new version of the patch (ScreenletCatalog_1.patch).
I have used the Tortoise delete function but it seems that I get always a patch with the file emptied.
The duplicated viewmap was not in catalog but in content (it is included in the patch)
I removed the products menu item because it points to a screen I am still developing and not finalized yet.

Thank you for reviewing and committing.

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1880.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux

Hi Bruno,

Your patch is in trunk revision: 680086

About Tortoise : what I meaned is that it's a specific Tortoise feature which implies to use Tortoise also to commit (then Tortoise ask you if you want to remove when committing). SO it's ok for a guy like me who is using Windows but its less firendly for a Linux guy for instance. So the easier way, with all tools, is to simply delete the file from the OS side. Maybe you could try svn command line to create the patch or even Subclipse in such cases ? Anyway it's not a big deal ;o)

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617268#action_12617268 ]

Jacques Le Roux commented on OFBIZ-1880:
----------------------------------------

Ah, also a trival thing I just thought about : It's sometimes easier on both side (when there are few patch files) to keep the same name for the patch. Jira takes care of that automatically by greying old patches.

Thanks

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617269#action_12617269 ]

Bruno Busco commented on OFBIZ-1880:
------------------------------------

Thank you for suggestions,
I will keep it in mind next time.

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1880:
-------------------------------

Attachment: extending_commonmenu.patch

An additional patch to make the AppMenu extending the CommonAppMenu as suggested in the dev ML.

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617376#action_12617376 ]

Jacques Le Roux commented on OFBIZ-1880:
----------------------------------------

Thanks Bruno,

Your patch is in trunk revision: 680275

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617774#action_12617774 ]

Jacques Le Roux commented on OFBIZ-1880:
----------------------------------------

Hi Bruno,

I see a problem with this change I did not notice as I only checked in English. Using French (for instance) when the title is too long here are the different browsers behaviour :
FF3 : overrides component at its right side
IE7 : shift components at its right side
Opera 9.02 : truncated

So we should introduce a line wrap here

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-1880:
------------------------------------

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1880:
-------------------------------

Attachment: whitespace.patch

Please find attached whitespace.patch that seems to solve the problem in FF2 e IE7 (not tested on other browsers).
It seems also not to introduce any other problems.

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch, whitespace.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch, whitespace.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617968#action_12617968 ]

Jacques Le Roux commented on OFBIZ-1880:
----------------------------------------

Forgot to say that it's commited in trunk revision 680852.

> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
> Key: OFBIZ-1880
> URL: https://issues.apache.org/jira/browse/OFBIZ-1880
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: extending_commonmenu.patch, ScreenletCatalog.patch, ScreenletCatalog_1.patch, whitespace.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.