[jira] Created: (OFBIZ-1885) Selectable Visual Themes
Locked
12345
12345
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618062#action_12618062 ] David E. Jones commented on OFBIZ-1885: --------------------------------------- I'd say this is a case where a custom cache might be a bad idea. Why not just use the entity engine cache? Then at least it would automatically clear when data is changed, etc. The running time to assemble the list per type based on a cached result from the database should be minimal, so I wouldn't worry about that. On a side note, the visualTheme package name would be the first like that, ie with multiple words combined in. Could we simplify it to just "theme"? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1885: ------------------------------- Attachment: VisualThemeSelection.patch In the attached VisualThemeSelection.patch file there is an implementation of a screen that lets the user choose his personal Visual Theme among the available ones. I tried to follow Adrian's specification (as far as I understood). > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618564#action_12618564 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, Thank you for your contribution. Your patch could be simplified by having the Visual Theme selection form call the setUserPreference request (found in common-controller.xml). > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
Adrian,
I agree that it could be simplyfied using the setUserPreferences request, thanks for the hint, I was also trying to understand how to rewrite it. In any case, if we consider that in the Visual Theme form additional fields could be added later like for example: - Default number of rows to display in the FindScreens - Specific colors for themes that allow the user to change them - etc. may be following the same pattern as done for the preferences form is not wrong. Don't you think so? 2008/7/31 Adrian Crum (JIRA) <[hidden email]> > > [ > https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618564#action_12618564] > > Adrian Crum commented on OFBIZ-1885: > ------------------------------------ > > Bruno, > > Thank you for your contribution. Your patch could be simplified by having > the Visual Theme selection form call the setUserPreference request (found in > common-controller.xml). > > > > Selectable Visual Themes > > ------------------------ > > > > Key: OFBIZ-1885 > > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > > Project: OFBiz > > Issue Type: Improvement > > Components: framework > > Reporter: Adrian Crum > > Priority: Minor > > Attachments: theme_1.zip, visual_themes.patch, > visual_themes.patch, VisualThemeSelection.patch > > > > > > Implement entities, services, and UI artifacts to add support for > selectable Visual Themes. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
Re: [jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
One more consideration...
Since we are thinking now to move the content application in the framework, and having seen that how the Visual Theme is structured is not far from a piece of content that has many pieces of resources linked to it, wouldn't be beneficial to define a VisualTheme just as a particular ContentType and having the contentmgr handling it? 2008/7/31 Bruno Busco (JIRA) <[hidden email]> > > [ > https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Bruno Busco updated OFBIZ-1885: > ------------------------------- > > Attachment: VisualThemeSelection.patch > > In the attached VisualThemeSelection.patch file there is an implementation > of a screen that lets the user choose his personal Visual Theme among the > available ones. > I tried to follow Adrian's specification (as far as I understood). > > > Selectable Visual Themes > > ------------------------ > > > > Key: OFBIZ-1885 > > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > > Project: OFBiz > > Issue Type: Improvement > > Components: framework > > Reporter: Adrian Crum > > Priority: Minor > > Attachments: theme_1.zip, visual_themes.patch, > visual_themes.patch, VisualThemeSelection.patch > > > > > > Implement entities, services, and UI artifacts to add support for > selectable Visual Themes. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Bruno Busco
On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote: > Adrian, > I agree that it could be simplyfied using the setUserPreferences > request, > thanks for the hint, I was also trying to understand how to rewrite > it. > In any case, if we consider that in the Visual Theme form additional > fields > could be added later like for example: > - Default number of rows to display in the FindScreens > - Specific colors for themes that allow the user to change them These sounds more like things that would go directly into the UserPreference stuff, and wouldn't have so much to do with the themes. -David |
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
Adrian,
I am trying to simplify the VisualTheme selection form but unfortunately I need still to learn... Using this form: <form name="VisualTheme" type="single" target="setUserPreference?userPrefTypeId=VISUAL_THEME&userPrefGroupId=GLOBAL_PREFERENCES&userPrefValue=${myTheme}"> <actions> <service service-name="getUserPreference"> <field-map field-name="userPrefTypeId" value="VISUAL_THEME"/> </service> <set field="myTheme" from-field="userPrefValue" default-value="DEFAULT"/> </actions> <field name="myTheme" title="${uiLabelMap.SelectedVisualTheme}"> <drop-down allow-empty="false"> <entity-options description="${description}" entity-name="VisualTheme" key-field-name="visualThemeId"/> </drop-down> </field> <field name="updateButton"><submit/></field> </form> i effectively do not need to define a new service in the Events.xml. The actual selected theme is displayied correctly but when i submit the form i get the following error: The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Problems processing event: java.lang.NoSuchMethodException: org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse) (org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)) Could someone help me? Sorry if it is (as I suppose) a basic question. Thanks, -Bruno 2008/7/31 David E Jones <[hidden email]> > > On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote: > > Adrian, >> I agree that it could be simplyfied using the setUserPreferences request, >> thanks for the hint, I was also trying to understand how to rewrite it. >> In any case, if we consider that in the Visual Theme form additional >> fields >> could be added later like for example: >> - Default number of rows to display in the FindScreens >> - Specific colors for themes that allow the user to change them >> > > These sounds more like things that would go directly into the > UserPreference stuff, and wouldn't have so much to do with the themes. > > -David > > > |
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
I cannot find any usage of the request setUserPreference in OFBiz.
I think that in order to be used as a form target, the method should be defined with a different prototype such as setUserPreference(HttpServletRequest, HttpServletResponse) I have seen that similar event services follow this pattern. Am i right? -Bruno 2008/7/31 Bruno Busco <[hidden email]> > Adrian, > I am trying to simplify the VisualTheme selection form but unfortunately I > need still to learn... > Using this form: > > <form name="VisualTheme" type="single" > target="setUserPreference?userPrefTypeId=VISUAL_THEME&userPrefGroupId=GLOBAL_PREFERENCES&userPrefValue=${myTheme}"> > <actions> > <service service-name="getUserPreference"> > <field-map field-name="userPrefTypeId" > value="VISUAL_THEME"/> > </service> > <set field="myTheme" from-field="userPrefValue" > default-value="DEFAULT"/> > </actions> > > <field name="myTheme" title="${uiLabelMap.SelectedVisualTheme}"> > <drop-down allow-empty="false"> > <entity-options description="${description}" > entity-name="VisualTheme" key-field-name="visualThemeId"/> > </drop-down> > </field> > <field name="updateButton"><submit/></field> > </form> > > i effectively do not need to define a new service in the Events.xml. The > actual selected theme is displayied correctly but when i submit the form i > get the following error: > > The Following Errors Occurred: > > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Problems > processing event: java.lang.NoSuchMethodException: > org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest, > javax.servlet.http.HttpServletResponse) > (org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest, > javax.servlet.http.HttpServletResponse)) > Could someone help me? Sorry if it is (as I suppose) a basic question. > Thanks, > -Bruno > > > > > > 2008/7/31 David E Jones <[hidden email]> > > >> On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote: >> >> Adrian, >>> I agree that it could be simplyfied using the setUserPreferences request, >>> thanks for the hint, I was also trying to understand how to rewrite it. >>> In any case, if we consider that in the Visual Theme form additional >>> fields >>> could be added later like for example: >>> - Default number of rows to display in the FindScreens >>> - Specific colors for themes that allow the user to change them >>> >> >> These sounds more like things that would go directly into the >> UserPreference stuff, and wouldn't have so much to do with the themes. >> >> -David >> >> >> > |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: VisualThemeSelection.patch Bruno, I updated your patch. Take a look. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618930#action_12618930 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Many thanks Adrian, now I understand (and learned) > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1885: ------------------------------- Attachment: theme_1.zip no_screenshot.jpg visualtheme_merged.patch Adrian, I have done the following improvements to the VisualTheme: - added the visualtheme.default property in general.properties This let us select the default theme that will be used as long as the user does not select another one. If the visualtheme.default is not set (as OOTB) then the default theme will be "DEFAULT" - removed the visualtheme record for the "_NA_" UserLogin In this way, if a default theme is specified in the visualtheme.default property it will be used for the login page also. - added a new VisualThemeResource type VT_SCREENSHOT to have a theme preview screenshot - changed the Visual theme selection screen to show the VisualTheme preview screenshot - created the no_screenshot.jpg This, at the moment is a copy of the default.jpg image showing "No photo available", could be something more specific. I merged together the two patches because it was not easy for me to make a patch to a patched and not committed file. I hope its ok with you. The new patch is "VisualTheme_Merged.patch" and should be comprensive of everything needed but the binary file "no_screenshot.jpg" that is attached separately. I attach to this issue also a new theme_1.zip file that now includes the screenshot jpg. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619550#action_12619550 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, Thank you for your continuing work on this. There are a few things that need to be changed however. I don't believe we need a default setting in a properties file. If an installation wanted to have a different default theme, then they could replace it in the VisualThemeResources entity. The _NA_ UserLogin is needed to support a default global preferences setting group. The VT_SCREENSHOT resource is a great idea. The no_screenshot.jpg file is an interesting idea, but it doesn't support internationalization. Maybe we should just display text to indicate there is no screen shot available, or have nothing at all. Merging the two patches is a good idea. That will make it easier for others to evaluate the feature. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-1885: ---------------------------------- Assignee: Adrian Crum > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1885: ------------------------------- Attachment: visualtheme_merged.patch Adrian, I updated the visualtheme_merged.patch replacing the no_screenshot.jpg with a label so that now we support internationalization. For the visualtheme.default property and the "_NA_" Userlogin record I ask you to think about it when you have time becouse this is used is order to: - have the default theme changed very easily. A new theme must be dropped in the hot-deploy folder and the property changed - have also the login screens (when no UserLogin is specified yet) be consistent with the new default theme Moreover, the record for "_NA_" that I removed is for the VisualTheme only and not for the other preferences. If we remove the property then several manual database changes to the VisualThemeResource entities should be required making the default theme not so easy. An option to the property could be a command in the UI like "Set as default theme" this could make the required changes to the VisualThemeResource and be used instead of the property. Of course this command should be only available to users having a theme admin permission (that should be introduced). In order to help people who wants to try the Visual Theme feature I summarize the steps needed: - Apply on a fresh WD the last version of the visualtheme_merged.patch and run ant build - Download the last version of the file theme_1.zip and unzip it the hot-deploy folder - Run OFBiz and import the "ext" reader using webtools - Go to MyPage -> Preferences -> Visual Theme - Select the Theme_1 theme to change the theme > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619936#action_12619936 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, I have already spent a considerable amount of time thinking about user preference settings. I had them implemented where I work years before their introduction to the project. Maybe you aren't understanding how they are intended to to be used. The "_NA_" user login ID found in User Preferences is intended to be used when the user isn't logged into OFBiz (or they are logged in and no preference has been set) and some sort of default values must be supplied. Doing things this way simplifies the code using the preferences - instead of always checking to see if a preference exists, you can assume it exists because the preference data was set up that way. Doing things this way also provides a single point where a particular default value can be changed. In the trunk there is only one global preference implemented - a flag to indicate if the user has JavaScript enabled. (A global preference is a preference that is used by more than one component.) Once the visual theme feature is implemented there will be two global preferences. In a few months there might be more. As time goes on and more global preferences are implemented, it will be easy to have one service call to get them all - by retrieving the GLOBAL_PREFERENCES group. (I'm picturing the global preferences being retrieved by the view handler at the start of view processing. I might even add that change to this issue - I'm still thinking about it.) I believe this process is fundamentally sound and easy for developers to understand. What will cause confusion is when a property and a bit of code changes the behavior of a particular preference. If an installation wants to have a different default theme, then they will only have to overwrite the "_NA_" user login preference record with their own data. One thing we can change to help avoid confusion is the description of the OFBiz default theme. Maybe call it "Standard OFBiz - Floating" or "Original OFBiz - Floating", etc. I would prefer to start off with a simple implementation and see how it goes. If switching default visual themes becomes an issue down the road, then we can address it at that time. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620143#action_12620143 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Thank you for explanation, I now better understand the schema that is behind the VisuaTheme and the user preferences in general. I agree with you that the property will alter the schema and should be avoided using the "_NA_" user login. I will update the patch soon in this direction. BTW I was looking at how to change the ecommerce to make it use a VisualTheme. I am looking at the changes made by you to the CommonSreen.xml and the header.ftl files of the backoffice and trying to replicate in the ecommerce. In this case, I propose, as first step, to have only one VisualTheme defined for the ecommerce in a WebStore field (I am temporary using the StyleSheet field now). So users won't be able to change the theme of the WebStore and no UserPreferences is used. Are you OK with this? Or a different schema should be used? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620146#action_12620146 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, On the eCommerce side, I know David Jones had something in mind already. Let's hold off on that and let others offer their input. We already discussed on the dev mailing list that user preferences would not be used on the eCommerce side. Instead, the theme used would be determined by the store or the catalog. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1885: ------------------------------- Attachment: visualtheme_merged.patch OK, I updated the merged patch according to your recent suggestion. Yes, I agree that for the eCommerce there could be a store or catalog field to specify the theme to be used. May be the "listVisualThemes.ftl" could be converted in a lookup so that it could be easily used in the store or catalog screen to select a theme looking at their screenshot. I will wait to hear from others on this. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visualtheme_merged.patch Updated visualtheme_merged.patch file. Converted the Java service to simple method, cleaned up the Visual Theme selection screen, added a resource type, and changed one resource type. Bruno - you will need to update your zip file to work with the latest patch. I plan to commit this next weekend. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621211#action_12621211 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Adrian, I cannot find the listVisualThemes.ftl file in your last patch. From your comments I guess you changed it. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |