[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visualtheme_merged.patch Updated patch - now includes CRUD services. Still needs permission service and related seed data. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629713#action_12629713 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Hi Adrian, I was trying to give a little contribution on this following your path ("Still needs permission service and related seed data.") Unfortunately patching a fresh OFBiz installation with the latest visualtheme_merged.patch gives me some problem: 1) The listVisualThemes.ftl is expected to be in framework\common\webcommon\includes but the patch puts it into the path where it was earlier (specialpurpose\mypage\webapp\mypage\visualtheme) And I have easily copied the file in my wd to start working 2) When I try to select a different Visual Theme I get the following error: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [updateVisualTheme]; this request does not exist or cannot be called directly. Note that I have accessed the VisualTheme Selection screen from the catalog application. I have a proposal that, if the Community agree, we could continue discussing in the dev ML: Could we have in SVN a "sandboxes" folder where things like this are developed and tested and then merged to the trunk? This will make life very easier instead of building patches over and over and replacing them on a jira issue. Just my two cents. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629716#action_12629716 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Giving a quick look at some other Apache project SVN repositories it seems that some of them also have somethink like this: http://svn.apache.org/repos/asf/ant/sandbox http://svn.apache.org/repos/asf/beehive/sandbox > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629742#action_12629742 ] Jacques Le Roux commented on OFBIZ-1885: ---------------------------------------- Bruno, I'd be interested to see counter arguments to your proposition (if any). But I guess to get a wider audience you should made this proposition on dv ML > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629775#action_12629775 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Jacques, where I work we have set up years ago SVN, Jira, Confluence, Luntbuild etc. so if I propose something is only because I know that using those tools in some way (as for example the sandbox path) is extremely productive. Moreover I see that the OFBiz Community is generally very mind-open and (at least) allows to discuss about these management subjets. I will follow your suggestion to move to the dev ml this thread. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visualtheme_merged.patch Updated patch attached. Bruno, Thank you very much for your continued work on this! I apologize for the difficulty you had with the last patch - I included the wrong file in the patch. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629803#action_12629803 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ No problem at all, Adrian! Thank you. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629903#action_12629903 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Adrian, what do you think of committing this work to a sandbox branch? It will be much simple to work instead of handling all the changes to the patches. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629905#action_12629905 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, I have very little time to spend on this as it is, let alone manage another SVN branch. Why do you feel it is difficult to apply a patch to your local copy? This issue is nearly complete. Once the permissions are in place, I will commit it to the trunk. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1885: ------------------------------- Attachment: visualtheme_merged.patch Adrian, please forget the branch, I thought we where not so close to the commit. Please find attached the updated patch with the permission and seed data. I hope to have done it correctly, if not please advice. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629974#action_12629974 ] Jacques Le Roux commented on OFBIZ-1885: ---------------------------------------- Something I do when I don't want to mix things too much is to create a speficic check out for a specific set of complex functionnalities. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630113#action_12630113 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ We have now the Visual Theme Gallery here: http://docs.ofbiz.org/display/OFBIZ/Visual+Themes+Gallery Just a first try... ;-) > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630160#action_12630160 ] Jacques Le Roux commented on OFBIZ-1885: ---------------------------------------- Not sure for the colors :D but great initiative, yes ! > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632306#action_12632306 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Adrian, I wonder if you are happy with the permission implementation I did. BTW I think we should implement also a permission that controls if a user is allowed to select a different Visual Theme or must use the theme the admin has selected for him. What do you think about? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632314#action_12632314 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, I looked at the screencap of your theme - it looks great! I haven't looked at your patch yet - I don't have the time right now. I will review it and get all of this committed as soon as I have some time. Thank you for your help with this! > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-1885. ------------------------------ Resolution: Fixed Fixed - rev 698346. Thank you Bruno, and others who commented. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634008#action_12634008 ] Hans Bakker commented on OFBIZ-1885: ------------------------------------ perhaps good to mention that the visual themes button can be found on the header of any screen as long as the header is not minimized..... > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634042#action_12634042 ] Jacques Le Roux commented on OFBIZ-1885: ---------------------------------------- Maybe we could put at screen left, near the logo, and show it even when minimized ? In the same spirit we could show the languages link at right when minimized... What do you think guys ? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634046#action_12634046 ] Jacopo Cappellato commented on OFBIZ-1885: ------------------------------------------ In my opinion it is ok to show the link only in the expanded header because changing visual theme is not something that the user will do very often. Jacopo > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In my opinion both Select Visual Theme, Select language and Select Time-zone
should be part of a user preferences/profile screen. The User Preferences screen should be a screen implemented in the common component and should let other applications to insert additional settings application related (perhaps on different tabs). On the header (both expanded and collapsed) there should be a link to the User profile screen. The actual User preferences screen implemented in MyPage should be moved in the common User preferences screen (in a MyPage settings tab). My two cents, Bruno 2008/9/24 Jacopo Cappellato (JIRA) <[hidden email]> > > [ > https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634046#action_12634046] > > Jacopo Cappellato commented on OFBIZ-1885: > ------------------------------------------ > > In my opinion it is ok to show the link only in the expanded header because > changing visual theme is not something that the user will do very often. > Jacopo > > > Selectable Visual Themes > > ------------------------ > > > > Key: OFBIZ-1885 > > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > > Project: OFBiz > > Issue Type: Improvement > > Components: framework > > Reporter: Adrian Crum > > Assignee: Adrian Crum > > Priority: Minor > > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, > theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, > visualtheme_merged.patch, visualtheme_merged.patch, > visualtheme_merged.patch, visualtheme_merged.patch, > visualtheme_merged.patch, visualtheme_merged.patch, > visualtheme_merged.patch, visualtheme_merged.patch, > visualtheme_merged.patch, visualtheme_merged.patch, > VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip > > > > > > Implement entities, services, and UI artifacts to add support for > selectable Visual Themes. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
Free forum by Nabble | Edit this page |