[jira] Created: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
Locked
[jira] Created: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
 
|
Product default image I18N (CONTRIBUTION)
----------------------------------------- Key: OFBIZ-1897 URL: https://issues.apache.org/jira/browse/OFBIZ-1897 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: Ubuntu 8.04, JDK 1.5 Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) Fix For: SVN trunk Attachments: defaultImage-I18N.patch I have added support for internationalizing the Product's defaultImage.jpg. Attached I have included the patch. Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] J.Enrique Ruiz (DiSiD Technologies S.L.) updated OFBIZ-1897: ------------------------------------------------------------ Attachment: defaultImage-I18N.patch > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617144#action_12617144 ] Bruno Busco commented on OFBIZ-1897: ------------------------------------ Interesting...but... ...shouldn't we use the new XML format for things like this? We have moved away (almost completely) from the .properties format for locale dependent stuff. > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617145#action_12617145 ] J.Enrique Ruiz (DiSiD Technologies S.L.) commented on OFBIZ-1897: ----------------------------------------------------------------- Ups, sorry, I didn't know this new XML format. Do you have some link or reference to learn about this theme? > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617148#action_12617148 ] Jacques Le Roux commented on OFBIZ-1897: ---------------------------------------- Yes, and please take care of tabs in your patches. BTW I'm near ready to commit your contribution on datafile but I take the time to convert the bsh to groovy (another new "feature" ;o) Thanks > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617150#action_12617150 ] Bruno Busco commented on OFBIZ-1897: ------------------------------------ Enrique, you can just look for any *UILabels.xml file. They are tipically located in the component/config folder. The schema is really simple. > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617153#action_12617153 ] Bruno Busco commented on OFBIZ-1897: ------------------------------------ Jacques, I cannot see any bsh file in the patch. It is as simple as a definition of a locale dependent string and a replace of a constant file name with that string. > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617161#action_12617161 ] Jacques Le Roux commented on OFBIZ-1897: ---------------------------------------- Buno, Quiproco : in "I'm near ready to commit your contribution on datafile" I was speaking about OFBIZ-1888 :D > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617194#action_12617194 ] David E. Jones commented on OFBIZ-1897: --------------------------------------- Why wouldn't we put this sort of setting in the database, like we do with the other content settings? > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617545#action_12617545 ] Bruno Busco commented on OFBIZ-1897: ------------------------------------ David, could you please give some more details about your suggested way of doing this? I have tryed the following but I am not sure to be on the right path: I have created two Image-type DataResources one with locale "en" and one with locale "it". For each one of them I uploaded a proper image. The two DataResources have, of course, got two different dataResourceId. I can display the first with: http://localhost:8080/content/control/ViewSimpleContent?dataResourceId=defaultimage and the second with: http://localhost:8080/content/control/ViewSimpleContent?dataResourceId=10000 Is there a way to embed the locale in the link and have the content manager select the correct dataResource? Many thanks > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617547#action_12617547 ] David E. Jones commented on OFBIZ-1897: --------------------------------------- Localization in content rendering is done through the Content entity, using the ContentAssoc with a type of alternate locale. DataResource records are much more simple and meant to be in a single locale, and not have related data resources in alternate locales (in other words the association is done through the alternate locale). You can look at the ecommerce/data product demo data to see some examples of products with content in multiple locales. > Product default image I18N (CONTRIBUTION) > ----------------------------------------- > > Key: OFBIZ-1897 > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Environment: Ubuntu 8.04, JDK 1.5 > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > Fix For: SVN trunk > > Attachments: defaultImage-I18N.patch > > > I have added support for internationalizing the Product's defaultImage.jpg. > Attached I have included the patch. > Best regards. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
Many thanks,
now it is very clear and I was able to link all content and DataResourse together. BTW, was this the suggested way to implement the locale dependent "No photo available" image? 2008/7/28 David E. Jones (JIRA) <[hidden email]> > > [ > https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617547#action_12617547] > > David E. Jones commented on OFBIZ-1897: > --------------------------------------- > > Localization in content rendering is done through the Content entity, using > the ContentAssoc with a type of alternate locale. > > DataResource records are much more simple and meant to be in a single > locale, and not have related data resources in alternate locales (in other > words the association is done through the alternate locale). > > You can look at the ecommerce/data product demo data to see some examples > of products with content in multiple locales. > > > Product default image I18N (CONTRIBUTION) > > ----------------------------------------- > > > > Key: OFBIZ-1897 > > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 > > Project: OFBiz > > Issue Type: Improvement > > Components: order > > Affects Versions: SVN trunk > > Environment: Ubuntu 8.04, JDK 1.5 > > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) > > Fix For: SVN trunk > > > > Attachments: defaultImage-I18N.patch > > > > > > I have added support for internationalizing the Product's > defaultImage.jpg. > > Attached I have included the patch. > > Best regards. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
Re: [jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
For instance it seems that the images displayed in the ecommerce are using
the URL in the Product entity and not going through the content manager. Should we implement a different thing for the "No photo available" image? 2008/7/28 Bruno Busco <[hidden email]> > Many thanks, > now it is very clear and I was able to link all content and DataResourse > together. > > BTW, was this the suggested way to implement the locale dependent "No photo > available" image? > > > 2008/7/28 David E. Jones (JIRA) <[hidden email]> > > >> [ >> https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617547#action_12617547] >> >> David E. Jones commented on OFBIZ-1897: >> --------------------------------------- >> >> Localization in content rendering is done through the Content entity, >> using the ContentAssoc with a type of alternate locale. >> >> DataResource records are much more simple and meant to be in a single >> locale, and not have related data resources in alternate locales (in other >> words the association is done through the alternate locale). >> >> You can look at the ecommerce/data product demo data to see some examples >> of products with content in multiple locales. >> >> > Product default image I18N (CONTRIBUTION) >> > ----------------------------------------- >> > >> > Key: OFBIZ-1897 >> > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 >> > Project: OFBiz >> > Issue Type: Improvement >> > Components: order >> > Affects Versions: SVN trunk >> > Environment: Ubuntu 8.04, JDK 1.5 >> > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) >> > Fix For: SVN trunk >> > >> > Attachments: defaultImage-I18N.patch >> > >> > >> > I have added support for internationalizing the Product's >> defaultImage.jpg. >> > Attached I have included the patch. >> > Best regards. >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> > |
Re: [jira] Commented: (OFBIZ-1897) Product default image I18N (CONTRIBUTION)
|
|
This is the standard pattern for Product Content, as mentioned in various places. If there is a field on the Product entity for a given ProductContentType and it is not empty, then it will be used instead of looking up content through the ProductContent entity. -David On Mon, 28 Jul 2008 23:40:57 +0200, "Bruno Busco" <[hidden email]> wrote: > For instance it seems that the images displayed in the ecommerce are using > the URL in the Product entity and not going through the content manager. > Should we implement a different thing for the "No photo available" image? > > > 2008/7/28 Bruno Busco <[hidden email]> > >> Many thanks, >> now it is very clear and I was able to link all content and DataResourse >> together. >> >> BTW, was this the suggested way to implement the locale dependent "No > photo >> available" image? >> >> >> 2008/7/28 David E. Jones (JIRA) <[hidden email]> >> >> >>> [ >>> > https://issues.apache.org/jira/browse/OFBIZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617547#action_12617547] >>> >>> David E. Jones commented on OFBIZ-1897: >>> --------------------------------------- >>> >>> Localization in content rendering is done through the Content entity, >>> using the ContentAssoc with a type of alternate locale. >>> >>> DataResource records are much more simple and meant to be in a single >>> locale, and not have related data resources in alternate locales (in > other >>> words the association is done through the alternate locale). >>> >>> You can look at the ecommerce/data product demo data to see some > examples >>> of products with content in multiple locales. >>> >>> > Product default image I18N (CONTRIBUTION) >>> > ----------------------------------------- >>> > >>> > Key: OFBIZ-1897 >>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1897 >>> > Project: OFBiz >>> > Issue Type: Improvement >>> > Components: order >>> > Affects Versions: SVN trunk >>> > Environment: Ubuntu 8.04, JDK 1.5 >>> > Reporter: J.Enrique Ruiz (DiSiD Technologies S.L.) >>> > Fix For: SVN trunk >>> > >>> > Attachments: defaultImage-I18N.patch >>> > >>> > >>> > I have added support for internationalizing the Product's >>> defaultImage.jpg. >>> > Attached I have included the patch. >>> > Best regards. >>> >>> -- >>> This message is automatically generated by JIRA. >>> - >>> You can reply to this email to add a comment to the issue online. >>> >>> >> > > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |