OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1914) form 'extend' will can bring system in a loop

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1914) form 'extend' will can bring system in a loop

form 'extend' will can bring system in a loop
---------------------------------------------

Key: OFBIZ-1914
URL: https://issues.apache.org/jira/browse/OFBIZ-1914
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Environment: any
Reporter: Hans Bakker
Fix For: SVN trunk

If a form xml extends a form from a second form xml file and that second form xml extends a diferent form in the first xml file, the system comes in a loop. The prohibits the reusage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:

2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml

my knowledge of the widget frmaework system is restricted...if anybody can help?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1914) form 'extend' can bring system in a loop

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-1914:
-------------------------------

Description:
If a form xml extends a form from a second form xml file and that second form xml extends a different form in the first xml file, the system comes in a loop. This prohibits the re-usage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:

2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml

my knowledge of the widget frmaework system is restricted...if anybody can help?

was:
If a form xml extends a form from a second form xml file and that second form xml extends a diferent form in the first xml file, the system comes in a loop. The prohibits the reusage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:

2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml

my knowledge of the widget frmaework system is restricted...if anybody can help?

Summary: form 'extend' can bring system in a loop (was: form 'extend' will can bring system in a loop)

> form 'extend' can bring system in a loop
> ----------------------------------------
>
> Key: OFBIZ-1914
> URL: https://issues.apache.org/jira/browse/OFBIZ-1914
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Fix For: SVN trunk
>
>
> If a form xml extends a form from a second form xml file and that second form xml extends a different form in the first xml file, the system comes in a loop. This prohibits the re-usage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:
> 2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> 2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> my knowledge of the widget frmaework system is restricted...if anybody can help?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621202#action_12621202 ]

David E. Jones commented on OFBIZ-1914:
---------------------------------------

Is there a way to reproduce this in the current SVN? If so, how/where does one do that? If not, could you commit something or attach a patch and also describe the how/where so that people reviewing this can try it on their own.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621204#action_12621204 ]

Hans Bakker commented on OFBIZ-1914:
------------------------------------

Yes sure david, there is a way to test if you have a look at the changes in revision: 684392 where i used a work around by copying the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661334#action_12661334 ]

Adrian Crum commented on OFBIZ-1914:
------------------------------------

Actually, what Hans is reporting makes a lot of sense. A quick look at the ModelForm code confirms he is correct.

FormA in TheseForms.xml extends FormB in ThoseForms.xml. During FormA construction, ThoseForms.xml is parsed in order to get FormB. But in ThoseForms.xml there is a FormC that extends FormD in TheseForms.xml. So, TheseForms.xml is parsed, and the endless loop begins...

An interesting conundrum.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661448#action_12661448 ]

David E. Jones commented on OFBIZ-1914:
---------------------------------------

It sounds like we need to separate the parsing from the post-parse processing.

The entity and services engines do this, but in a way that I don't think will work here... they read in the entire model and process extensions and inheritances after everything is read in.

While we can't do one big pass for all form files (they are only read when used unlike the entity and service defs), we can split it into a cached parse and a post-process that is not part of the parse. The post-processing would be done one form within the file at a time to avoid the circular looping, and with a method on the form class itself that would keep track of whether or not the post-processing had already been done. When the form extension code runs it would get the form from the cache (as now), and then make sure the post-processing is done just for that form.

Is anyone already looking at this? If not I'll take a gander in the near future...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661597#action_12661597 ]

Adrian Crum commented on OFBIZ-1914:
------------------------------------

David,

I was thinking about a solution along the same line as you.

I think we only need to change the parsing logic so that only the requested form is parsed and constructed - not the entire file. In other words, each form would have its own cache entry - instead of each form file being a cache entry. I don't think we would need any parse/post-process separation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661604#action_12661604 ]

Jacques Le Roux commented on OFBIZ-1914:
----------------------------------------

Looks like a good idea Adrian (without any further analysis though)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-1914:
----------------------------------

Assignee: Adrian Crum

> form 'extend' can bring system in a loop
> ----------------------------------------
>
> Key: OFBIZ-1914
> URL: https://issues.apache.org/jira/browse/OFBIZ-1914
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Adrian Crum
> Fix For: SVN trunk
>
>
> If a form xml extends a form from a second form xml file and that second form xml extends a different form in the first xml file, the system comes in a loop. This prohibits the re-usage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:
> 2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> 2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> my knowledge of the widget frmaework system is restricted...if anybody can help?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1914:
-------------------------------

Attachment: FormFactoryFix.patch

FormFactoryFix.patch should solve the problem.

Hans - could you give it a try on the forms you were having problems with?

> form 'extend' can bring system in a loop
> ----------------------------------------
>
> Key: OFBIZ-1914
> URL: https://issues.apache.org/jira/browse/OFBIZ-1914
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Adrian Crum
> Fix For: SVN trunk
>
> Attachments: FormFactoryFix.patch
>
>
> If a form xml extends a form from a second form xml file and that second form xml extends a different form in the first xml file, the system comes in a loop. This prohibits the re-usage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:
> 2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> 2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> my knowledge of the widget frmaework system is restricted...if anybody can help?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-1914:
-------------------------------

Attachment: makeError.diff

i tested the patch and Yes, the problem seems to be fixed.

If you want to create the error yourself i attached the patch here......

good Job Adrian! Thanks.

> form 'extend' can bring system in a loop
> ----------------------------------------
>
> Key: OFBIZ-1914
> URL: https://issues.apache.org/jira/browse/OFBIZ-1914
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Adrian Crum
> Fix For: SVN trunk
>
> Attachments: FormFactoryFix.patch, makeError.diff
>
>
> If a form xml extends a form from a second form xml file and that second form xml extends a different form in the first xml file, the system comes in a loop. This prohibits the re-usage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:
> 2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> 2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> my knowledge of the widget frmaework system is restricted...if anybody can help?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1914) form 'extend' can bring system in a loop

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1914.
------------------------------

Resolution: Fixed

Fixed, rev 733087.

> form 'extend' can bring system in a loop
> ----------------------------------------
>
> Key: OFBIZ-1914
> URL: https://issues.apache.org/jira/browse/OFBIZ-1914
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Adrian Crum
> Fix For: SVN trunk
>
> Attachments: FormFactoryFix.patch, makeError.diff
>
>
> If a form xml extends a form from a second form xml file and that second form xml extends a different form in the first xml file, the system comes in a loop. This prohibits the re-usage of forms significantly. An example of the log file when i want to use a communication list on a request and a request list on a communication:
> 2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.014s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.016s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> 2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.065s: file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [ UtilXml.java:241:INFO ] XML Read 0.047s: file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> my knowledge of the widget frmaework system is restricted...if anybody can help?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.