[jira] Created: (OFBIZ-1922) List and Multi form pagination labels are not localized

[Nicolas Malin (Jira)]

List and Multi form pagination labels are not localized
-------------------------------------------------------

                 Key: OFBIZ-1922
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Bruno Busco
            Priority: Minor


The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1922:
-------------------------------

    Attachment: prevnext_localized.patch

The attached patch gets the First,Prev,Next,Last labels in a List/Multi form localized.

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628202#action_12628202 ]

Bilgin Ibryam commented on OFBIZ-1922:
--------------------------------------

Bruno,

your patch is ready to commit, but I think it is good to update also the widget-form.xsd, where it says:  Defaults to "First". The same for prev, next, last.

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1922:
-------------------------------

    Attachment: prevnext_localized.patch

Bilgin,
thank you for reviewing the patch. Please find attached a new one with the suggested updates.

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: prevnext_localized.patch, prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628279#action_12628279 ]

Bilgin Ibryam commented on OFBIZ-1922:
--------------------------------------

Bruno, thanks for updating the patch.

I also attached a related patch (commonDisplay.patch) which replace CommonOf label with CommonDisplayinf label in pagination section and also fix a bug for displaying page numbers even with javascipt disabled.

Now we need someone with framework access to commit both patches :)

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: prevnext_localized.patch, prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1922:
---------------------------------

    Attachment: commonDisplay.patch

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: commonDisplay.patch, prevnext_localized.patch, prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1922:
--------------------------------------

    Assignee: Jacques Le Roux

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: commonDisplay.patch, prevnext_localized.patch, prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1922.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Bruno and Bilgin,

You patches are in trunk revision: 691953

Great to see good cooperation at work :)

> List and Multi form pagination labels are not localized
> -------------------------------------------------------
>
>                 Key: OFBIZ-1922
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1922
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: commonDisplay.patch, prevnext_localized.patch, prevnext_localized.patch
>
>
> The "First", "Last", "Previous", "Next" labels in the pagination controls for list and multi form widgets are not localized.
> Moreover the "Multi" form widget only renders the pagination controls at the bottom of the form and not at the top.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.