[jira] Created: (OFBIZ-1923) Add geolocation to data model.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
Add geolocation to data model.
------------------------------

                 Key: OFBIZ-1923
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
             Project: OFBiz
          Issue Type: New Feature
          Components: accounting, framework, party, product
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux
            Assignee: Jacques Le Roux
             Fix For: SVN trunk
         Attachments: geopoint.patch

The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: geopoint.patch

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: geopoint.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623535#action_12623535 ]

David E. Jones commented on OFBIZ-1923:
---------------------------------------

A couple of thoughts:

1. make sure it is GeoPoint.geoPointId, not GeoPointId
2. the comment on the comment field should go in the field->description sub-element
3. make sure to start a fresh copy of OFBiz with this running (with add missing set to false if you don't want it to change your db) and make sure the entity engine checks don't complain about anything

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: geopoint.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment:     (was: geopoint.patch)

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623562#action_12623562 ]

Jacques Le Roux commented on OFBIZ-1923:
----------------------------------------

Thank for your comment David,

1 and 2 done in new patch, I also moved above (in its block)  the entity AgreementEmploymentAppl.
For 3, I get warns about joint entities FixedAssetGeoPoint and PartyAssetGeoPoint and field missing in related entities, like <<The number of primary keys (3) of related entity PartyGeoPoint does not match the number of keymaps (1) for relation of type one "PartyGeoPoint" of entity Party.>>. I foresaw that but I did not know how to deal with since adding the required fields (geoPointId and fromDate) to Party and FixedAsset sounds weird to me. Maybe we could remove the geoPointId from keymaps in joint entities, since fromDate should be sufficient, and then add only the fromDate field in Party and Fixedasset, maybe with a thruDate field too then ?

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment:     (was: GeopointDataModel.patch)

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623649#action_12623649 ]

BJ Freeman commented on OFBIZ-1923:
-----------------------------------

I see you chose Dataresource
how do you see linking this to the source of the data


> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623664#action_12623664 ]

Jacques Le Roux commented on OFBIZ-1923:
----------------------------------------

By adding something like that in entity DataSource

dataSourceId      dataSourceTypeId      description
YAHOO                 GEO_POINT                Terrestial position from Yahoo
GOOGLE              GEO_POINT                Terrestial position from Google
...

I wait to be sure of the data model before adding any data and labels (one label, at least, is needed for GEO_POINT)

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623762#action_12623762 ]

David E. Jones commented on OFBIZ-1923:
---------------------------------------

What is the "AgreementEmploymentAppl" entity doing in there?

As for PartyGeoPoint, it should point to Party but no need for one in the other direction, the entity engine would automatically add the reverse type "many" relationship.

It wouldn't really make much sense to try to have a type one relationship going from Party to PartyGeoPoint, but yes if you wanted to do that you would have to have fields for the full PK of PartyGeoPoint on the Party entity (but no, we don't want to do that...).

-David

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623779#action_12623779 ]

Jacques Le Roux commented on OFBIZ-1923:
----------------------------------------

Thanks David,

For AgreementEmploymentAppl, its package-name="org.ofbiz.party.agreement" so I moved it up to its block (from org.ofbiz.party.party to org.ofbiz.party.agreement). If you think it should not be in the party entitymodel it should be discussed in dev ML as I have no ideas why it was put there... But it seems correct to me (its about employment and agreement after all, so org.ofbiz.party.agreement sounds to be the right package)

For PartyGeoPoint  and FixedAssetGeoPoint  it's clearer now I will change the direction of relations.

I will then provides some data, and will make some tests...

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623783#action_12623783 ]

Jacques Le Roux commented on OFBIZ-1923:
----------------------------------------

Afterthought : I really don't know why I used a one relationship from Party to its geo location history. This makes no sense at all... I guess I did copy the lines from somewhere but did not think much about their contents...

Thanks for your clear explanation !

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment:     (was: GeopointDataModel.patch)

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623783#action_12623783 ]

jacques.le.roux edited comment on OFBIZ-1923 at 8/19/08 1:35 PM:
-----------------------------------------------------------------

Afterthought : I think I was thinking that the relationship comes from Party to its geo location history.  But I really don't know why I used a *one* relationship from Party to its geo location history. This makes no sense at all... I guess I did copy the lines from somewhere but did not think much about their contents...


Thanks for your clear explanation ! I forgot that the entity engine is able to automatically create the reverse many relationship. It"s easier to do it in this direction...

      was (Author: jacques.le.roux):
    Afterthought : I really don't know why I used a one relationship from Party to its geo location history. This makes no sense at all... I guess I did copy the lines from somewhere but did not think much about their contents...

Thanks for your clear explanation !
 

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623823#action_12623823 ]

David E. Jones commented on OFBIZ-1923:
---------------------------------------

For the PartyGeoPoint and FixedAssetGeoPoint entities they should have a type one relationship to each other record they refer to, in this case both the Party entity (which you have) and the GeoPoint entity (which you don't have).

On a side note: this is why I'm a little picky about who makes data model changes... they aren't too complex but for anyone that hasn't done them a fair amount it is easy to miss things, and once the entities are used becomes difficult to fix. In any case, these are looking pretty good, so great job on your efforts here.

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623927#action_12623927 ]

Jacques Le Roux commented on OFBIZ-1923:
----------------------------------------

Yes of course a joint entity must join entities. It's obvious, but as you said you have to have write some to be acquainted with it. And as you may know, I'm more inclined to code. I guess I learn some with this work, reading books is not enough... practice, practice, pratice...

Thanks for your support !

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1923) Add geolocation to data model.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

Thanks to David's patience, I think the data model is ok now

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12