[jira] Created: (OFBIZ-1928) The abiltiy to specify the facility a product should reserve inventory from

[Nicolas Malin (Jira)]

The abiltiy to specify the facility a product should reserve inventory from
---------------------------------------------------------------------------

                 Key: OFBIZ-1928
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
             Project: OFBiz
          Issue Type: New Feature
          Components: order
    Affects Versions: SVN trunk
         Environment: Windows XP, Eclipse
            Reporter: Len Shein
            Priority: Minor


Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.

Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Len Shein updated OFBIZ-1928:
-----------------------------

    Attachment: AddFacilityIdToShipGroup.txt

Files Changed:
ShoppingCart.java
OrderServices.java
ProductStoreServices.xml
services_store.xml
entityModel.xml  (applications/order/entitydef)

The GUI enhancements needed to accept a facility  during order entry.  This patch covers the underlying services.

> The abiltiy to specify the facility a product should reserve inventory from
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Len Shein updated OFBIZ-1928:
-----------------------------

    Summary: Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.  (was: The abiltiy to specify the facility a product should reserve inventory from)

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1928:
------------------------------------

    Assignee: Bilgin Ibryam

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624355#action_12624355 ]

Bilgin Ibryam commented on OFBIZ-1928:
--------------------------------------

Hi Len,
there are some tabs in your patch. Can you replace them with spaces please.

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624357#action_12624357 ]

Len Shein commented on OFBIZ-1928:
----------------------------------

Bilgin,

You jut need me to replace all tabbing in both xml and java files with
spaces?

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624359#action_12624359 ]

Bilgin Ibryam commented on OFBIZ-1928:
--------------------------------------

Yes, and then I can review better the reservation part modifications.
BTW these are the coding conventions (in case you missed them) http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Len Shein updated OFBIZ-1928:
-----------------------------

    Attachment: UpdatedAddFacilityIdToShipGroup.txt

If I may ask, how can you tell there are tabs in the file?


I removed by hand in the attached patch.  If you let me know this is OK I
will properly attach it to the issue.

My apologies for the inconvenience.

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1928.
--------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625668#action_12625668 ]

Bilgin Ibryam commented on OFBIZ-1928:
--------------------------------------

Thanks for your work Len.
I did some clean ups and committed your patch in trunk rev 688993.
Also added a dropdown button to choose a facility in order manager shipping screen.

About tabs:
If you are using eclipse, you can read the comments from the link above.
For other editors, you have to check formating options of the editor.

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625669#action_12625669 ]

Jacques Le Roux commented on OFBIZ-1928:
----------------------------------------

Interesting, thanks Len (and BTW Bilgin for commit ;o)

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625673#action_12625673 ]

Jacques Le Roux commented on OFBIZ-1928:
----------------------------------------

I did a quick review, there is one point that should have been dealed with :

<fail-message message="ProductStore with id ${productStoreId} has Y for oneInventoryFacility but inventoryFacilityId is empty, not reserving inventory."/>
<fail-message message="Facility with id ${parameters.facilityId} is not associated to ProductStore with id ${parameters.productStoreId}, not reserving inventory."/

These are not localisable :/

I know it does not come from you as it was already in code. But please, in such cases use rather <fail-property> instead. I even opened a Jira issue for this OFBIZ-1874

Thanks for the good work !

PS : It's ok for logs of course

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625678#action_12625678 ]

Jacques Le Roux commented on OFBIZ-1928:
----------------------------------------

Also please fill this page as much as possible : http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625695#action_12625695 ]

Bilgin Ibryam commented on OFBIZ-1928:
--------------------------------------

Jacques, thanks for the tips.
BTW why this commit should go to "Upgrading OFBiz from earlier revisions" ?

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625699#action_12625699 ]

Jacques Le Roux commented on OFBIZ-1928:
----------------------------------------

Because of changes in applications/order/entitydef/entitymodel.xml.
This is only needed for people wanting to use this new feature though.
But I agree with Hans that having traces of any data model change there should be a good thing...

> Allow the Shopping Cart to accept a facility per ship group to specify where inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1928
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, Eclipse
>            Reporter: Len Shein
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AddFacilityIdToShipGroup.txt, UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id.  On order generation the facility id is then stored in entity OrderItemShipGroup.  During the reserve Inventory process inventory is then reserved from the specified ship group facility.
> Patch file to be attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.