OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

15 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

Replacement of FTL TabBars with menus widgets in catalog application
--------------------------------------------------------------------

Key: OFBIZ-1950
URL: https://issues.apache.org/jira/browse/OFBIZ-1950
Project: OFBiz
Issue Type: Improvement
Components: product
Affects Versions: SVN trunk
Reporter: Bruno Busco
Priority: Minor
Attachments: catalog_tabbars.patch

Hi,
the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.

Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.

I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628926#action_12628926 ]

BJ Freeman commented on OFBIZ-1950:
-----------------------------------

I have not looked at the patch yet.
I am wondering if you kept the configuration to remove tabs in the Web.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628945#action_12628945 ]

Bruno Busco commented on OFBIZ-1950:
------------------------------------

BJ,
I don't understand what you mean. Could you please explain?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1950:
-------------------------------

Attachment: catalog_tabbars.patch

There was one *TabBar.ftl file still present in catalog webapp.
Now with this updated patch all *TabBar.ftl files in catalog webapp have been replaces by menu widgets.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628947#action_12628947 ]

Bruno Busco commented on OFBIZ-1950:
------------------------------------

Hi,
I have done some progress in order to have the pages well aligned both in FF and in IE.

I just added in maincss.css the rule:
.leftonly .clear {
clear: none;
}

after the already present rule:
.no-clear .clear {
/* Used in container elements to override the clear class
in contained elements. */
clear: none;
}

I am not sure this is the best solution, I look forward to some help on this.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628973#action_12628973 ]

Adrian Crum commented on OFBIZ-1950:
------------------------------------

I'm surprised you didn't figure out the solution after seeing the .no-clear .clear CSS style.

Add the no-clear CSS style to the menu style and the problem will go away. No new styles are needed.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1950:
-------------------------------

Attachment: catalog_tabbars.patch

Thank you Adrian!
I implemented the change you suggested and everything is ok now!
Please find attached an updated patch.

Using the menu widgets extends property it has been sufficient to add the class in a single place.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629102#action_12629102 ]

BJ Freeman commented on OFBIZ-1950:
-----------------------------------

My oops.
thought you were talking about the application Tab.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Bruno Busco

Re: [jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

Could please someone review this patch?
Should I proceed with more coversions?
Thank you
-Bruno

2008/9/8 BJ Freeman (JIRA) <[hidden email]>

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629102#action_12629102]
>
> BJ Freeman commented on OFBIZ-1950:
> -----------------------------------
>
> My oops.
> thought you were talking about the application Tab.
>
> > Replacement of FTL TabBars with menus widgets in catalog application
> > --------------------------------------------------------------------
> >
> > Key: OFBIZ-1950
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: product
> > Affects Versions: SVN trunk
> > Reporter: Bruno Busco
> > Priority: Minor
> > Attachments: catalog_tabbars.patch, catalog_tabbars.patch,
> catalog_tabbars.patch
> >
> >
> > Hi,
> > the attached patch replaces all *TabBar.ftl files of the catalog
> application with menu widgets.
> > Using the menu widget the html is more consistent. for example the
> "selected" class is always applied to the <li> tag and not to the <a> tag of
> the menu.
> > Unfortunately I am facing a problem that I have not yet solved: using
> menu widgets with FF3, and in some case with IE also, the catalog
> application pages are not displayed correctly. The content of the main area
> after the TabBar menu is located at the very bottom of the page, after the
> end of the left column content.
> > I have seen that removing the .clear rule in the .css this is solved but
> then more problem come with the main menu.
> > Any idea on how to solve this?
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1950:
------------------------------------

Assignee: Bilgin Ibryam

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1950:
---------------------------------

Attachment: product.png

Bruno,

there is still one issue. You can see from the attached image, that the "Product For" doesn't appear on a new line.
In the ftls, this is solved by adding an extra <br/>. Not sure how to do it in menu widgets.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch, product.png
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1950:
-------------------------------

Attachment: maincss_tabbar.patch

Bilgin,
thank you for reviewing the patch.
In order to fix it I found that the maincss.css should be updated with the attached patch.

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch, maincss_tabbar.patch, product.png
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632557#action_12632557 ]

Bilgin Ibryam commented on OFBIZ-1950:
--------------------------------------

I can commit catalog_tabbars.patch but for maincss_tabbar.patch we need someone with framework commit access.
May be Adrian can check maincss_tabbar.patch :)

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch, maincss_tabbar.patch, product.png
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1950.
--------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

Bruno sorry committing so late.
It is in trunk r705940

> Replacement of FTL TabBars with menus widgets in catalog application
> --------------------------------------------------------------------
>
> Key: OFBIZ-1950
> URL: https://issues.apache.org/jira/browse/OFBIZ-1950
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch, maincss_tabbar.patch, product.png
>
>
> Hi,
> the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets.
> Using the menu widget the html is more consistent. for example the "selected" class is always applied to the <li> tag and not to the <a> tag of the menu.
> Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content.
> I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu.
> Any idea on how to solve this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.