[jira] Created: (OFBIZ-1978) createShipment parameters : add a shipmentId in IN parameters

[Nicolas Malin (Jira)]

createShipment parameters : add a shipmentId in IN parameters
-------------------------------------------------------------

                 Key: OFBIZ-1978
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
             Project: OFBiz
          Issue Type: Improvement
          Components: product
            Reporter: Charles STELTZLEN
            Priority: Minor


In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId.
So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-1978:
---------------------------------

    Attachment: shipment.patch

> createShipment parameters : add a shipmentId in IN parameters
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Charles STELTZLEN
>            Priority: Minor
>         Attachments: shipment.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId.
> So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637126#action_12637126 ]

nicolas malin commented on OFBIZ-1978:
--------------------------------------

The problem is present when ofbiz is a slave on shipment system.
He receive order from the master to send package with given shipmentId. It's more easier in ofbiz to create the shipment with a shipmentId given by the master.

> createShipment parameters : add a shipmentId in IN parameters
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Charles STELTZLEN
>            Priority: Minor
>         Attachments: shipment.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId.
> So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1978.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks  Charles and Nicolas,

This makes sense indeed and is harmfull anyway.
Your patch is commited in revision: 702232  

> createShipment parameters : add a shipmentId in IN parameters
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Charles STELTZLEN
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId.
> So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637205#action_12637205 ]

Bilgin Ibryam commented on OFBIZ-1978:
--------------------------------------

Jacques, you mean harmless probably ;)

> createShipment parameters : add a shipmentId in IN parameters
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Charles STELTZLEN
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId.
> So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637183#action_12637183 ]

jacques.le.roux edited comment on OFBIZ-1978 at 10/6/08 1:23 PM:
-----------------------------------------------------------------

Thanks  Charles and Nicolas,

This makes sense indeed and is harmless anyway.
Your patch is commited in revision: 702232  


      was (Author: jacques.le.roux):
    Thanks  Charles and Nicolas,

This makes sense indeed and is harmfull anyway.
Your patch is commited in revision: 702232  

 

> createShipment parameters : add a shipmentId in IN parameters
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Charles STELTZLEN
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId.
> So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Jacques Le Roux]

Oops, yes thanks Bilgin !
I certainly wanted to write not harmful and forgot the not, harmless is better anyway, amended

Jacques

From: "Bilgin Ibryam (JIRA)" <[hidden email]>

>
>    [
> https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637205#action_12637205 ]
>
> Bilgin Ibryam commented on OFBIZ-1978:
> --------------------------------------
>
> Jacques, you mean harmless probably ;)
>
>> createShipment parameters : add a shipmentId in IN parameters
>> -------------------------------------------------------------
>>
>>                 Key: OFBIZ-1978
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1978
>>             Project: OFBiz
>>          Issue Type: Improvement
>>          Components: product
>>            Reporter: Charles STELTZLEN
>>            Assignee: Jacques Le Roux
>>            Priority: Minor
>>             Fix For: SVN trunk
>>
>>         Attachments: shipment.patch
>>
>>   Original Estimate: 0.5h
>>  Remaining Estimate: 0.5h
>>
>> In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in
>> some business, and I think it won't be difficult to add a IN parameter shipmentId.
>> So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will
>> get the next sequenced id (as it already done in the createShipment service).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>