[jira] Created: (OFBIZ-1987) Change createOrderShipmentPlan service

[Nicolas Malin (Jira)]

Change createOrderShipmentPlan service
--------------------------------------

                 Key: OFBIZ-1987
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
             Project: OFBiz
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
            Reporter: nicolas malin
            Priority: Minor
             Fix For: SVN trunk


The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-1987:
---------------------------------

    Attachment: createOrderShipmentPlan.patch

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637989#action_12637989 ]

Jacques Le Roux commented on OFBIZ-1987:
----------------------------------------

Hi Nicolas,

This would work on one shipGroup only while the current implementation works on all shipGroups. But as it's obvious, what do you want to achieve here ?

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638552#action_12638552 ]

Malin Nicolas commented on OFBIZ-1987:
--------------------------------------

Salut jacques,

ça te dérange que je parle en français ? c'est super plus simple pour me
faire comprendre ;) , je mettrais un laïus sur jira après.

avant j'utilise
 OISG  OrderItemShipGroup

En faite ce que je me suis aperçu c'est que lorsque tu avais plusieurs
OISG sur un OH c'est que tu avais pour objectif de partialiser tes
expéditions et donc de n'envoyer qu'un OISG à la fois. Hors si tu appels

createOrderShipmentPlan, fonction bien utile au demerant :) tu te retrouves avec les expéditions prévu de tes OISG même si tu ne voulais opérer qu'à l'expédition d'un seul. Les autres pouvant faire lieu de séparation/fusion mais avec les planifications d'expéditions faite il devient difficile de les remodeler.

D'où l'idée d'orienter le service non pas à l'order mais à l'OISG car
c'est cette entité qui dirige l'expédition de l'order et non pas l'order
(pour moi on biaise l'objectif de l'OISG)

Après il faut peut être que je rajoute une fonction
createOrderShipmentPlanForAll qui ferait la demande pour tous les OISG
d'un order.

Est ce que ça te parait plus claire, l'objectif de ma modification ?

PS: tu as reçu mon mail de toutes les ptites évole qu'on a faite et que
tu serai intéressé que je monte les jira

Nicolas




--
Nicolas MALIN
Consultant
Tél : [phone]
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : [phone]
Site : http://www.librenberry.net/

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Malin Nicolas]

Oh, excuse me, I send french mail for jacques to explain my improvement,
and I do a bad replay on my mail reader.

I do a transalation in few time.

Nicolas

Malin Nicolas (JIRA) a écrit :

>     [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638552#action_12638552 ]
>
> Malin Nicolas commented on OFBIZ-1987:
> --------------------------------------
>
> Salut jacques,
>
> ça te dérange que je parle en français ? c'est super plus simple pour me
> faire comprendre ;) , je mettrais un laïus sur jira après.
>
> avant j'utilise
>  OISG  OrderItemShipGroup
>
> En faite ce que je me suis aperçu c'est que lorsque tu avais plusieurs
> OISG sur un OH c'est que tu avais pour objectif de partialiser tes
> expéditions et donc de n'envoyer qu'un OISG à la fois. Hors si tu appels
>
> createOrderShipmentPlan, fonction bien utile au demerant :) tu te retrouves avec les expéditions prévu de tes OISG même si tu ne voulais opérer qu'à l'expédition d'un seul. Les autres pouvant faire lieu de séparation/fusion mais avec les planifications d'expéditions faite il devient difficile de les remodeler.
>
> D'où l'idée d'orienter le service non pas à l'order mais à l'OISG car
> c'est cette entité qui dirige l'expédition de l'order et non pas l'order
> (pour moi on biaise l'objectif de l'OISG)
>
> Après il faut peut être que je rajoute une fonction
> createOrderShipmentPlanForAll qui ferait la demande pour tous les OISG
> d'un order.
>
> Est ce que ça te parait plus claire, l'objectif de ma modification ?
>
> PS: tu as reçu mon mail de toutes les ptites évole qu'on a faite et que
> tu serai intéressé que je monte les jira
>
> Nicolas
>
>
>
>
>  

--
Nicolas MALIN
Consultant
Tél : [phone]
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : [phone]
Site : http://www.librenberry.net/

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638764#action_12638764 ]

Jacques Le Roux commented on OFBIZ-1987:
----------------------------------------

Hi Nicolas,

I saw you message on dev ML so I don't insist on the fact that here we should always speak in english.

createOrderShipmentPlan is used in Oagis component, and only used in Oagis component. I think you could rename it createOrderShipmentPlanForAll  and use createOrderShipmentPlan for the service you want to create. This should not be a problem. I even suggest you to create a service interface and to create cover services to avoid duplicate simple-method body. I dd somehting like that (cover services) in Revision: 699636.

HTH

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648003#action_12648003 ]

Jacques Le Roux commented on OFBIZ-1987:
----------------------------------------

Hi Nicolas,

Did you get a chance to look at this issue ?

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Malin Nicolas]

Yes Jacques, I want works on it during the week 48. I

Nicolas

Jacques Le Roux (JIRA) a écrit :

>     [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648003#action_12648003 ]
>
> Jacques Le Roux commented on OFBIZ-1987:
> ----------------------------------------
>
> Hi Nicolas,
>
> Did you get a chance to look at this issue ?
>
>  
>> Change createOrderShipmentPlan service
>> --------------------------------------
>>
>>                 Key: OFBIZ-1987
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>>             Project: OFBiz
>>          Issue Type: Improvement
>>          Components: product
>>    Affects Versions: SVN trunk
>>            Reporter: nicolas malin
>>            Priority: Minor
>>             Fix For: SVN trunk
>>
>>         Attachments: createOrderShipmentPlan.patch
>>
>>   Original Estimate: 2h
>>  Remaining Estimate: 2h
>>
>> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.
>>    
>
>  

--
Nicolas MALIN
Consultant
Tél : [phone]
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : [phone]
Site : http://www.librenberry.net/

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin closed OFBIZ-1987.
--------------------------------

    Resolution: Fixed

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin reopened OFBIZ-1987:
----------------------------------


bad close raison

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752528#action_12752528 ]

nicolas malin commented on OFBIZ-1987:
--------------------------------------

Jacques, I close this issue because I think, I am out of date :/

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin closed OFBIZ-1987.
--------------------------------

    Resolution: Later

> Change createOrderShipmentPlan service
> --------------------------------------
>
>                 Key: OFBIZ-1987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createOrderShipmentPlan.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The service createOrderShipmentPlan works actally on order to create shipment and item. My proposal is change the service to works on OrderItemShipGroup. This entity is the relation between order process and shipment process.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.