[jira] Created: (OFBIZ-1990) new role type "MANUFACTURER"

[Nicolas Malin (Jira)]

new role type "MANUFACTURER"
----------------------------

                 Key: OFBIZ-1990
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
             Project: OFBiz
          Issue Type: Improvement
          Components: party
    Affects Versions: SVN trunk
            Reporter: Eric DE MAULDE
            Priority: Minor
             Fix For: SVN trunk


set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Environment: revision 702054

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Attachment: screenshot-1.jpg

choice of  role type in party manager

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637766#action_12637766 ]

Vikas Mayur commented on OFBIZ-1990:
------------------------------------

Eric, I think you forget to attach a patch.

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Attachment: screenshot-1.jpg

new role type "MANUFACTURER" into party manager

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Attachment:     (was: screenshot-1.jpg)

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637795#action_12637795 ]

Eric DE MAULDE commented on OFBIZ-1990:
---------------------------------------

Hello,

I'm building a patch with SVK.
Sorry to be late.

I've a mirror and a depot managed with SVK.

Eric

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Attachment: role-type_manufacturer.patch

Here is the patch to implement a new role type "MANUFACTURER" with internationalization (English and French)
But it's my first patch and I'm not sure if the patch is right !!!!

Thanks to check

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: role-type_manufacturer.patch, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637836#action_12637836 ]

Jacques Le Roux commented on OFBIZ-1990:
----------------------------------------

Hi Eric,

Not sure what you did, but this patch is nothing near what we call a patch in OFBiz.
Please read *carefully* http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702054
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: role-type_manufacturer.patch, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Environment: revision 702567  (was: revision 702054)

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702567
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: role-type_manufacturer.patch, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Attachment: role-type_manufacturer.patch

Patch for new role type "MANUFACTURER" with internationalization (English, French) at Trunk revision 702567.

Careful :
- into internationalization lines, Asian characters have a problem
- I don't know  put a right file from the ofbiz root path (have I to type manually this path ?)

My command to create this patch :
$ svk diff //mirror/vendorOfbiz/trunk/applications/party //local/customOfbiz/trunk/applications/party > role-type_manufacturer.patch

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702567
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: role-type_manufacturer.patch, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-1990:
----------------------------------

    Attachment:     (was: role-type_manufacturer.patch)

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702567
>            Reporter: Eric DE MAULDE
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: role-type_manufacturer.patch, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1990.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Eric,

Your patch is commited in revision: 702811  

Please do your patches from OFBiz root. This patch is appliable with Tortoise (Tortoise correct the patch when it's applied from OFBiz root).

It would be easier for us (when appling patches) that you do your patches with svn, Eclipse  or even Tortoise (if on Windows, Tortoise being the easier IMO)

> new role type "MANUFACTURER"
> ----------------------------
>
>                 Key: OFBIZ-1990
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1990
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: revision 702567
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: role-type_manufacturer.patch, screenshot-1.jpg
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> set a new role type "MANUFACTURER" to define a party

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.