[jira] Created: (OFBIZ-1991) Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT

[Nicolas Malin (Jira)]

Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1991
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
             Project: OFBiz
          Issue Type: Improvement
          Components: specialpurpose/pos, specialpurpose/webpos
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Assignee: Marco Risaliti
            Priority: Minor
             Fix For: SVN trunk


On PosTerminalInternTx entity add a new "paymentReasonId" field.
It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1991:
----------------------------------

    Attachment: new_paymentReasonId_on_ PosTerminalInternTx.patch

Patch for add a new field "paymentReasonId" on PosTerminalInternTx.

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637665#action_12637665 ]

Bilgin Ibryam commented on OFBIZ-1991:
--------------------------------------

Marco,

This field makes perfect sense for POS environment.
About the field name, lets add also the word EnumId to it as it is a common pattern when using Enumeration entity, something like reasonEnumId or paymentReasonEnumId.

Bilgin

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637876#action_12637876 ]

Marco Risaliti commented on OFBIZ-1991:
---------------------------------------

Hi Bilgin,

I agree with you I can rename this new field as reasonEnumId.

Thanks
Marco

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637919#action_12637919 ]

Jacques Le Roux commented on OFBIZ-1991:
----------------------------------------

I will do the changes in POS thereafter

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1991:
----------------------------------

    Attachment:     (was: new_paymentReasonId_on_ PosTerminalInternTx.patch)

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1991:
----------------------------------

    Attachment: new_paymentReasonId_on_ PosTerminalInternTx.patch

Updated patch and now the new field is called reasonEnumId.
I would like to commit it if anyone disagree on this improvement.

Marco

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-1991.
---------------------------------

    Resolution: Fixed

Fixed in rev. 703568.

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638641#action_12638641 ]

Marco Risaliti commented on OFBIZ-1991:
---------------------------------------

Hi Jacques,

Now if you want you can do the changes in POS for the same improvment.

Thanks
Marco

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638749#action_12638749 ]

Jacques Le Roux commented on OFBIZ-1991:
----------------------------------------

Hi Marco,

Done in 703659  

I just wonder if we should keep reasonComment in PosTerminalInternTx, since in POS it's redundant.
I keep it for now because I don't know how you want to use it in WebPos

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638800#action_12638800 ]

Jacques Le Roux commented on OFBIZ-1991:
----------------------------------------

Hi Marco,

I had a look at OFBIZ-237 and Ray's initial requirement. So it's clear now and I will enhance the POS accordingly. Please have a look also at my comments in OFBIZ-469.

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638858#action_12638858 ]

Marco Risaliti commented on OFBIZ-1991:
---------------------------------------

Ok, thanks Jacques I read the initial requirement from Ray and it can be implemented in the future.
Anyway I would like to leave the field reasonComment so that a user can now select a codified reason and insert a free comment/note about it.

Thanks
Marco

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638913#action_12638913 ]

Jacques Le Roux commented on OFBIZ-1991:
----------------------------------------

Marco,

In POS I will add a "Reason comment" text field to let the admin put a comment to better qualifie the reason (put more details, etc.). of crouse I will use the PosTerminalInternTx.reasonComment field to store it.

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642662#action_12642662 ]

Jacques Le Roux commented on OFBIZ-1991:
----------------------------------------

"Reason comment" text field commited in revision 707914

> Add a new "paymentReasonId" on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1991
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1991
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos, specialpurpose/webpos
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch
>
>
> On PosTerminalInternTx entity add a new "paymentReasonId" field.
> It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.