[jira] Created: (OFBIZ-2012) On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.

[Nicolas Malin (Jira)]

On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
--------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2012
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
             Project: OFBiz
          Issue Type: Bug
          Components: ecommerce
            Reporter: Rishi Solanki
            Priority: Minor


To regenerate the error :
Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.

Solution :
When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.

Finally you need some customization in the removeItem as well in cartItemQtyChanged.

Regards
--
Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2012:
-----------------------------------

    Attachment: RemoveItems.patch

Made changes in removeItem() as well in cartItemQtyChanged() functions of checkoutProcess.js

1)Remove Items according to to removeId(remove_) and qtyId(qty_).
2)When quantity is equal to zero then it removes element from cart.

Thanks to Rishi for his support.

----
Surya Kusumakar

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: RemoveItems.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jyotsna Rathore updated OFBIZ-2012:
-----------------------------------

    Attachment: UpdteQtyFix_js.patch

This patch has a little concised solution for the same.

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641752#action_12641752 ]

Sumit Pandit commented on OFBIZ-2012:
-------------------------------------

Jyotsna,

I sow your patch. Here you replaced the name of "update_${cartLineIndex}" by "update${cartLineIndex}".

And inside  JS file in querry string, you explicitly create it as follows :

+  qtyParam = "update_" + itemIndex +"="+qtyElement.value;
+  var formValues = $('cartForm').serialize() + '&' + qtyParam;

So here what message i got from here is that, you want to send only that item which need to update, ignore remaining.

If the purpose is same which i described above then our can write like :

+        var formValues =   "update_" + itemIndex +"="+qtyElement.value;

After applying your patch I have an UI issue.
when i delete some item the screen is not showing proper.
You can find it in attachment.

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-2012:
--------------------------------

    Attachment: Picture 1.png

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: Picture 1.png, RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641752#action_12641752 ]

sumitp edited comment on OFBIZ-2012 at 10/22/08 5:58 AM:
---------------------------------------------------------------

Jyotsna,

I saw your patch. Here you replaced the name of "update_${cartLineIndex}" by "update${cartLineIndex}".

And inside JS file in query string, you explicitly created it as follows :

+  qtyParam = "update_" + itemIndex +"="+qtyElement.value;
+  var formValues = $('cartForm').serialize() + '&' + qtyParam;

So here what message i got from here is that, you want to send only that item which need to update, ignore remaining.

If the purpose is same which i described above then our code can like this :

+        var formValues =   "update_" + itemIndex +"="+qtyElement.value;

After applying your patch I have an UI issue.
when i delete some item the screen is not showing proper.
You can find it in attachment.

      was (Author: sumitp):
    Jyotsna,

I sow your patch. Here you replaced the name of "update_${cartLineIndex}" by "update${cartLineIndex}".

And inside  JS file in querry string, you explicitly create it as follows :

+  qtyParam = "update_" + itemIndex +"="+qtyElement.value;
+  var formValues = $('cartForm').serialize() + '&' + qtyParam;

So here what message i got from here is that, you want to send only that item which need to update, ignore remaining.

If the purpose is same which i described above then our can write like :

+        var formValues =   "update_" + itemIndex +"="+qtyElement.value;

After applying your patch I have an UI issue.
when i delete some item the screen is not showing proper.
You can find it in attachment.
 

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: Picture 1.png, RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642065#action_12642065 ]

Jyotsna Rathore commented on OFBIZ-2012:
----------------------------------------

Yes, we could have done this is we were not sending "cartLineProductId" & "removeSelected" as hidden parameters.
If you are talking about the horizontal lines (for division between the rows) that remains even after the item is deleted, this issue is not generated by this patch it was already there in checkout page (you can check it without applying patch).

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: Picture 1.png, RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2012:
----------------------------------

    Assignee: Vikas Mayur

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: Picture 1.png, RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2012.
------------------------------

    Resolution: Fixed

Thanks Jyotsna, Surya

UpdteQtyFix_js Patch is in trunk rev. 707363

Vikas

> On change quantity to zero randomly no itemes have been deleted from cart in One Page Check out process.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: Picture 1.png, RemoveItems.patch, UpdteQtyFix_js.patch
>
>
> To regenerate the error :
> Add more than 3 product to cart then change individual qty to 0. Not in serial First delete the 2nd product and then 3rd.
> Here you will get the problem of not deleting the product from cart from the 2nd time. You may check it by refreshing the page.
> Solution :
> When you click on remove item link it will call the function removeItem of chekoutProcess.js. It will work fine for it. Now you need to one thing call the same function when you get the zero as quantity.
> Finally you need some customization in the removeItem as well in cartItemQtyChanged.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.