[jira] Created: (OFBIZ-2043) New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.

[Nicolas Malin (Jira)]

New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2043
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
             Project: OFBiz
          Issue Type: Improvement
          Components: ecommerce
            Reporter: Rishi Solanki
            Priority: Minor


To Do :
-- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
-- Do same for the NewCustomer.ftl and profile.js
-- ManageAddress.ftl and profile.js
-- In the same file "ManageAddress.ftl" on other forms as well.

Regards
--
Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2043:
-----------------------------------

    Attachment: AssociatedStateListForSelectedCountry.patch

Worked on
1)Create Profile
2)Edit Profile
3)View Profile
4)Manage Addresses.
5)Checkout Process

Handled the special case of getting associated state list  "No Sate Province exists :_NA_" in case of country with no states by hiding the state select box .Also created generic function getAssociatedStateList() for getting state list according to the selected country which is being used by all the above cases.
Thanks to Rishi Solanki .

--
Surya Kusumakar
Onima Kasliwal
Kirti Dhakad

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647202#action_12647202 ]

Sumit Pandit commented on OFBIZ-2043:
-------------------------------------

Rishi, Surya, Onima and Kirti,

With reference to the discussion held on the mailing list (The subject is : 'if_exists is deprecated'),
I this insist us to do some re factoring in the code. Not much just replace the deprecated  "if_exists" by  default value operator (!). For that following link might help you :
http://fmpp.sourceforge.net/freemarker/ref_depr_builtin.html 

Let me know what you thinks ?

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647203#action_12647203 ]

Surya Kusumakar commented on OFBIZ-2043:
----------------------------------------

Sumit,

Thank you for your suggestion we are working on it .After going through this link we have seen that exists and default is also deprecated so, we will replace all three of them.

Regards
Surya Kusumakar
Onima Kasliwal
Kirti Dhakad
 

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2043:
-----------------------------------

    Attachment: AssociatedStateListForSelectedCountry.patch

Replaced the deprecated "if_exists" ,"exists" and "default" built-ins in all the ftls .

--
Surya Kusumakar
Onima Kasliwal
Kirti Dhakad

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2043:
-----------------------------------

    Attachment: AssociatedStateListForSelectedCountry.patch

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2043:
----------------------------------

    Assignee: Vikas Mayur

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2043.
------------------------------

    Resolution: Fixed

Thanks Surya Kusumakar, Onima Kasliwal, Kirti Dhakad and others.

Patch is in trunk rev. 714238


Vikas

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647841#action_12647841 ]

Jacques Le Roux commented on OFBIZ-2043:
----------------------------------------

Thanks guys for this effort :)

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reopened OFBIZ-2043:
--------------------------------


This need a little rework as this feature sometimes does not work properly on New Profile page.

Vikas

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2043:
-----------------------------------

    Attachment: UpdatedShipToCountryInNewProfile.patch

Made changes in New Profile page .Added function copyShipToCountryToBillToCountry() in profile.js and also made  minor changes in EditShipToAddress.ftl , OnePageCheckOut.ftl , NewCustomer.ftl and geoAutoCompletor.js.

--
Regards
Surya Kusumakar

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, UpdatedShipToCountryInNewProfile.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648137#action_12648137 ]

Vikas Mayur commented on OFBIZ-2043:
------------------------------------

Thanks Surya,

Patch UpdatedShipToCountryInNewProfile is in rev. 718220

Vikas

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, UpdatedShipToCountryInNewProfile.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783054#action_12783054 ]

Rishi Solanki commented on OFBIZ-2043:
--------------------------------------

Still we need this issue open?.

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, UpdatedShipToCountryInNewProfile.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2043.
------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

> New profile pages and One page checkout should have state field should be optional if no associated states wrt country exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2043
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2043
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/ecommerce
>            Reporter: Rishi Solanki
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, AssociatedStateListForSelectedCountry.patch, UpdatedShipToCountryInNewProfile.patch
>
>
> To Do :
> -- Go to OnePageCheckout.ftl and change accordingly so that if No state list returns then hide the states select box through checkoutProcess.js.
> -- Do same for the NewCustomer.ftl and profile.js
> -- ManageAddress.ftl and profile.js
> -- In the same file "ManageAddress.ftl" on other forms as well.
> Regards
> --
> Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.