[jira] Created: (OFBIZ-2050) Replacing FTL TabBar with menu widgets in Accounting

[Nicolas Malin (Jira)]

Replacing FTL TabBar with menu widgets in Accounting
----------------------------------------------------

                 Key: OFBIZ-2050
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2050
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting, framework
            Reporter: Bruno Busco
         Attachments: accountingMenu.patch

Please find attached a patch to remove all .FTL TabBar menus from the Accounting application and have it implemented with equivalent Menu widgets.

Note:
In this patch there is the same change to the commonMenus.xml files that I have done also in the patch attached to OFBIZ-2049; when committing the second patch (I do not know which one will be committed first) please ignore the conflict.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2050:
-------------------------------

    Attachment: accountingMenu.patch

> Replacing FTL TabBar with menu widgets in Accounting
> ----------------------------------------------------
>
>                 Key: OFBIZ-2050
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2050
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, framework
>            Reporter: Bruno Busco
>         Attachments: accountingMenu.patch
>
>
> Please find attached a patch to remove all .FTL TabBar menus from the Accounting application and have it implemented with equivalent Menu widgets.
> Note:
> In this patch there is the same change to the commonMenus.xml files that I have done also in the patch attached to OFBIZ-2049; when committing the second patch (I do not know which one will be committed first) please ignore the conflict.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2050:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Replacing FTL TabBar with menu widgets in Accounting
> ----------------------------------------------------
>
>                 Key: OFBIZ-2050
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2050
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, framework
>            Reporter: Bruno Busco
>            Assignee: Ashish Vijaywargiya
>         Attachments: accountingMenu.patch
>
>
> Please find attached a patch to remove all .FTL TabBar menus from the Accounting application and have it implemented with equivalent Menu widgets.
> Note:
> In this patch there is the same change to the commonMenus.xml files that I have done also in the patch attached to OFBIZ-2049; when committing the second patch (I do not know which one will be committed first) please ignore the conflict.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648118#action_12648118 ]

Ashish Vijaywargiya commented on OFBIZ-2050:
--------------------------------------------

Bruno,

I was thinking to commit your patch.
But before I commit your patch can you please review your patch as it contains some files twice.
For eg. BillingAccountTabBar.ftl, TransactionsTabBar.ftl.

Although there is nothing wrong in applying your patch on my local machine but I would be more then happy to know the reason of double occurrence of those files in your patch.

Thanks for your contribution Bruno !!!

--
Ashish

> Replacing FTL TabBar with menu widgets in Accounting
> ----------------------------------------------------
>
>                 Key: OFBIZ-2050
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2050
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, framework
>            Reporter: Bruno Busco
>            Assignee: Ashish Vijaywargiya
>         Attachments: accountingMenu.patch
>
>
> Please find attached a patch to remove all .FTL TabBar menus from the Accounting application and have it implemented with equivalent Menu widgets.
> Note:
> In this patch there is the same change to the commonMenus.xml files that I have done also in the patch attached to OFBIZ-2049; when committing the second patch (I do not know which one will be committed first) please ignore the conflict.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648160#action_12648160 ]

Bruno Busco commented on OFBIZ-2050:
------------------------------------

Hi Ashish,
I think this happened because I deleted the file using TortoiseSVN and then deleted the parent folder also (because it was empty).
I seems a strange behaviour that TortoiseSVN has when creating a patch in such circumstances.

Could you please ignore it and commit as it is?

Thank you,
Bruno

> Replacing FTL TabBar with menu widgets in Accounting
> ----------------------------------------------------
>
>                 Key: OFBIZ-2050
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2050
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, framework
>            Reporter: Bruno Busco
>            Assignee: Ashish Vijaywargiya
>         Attachments: accountingMenu.patch
>
>
> Please find attached a patch to remove all .FTL TabBar menus from the Accounting application and have it implemented with equivalent Menu widgets.
> Note:
> In this patch there is the same change to the commonMenus.xml files that I have done also in the patch attached to OFBIZ-2049; when committing the second patch (I do not know which one will be committed first) please ignore the conflict.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2050.
--------------------------------------

    Resolution: Fixed

Hello Bruno,

Thanks for your contribution.
Your changes are in rev # 718921.

--
Ashish

> Replacing FTL TabBar with menu widgets in Accounting
> ----------------------------------------------------
>
>                 Key: OFBIZ-2050
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2050
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, framework
>            Reporter: Bruno Busco
>            Assignee: Ashish Vijaywargiya
>         Attachments: accountingMenu.patch
>
>
> Please find attached a patch to remove all .FTL TabBar menus from the Accounting application and have it implemented with equivalent Menu widgets.
> Note:
> In this patch there is the same change to the commonMenus.xml files that I have done also in the patch attached to OFBIZ-2049; when committing the second patch (I do not know which one will be committed first) please ignore the conflict.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.