OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2070) New tool to get labels information

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

125 messages Options

1234567

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660582#action_12660582 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

* I noticed also that when you choose all languages, you get the current language as 1st column with another column duplicated farther. But the 1st column is empty
* Anyway I think I will wait also for the "apache licence header comment in the xml file generated" before commiting anything.

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo8.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660620#action_12660620 ]

Marco Risaliti commented on OFBIZ-2070:
---------------------------------------

Hi Jacques,

I have uploaded a new patch for label manager and I have solved some of your requests :

1. Currently, during 1st pass when loading the Labels manager page, I'm stopping in debugger at LabelManagerFactory.java[110] to know which labels are duplicated . Not tedious for me, but impractical for most people, I guess

It was not normally happens that there are duplicated locales for the same labels and for the moment when it happens it cannot permit to save the changes to the xml file from label manager.

2. There is an issue with cache : if you clear it an reload the page (1st pass again) all lables are counted as duplicated.

Fixed in the new patch.

3. I noticed also that when you choose all languages, you get the current language as 1st column with another column duplicated farther. But the 1st column is empty

Fixed in rev. 731313.

4. Anyway I think I will wait also for the "apache licence header comment in the xml file generated" before commiting anything.

Is still need to be fixed because I was not able to put the comment at beginning of the xml file.

Probably can it be committed but it has not so completed and tested for using it definitely ?
What others thinking about it ?

Thanks
Marco

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660632#action_12660632 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

Marco,

I tried this afternoon to fix the "apache licence header comment in the xml file generated", from [here|http://www.exampledepot.com/egs/org.w3c.dom/AddNode.html] seemed pretty easy but, as you, did not succed so far.

I found another issue. When you save a file, the Labels Manager doest not strictly respect the order. You get this kind of things : a label, with other labels having the same beginning, is posted at the end of the group. For instance
<property key="AccountingAccount">
will be after
<property key="AccountingAccounts"> (the last of the group)

I'm a bit struggling, merging changes I made between LabelsInfo8.patch and LabelsInfo9.patch, at the end we will finally have good tools for translation works !

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660634#action_12660634 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

I commited a modified LabelsInfo9.patch in 731370 :

I commented out for now the lines in SaveLabelsToXmlFile.java which write the XML changes.
We have, at least, known 2 issued related to SaveLabelsToXmlFile :
* adding the ASL header
* taking care of labels sorting in the case described above

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660639#action_12660639 ]

Marco Risaliti commented on OFBIZ-2070:
---------------------------------------

Thanks a lot Jacques to commit this changed patch.
I will work on those issues as soon as I get the time.

Marco

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660678#action_12660678 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

One more comment : it would be great to color lines where at least one labels is missing. When searching for a lanquage it would be of a great help. We could even propose to return a list of missing labels for one language, etc.

Great stuff !

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Bruno Busco

Re: [jira] Commented: (OFBIZ-2070) New tool to get labels information

Great stuff !
I agree, thanks Marco.

It would be also nice to have a translation percentage.
For each language: Number of translated label / Total number of labels * 100

-Bruno

2009/1/5 Jacques Le Roux (JIRA) <[hidden email]>:

>
> [ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660678#action_12660678 ]
>
> Jacques Le Roux commented on OFBIZ-2070:
> ----------------------------------------
>
> One more comment : it would be great to color lines where at least one labels is missing. When searching for a lanquage it would be of a great help. We could even propose to return a list of missing labels for one language, etc.
>
> Great stuff !
>
>> New tool to get labels information
>> ----------------------------------
>>
>> Key: OFBIZ-2070
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
>> Project: OFBiz
>> Issue Type: New Feature
>> Components: ALL COMPONENTS
>> Affects Versions: SVN trunk
>> Reporter: Marco Risaliti
>> Priority: Minor
>> Fix For: SVN trunk
>>
>> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>>
>>
>> New tool to get labels information used in OFBiz.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660714#action_12660714 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

From Bruno Busco in dev ML
{quote}Great stuff !
I agree, thanks Marco.

It would be also nice to have a translation percentage.
For each language: Number of translated label / Total number of labels * 100
{quote}

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662726#action_12662726 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

I had another idea : it would be great to use the Ajax way to edit fields (cf. Ajax Example).
This would be particularly convenient when dealing with a sole language, which is the most common case.

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2070:
----------------------------------

Attachment: LabelsInfo10.patch

Hi Jacques,

the attached file LabelsInfo10.patch , solve the main issues you have found:

* adding the ASL header
* taking care of labels sorting in the case described above

the other improvements requested will be implemented later.

Thanks
Marco

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo10.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666561#action_12666561 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

Marco,

Sorry but you did not update. I have already commited some changes in revision 731370. I should not have some (revision 0) I see in your patch. Could you please update and create a new patch

Thanks

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo10.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666565#action_12666565 ]

Jacques Le Roux commented on OFBIZ-2070:
----------------------------------------

Oops, I did no get the right patch (I took the old one :D).
Anyway also a pb with the right one :

D:\Workspace\ofbizRun>patch -p0 0<LabelsInfo10.patch
patching file framework/base/src/org/ofbiz/base/util/FileUtil.java
patching file framework/webtools/src/org/ofbiz/webtools/labelmanager/SaveLabelsToXmlFile.java
patch: **** malformed patch at line 161:

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: LabelsInfo10.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2070:
----------------------------------

Attachment: APACHE2_HEADER_FOR_XML

Hi Jacques,

you have also to add this file on the root of OFBiz.

Thanks
Marco

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo10.patch, LabelsInfo10.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo10.patch, LabelsInfo10.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo10.patch, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo10.patch, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2070) New tool to get labels information

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666926#action_12666926 ]

Marco Risaliti commented on OFBIZ-2070:
---------------------------------------

Hi Jacques,

I have uploaded a new patch.
I have tried to do those steps:
- copy the patch into the root folder of OFBiz
- patch -p0 -iLabelsInfo11.patch
- copy the APACHE2_HEADER_FOR_XML under framework/webtools/config

Let me know if you get some more issues.

Thanks
Marco

> New tool to get labels information
> ----------------------------------
>
> Key: OFBIZ-2070
> URL: https://issues.apache.org/jira/browse/OFBIZ-2070
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch
>
>
> New tool to get labels information used in OFBiz.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

1234567