[jira] Created: (OFBIZ-2070) New tool to get labels information
Locked
1234567
1234567
[jira] Commented: (OFBIZ-2070) New tool to get labels information
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666943#action_12666943 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Hi Marco, Still the same problem. There is somehting weird in your patches (10 and 11 I mean). It comes from LabelManagerFactory.java. There seems to be duplicated blank lines in the patch. I don't know if it comes from the java file or patch creation. The 1st error appears at line 11. I was able to fix it by removing this blank line. But then I got trap with line 63 again. Then I used Scite with menu option View/End Of Line checked, and I then see (on Windows) strange LFs in green (there are also LFs in other colors that I'm used to see). I tried to remove only the line 63, but then got the same problem in line 64. So I removed (by hand, not doable with replace feature apparently) all the green LFs and was able to merge. These green LFs don't appear in FileUtil.java. Really weird... I searched an explanation Googling for "Scite green LF" an "Scite colored end of line" but find nothing clear... I already tried in previous attemps to replace LF by CRLF but it does not fix the merging issue. Please could you check your both other java files ? It would be better to find the reason, if possible, than to have to deal with that later Also I removed a tab in + labels.remove(key + keySeparator + fileName); and fixed a small bug in UpdateLabel.ftl[59] <#assign labelVal = (label.getLabelValue(localeFound))?if_exists> I attach the modified patch (without green LFs), HTH Finally your patch is in trunk at revision: 737382. It seems to work well, but I have still to check the 32 XML files I modified while only adding a l10n for key "ebay" in French, great work :D > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-2070: -------------------------------------- Assignee: Marco Risaliti > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666945#action_12666945 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Marco, Something that seems to not work anymore : when you edit a label you don't find the existing translations (for instance trying to add OrderPromotion translation in French I don't see English and Italian translations). I think we should always show all existing translations, it helps translation. Anyway I guess we will make other enhancements (I foresee, list of empty translations, etc.). Should we close this issue ? > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666964#action_12666964 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Marco, We can't still use the Label Manager wihout checking each changes because : # It removes comments in files, and I used comments to keep some alternatives available for future check/use (see ManufacturingCompanySubtitle for instance) # Still few labels not correctly sorted (MimeType.description.application/vnd.ofbiz.survey should not move for instance, but it's very minor so far...) # It removes html tags in labels without any notices (see ManufacturingNote3). I agree that there should not be html tags in labels (tough is may be discused) but we should not remove/loose them without knowing it... Even ManufacturingDuplicatedComponentInBOM do not have to be changed, [only the ampersand character (&) and the left angle bracket (<) should be changed|http://www.w3.org/TR/2006/REC-xml11-20060816/#dt-chardata]. # It destroys CommonEmptyHeader I have created the patch CleanupLabelsJLR.patch. It contains changes I checked should be OK. Could you please double-check I did not forget something ? After applying this patch (reversible), if you make a change using Labels Manager and save it, you will find a bunch of errors of (at least) the 4 types above. This should help you to fix them. Thanks > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2070: ----------------------------------- Attachment: CleanupLabelsJLR.patch CleanupLabelsJLR.patch n: not intended to be committed yet... > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666966#action_12666966 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Mmm... This sentence {quote}After applying this patch (reversible), if you make a change using Labels Manager and save it, you will find a bunch of errors of (at least) the 4 types above. This should help you to fix them.{quote} is wrong : we need to fix the Labels Manager before else it will overwrite the corrections I made manually in this patch... So please only check it's ok and I will commit it... > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666990#action_12666990 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- In CleanupLabelsJLR.patch patch # <property key="CharacterSet.description.ISO-8859-10"> should be after <property key="CharacterSet.description.ISO-8859-1"> (same than point 1 above) Ho, I gave up, I will do it file by file... > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: ---------------------------------- Attachment: LabelsInfo12.patch Hi Jacques, first of all thank you for all your work you have done with my patches. Can be possible that when I moved the patches from XP to Mac it cause those problems ? I'm now checking all your bugs you have seen and most of them I had already seen some days ago but I still not having the time to fix it. For the moment with this patch it can be possible to fix the problem about editing labels that doesn't show the translations. I have seen also that the label CommonEmptyHeader will be deleted because all the rows is empty. In this case probably I have to leave like it and use a specific button to remove completely a label. I will work on the others issue step by step and provide some patches. Thanks a lot Marco > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo12.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: ---------------------------------- Attachment: LabelsInfo13.patch With the following patch it can be also be possible to remove a label from Label Manager. Thanks Marco > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: ---------------------------------- Attachment: (was: LabelsInfo12.patch) > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667058#action_12667058 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Hi Marco, * Yes certainly an issue migrating from Windows to PC. We will see later if other issues arise... * CommonEmptyHeader labels is not totally empty, there are at least a space in them LabelsInfo13.patch is in trunk revision: 737491 Thanks > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667172#action_12667172 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- CleanupLabelsJLR.patch has been committed (amended) > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: ---------------------------------- Attachment: LabelsInfo14.patch Hi Jacques, Label manager now supports also comments at property and value level in the UiLabel xml files. In the attached patch you can find also replace of \r\n to \n. Thanks Marco > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669282#action_12669282 ] Marco Risaliti commented on OFBIZ-2070: --------------------------------------- I have seen that some comments are after the property or value tag instead they must be before. I will commit some changes to support comments correctly. > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: ---------------------------------- Attachment: LabelsInfo15.patch Hi Jacques, LabelsInfo15.patch contains some comments for property and value tag to be moved before those tags. Thanks Marco > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo15.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669361#action_12669361 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Hi Marco, Same problem for some files in LabelsInfo14.patch. Could you try to make all EOL the same using Eclipse before patching ? # Select the project root # Use menu File/Convert Line Delimiters To > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo15.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: ---------------------------------- Attachment: LabelsInfo14.patch Hi Jacques, I have done convert line delimiter to MacOS 9 and this is the updated patch. Thanks Marco > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo14.patch, LabelsInfo15.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669465#action_12669465 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Hi Marco, Same problem. Some blank lines (with only LF) are in some files. Look at UpdateLabel.ftl in patch for instance. You could try http://www.cyberciti.biz/faq/howto-linux-unix-command-remove-all-blank-lines/ but be sure top remove only real blank lines and not the ones with a space in. And even doing that I'm not sure it will resolve this issue because maybe some blank lines are needed in the patch... I can dot it by hand with Scite, but it would be very tedious, especially if I have to do it for every patches ;) > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo14.patch, LabelsInfo15.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669472#action_12669472 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Finally I was able to do it. On Windows I used [this tool|http://my-i-p.com/Remove_Empty_Lines_from_Text.html] and then with Winmerge I replaced the lines needed (not real empty lines). There is still this weird sorting : something empty is placed after the same line but not empty. IMO it should not (but it's minor I agree ;o), like <property key="CharacterSet.description.ISO-8859-10"> <value xml:lang="de">ISO-8859-10</value> <value xml:lang="en">ISO-8859-10</value> <value xml:lang="es">ISO-8859-10 ?</value> <value xml:lang="fr">ISO-8859-10</value> <value xml:lang="it">ISO-8859-10</value> <value xml:lang="th">ISO-8859-10</value> </property> <property key="CharacterSet.description.ISO-8859-1"> <value xml:lang="de">ISO-8859-1</value> <value xml:lang="en">ISO-8859-1</value> <value xml:lang="es">ISO-8859-1 Inglés</value> <value xml:lang="fr">ISO-8859-1</value> <value xml:lang="it">ISO-8859-1</value> <value xml:lang="th">ISO-8859-1</value> </property> IMO <property key="CharacterSet.description.ISO-8859-1"> should be before <property key="CharacterSet.description.ISO-8859-10"> > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo14.patch, LabelsInfo15.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2070) New tool to get labels information
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669538#action_12669538 ] Jacques Le Roux commented on OFBIZ-2070: ---------------------------------------- Hi Marco, One more point : the Label Manager should write file using the OS EOL type (ie CRLF for Windows for instance). Because else you get tons of false changes (only EOLs changed) Also there are still issues with comments Working base {code} <!--value xml:lang="ro">Parte accesibila pentru Business Family of Open Source Software</value--> <!--value xml:lang="ro">Parte din Open for Business Family of Open Source Software</value--> <value xml:lang="ro">Partea de Deschidere Pentru Afaceri Familiale din Open Source Software</value> <!--value xml:lang="ru">Часть семейства ПО Open For Business</value--> <!--value xml:lang="ru">Часть семейства "Open For Business Family" программных продуктов Open Source </value--> <value xml:lang="ru">Входит в состав семейства Open For Business</value> <!--value xml:lang="th">เป็นส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value--> <value xml:lang="th">ส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value> <!--value xml:lang="zh">开源软件OFBiz的组成部分</value--> <!--value xml:lang="zh">开源软件OFBiz的组成部分</value--> {code} Worling copy (after saving files in Label Manager) {code} <!--value xml:lang="ro">Parte accesibila pentru Business Family of Open Source Software</valuevalue xml:lang="ro">Parte din Open for Business Family of Open Source Software</value--> <value xml:lang="ro">Partea de Deschidere Pentru Afaceri Familiale din Open Source Software</value> <!--value xml:lang="ru">Часть семейства ПО Open For Business</valuevalue xml:lang="ru">Часть семейства "Open For Business Family" программных продуктов Open Source </value--> <value xml:lang="ru">Входит в состав семейства Open For Business</value> <!--value xml:lang="th">เป็นส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value--> <value xml:lang="th">ส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value> <!--value xml:lang="zh">开源软件OFBiz的组成部分</valuevalue xml:lang="zh">开源软件OFBiz的组成部分</value--> {code} Anyway, I will already commit this to facilitate your work and mine ;) > New tool to get labels information > ---------------------------------- > > Key: OFBIZ-2070 > URL: https://issues.apache.org/jira/browse/OFBIZ-2070 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: APACHE2_HEADER_FOR_XML, CleanupLabelsJLR.patch, LabelsInfo11.patch, LabelsInfo13.patch, LabelsInfo14.patch, LabelsInfo14.patch, LabelsInfo15.patch, LabelsInfo5.png, LabelsInfo9.patch > > > New tool to get labels information used in OFBiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |