[jira] Created: (OFBIZ-2076) Duplicated labels on framework components

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2076) Duplicated labels on framework components

Nicolas Malin (Jira)
Duplicated labels on framework components
-----------------------------------------

                 Key: OFBIZ-2076
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2076
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Priority: Trivial
             Fix For: SVN trunk


There are some labels into some labels xml file into framework components that are wrong or duplicated.
Can some framework committer review the attached patch and then if everything is ok commit it ?

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2076) Duplicated labels on framework components

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2076:
----------------------------------

    Attachment: Duplicated_labels_on_framework_components.patch

> Duplicated labels on framework components
> -----------------------------------------
>
>                 Key: OFBIZ-2076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Duplicated_labels_on_framework_components.patch
>
>
> There are some labels into some labels xml file into framework components that are wrong or duplicated.
> Can some framework committer review the attached patch and then if everything is ok commit it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2076) Duplicated labels on framework components

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655997#action_12655997 ]

Jacques Le Roux commented on OFBIZ-2076:
----------------------------------------

Hi Marco,

Your patch seems outdated. Are you sure you updated ?

> Duplicated labels on framework components
> -----------------------------------------
>
>                 Key: OFBIZ-2076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Duplicated_labels_on_framework_components.patch
>
>
> There are some labels into some labels xml file into framework components that are wrong or duplicated.
> Can some framework committer review the attached patch and then if everything is ok commit it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2076) Duplicated labels on framework components

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2076:
----------------------------------

    Attachment: Duplicated_labels_on_framework_components2.patch

An updated patch that replace the previous one.

Thanks
Marco

> Duplicated labels on framework components
> -----------------------------------------
>
>                 Key: OFBIZ-2076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Duplicated_labels_on_framework_components.patch, Duplicated_labels_on_framework_components2.patch
>
>
> There are some labels into some labels xml file into framework components that are wrong or duplicated.
> Can some framework committer review the attached patch and then if everything is ok commit it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2076) Duplicated labels on framework components

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2076:
----------------------------------

    Attachment:     (was: Duplicated_labels_on_framework_components.patch)

> Duplicated labels on framework components
> -----------------------------------------
>
>                 Key: OFBIZ-2076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Duplicated_labels_on_framework_components2.patch
>
>
> There are some labels into some labels xml file into framework components that are wrong or duplicated.
> Can some framework committer review the attached patch and then if everything is ok commit it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2076) Duplicated labels on framework components

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2076.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Marco,

I was not able to apply your patch (still outdated) but it was easy to do it by hand, revision: 728408  


> Duplicated labels on framework components
> -----------------------------------------
>
>                 Key: OFBIZ-2076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Duplicated_labels_on_framework_components2.patch
>
>
> There are some labels into some labels xml file into framework components that are wrong or duplicated.
> Can some framework committer review the attached patch and then if everything is ok commit it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.