[jira] Created: (OFBIZ-2079) ShoppingCartServices.loadCartFromOrder

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2079) ShoppingCartServices.loadCartFromOrder

Nicolas Malin (Jira)
ShoppingCartServices.loadCartFromOrder
--------------------------------------

                 Key: OFBIZ-2079
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2079
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
         Environment: Windows XP, eclipse
            Reporter: Stephen Rufle
             Fix For: SVN trunk


When the ShoppingCart is created I wanted the OrderDate, OrderId and OrderName to be populated in the cart. There were set methods that did not seem to be used so I wrote this patch to fill the information.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2079) ShoppingCartServices.loadCartFromOrder

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-2079:
---------------------------------

    Attachment: ShoppingCartServices.patch

Adds three setOrderXXX lines

> ShoppingCartServices.loadCartFromOrder
> --------------------------------------
>
>                 Key: OFBIZ-2079
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2079
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, eclipse
>            Reporter: Stephen Rufle
>             Fix For: SVN trunk
>
>         Attachments: ShoppingCartServices.patch
>
>
> When the ShoppingCart is created I wanted the OrderDate, OrderId and OrderName to be populated in the cart. There were set methods that did not seem to be used so I wrote this patch to fill the information.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2079) ShoppingCartServices.loadCartFromOrder

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2079.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Stephen,

Your patch is in trunk revision: 727075

> ShoppingCartServices.loadCartFromOrder
> --------------------------------------
>
>                 Key: OFBIZ-2079
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2079
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP, eclipse
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: ShoppingCartServices.patch
>
>
> When the ShoppingCart is created I wanted the OrderDate, OrderId and OrderName to be populated in the cart. There were set methods that did not seem to be used so I wrote this patch to fill the information.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (OFBIZ-2079) ShoppingCartServices.loadCartFromOrder

Stephen Rufle-2
I have two more patches to the same file. Should I create two new issues
or just one with two patches attached?

The patches will be retrieving OrderAttributes and OrderItemAttributes.
I will also have to re do my braces.

As to the code formatting is there an eclipse formatter file that I
should be using?


Jacques Le Roux (JIRA) wrote:

>      [ https://issues.apache.org/jira/browse/OFBIZ-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jacques Le Roux closed OFBIZ-2079.
> ----------------------------------
>
>     Resolution: Fixed
>       Assignee: Jacques Le Roux
>
> Thanks Stephen,
>
> Your patch is in trunk revision: 727075
>
>  
>> ShoppingCartServices.loadCartFromOrder
>> --------------------------------------
>>
>>                 Key: OFBIZ-2079
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2079
>>             Project: OFBiz
>>          Issue Type: Improvement
>>          Components: order
>>    Affects Versions: SVN trunk
>>         Environment: Windows XP, eclipse
>>            Reporter: Stephen Rufle
>>            Assignee: Jacques Le Roux
>>             Fix For: SVN trunk
>>
>>         Attachments: ShoppingCartServices.patch
>>
>>
>> When the ShoppingCart is created I wanted the OrderDate, OrderId and OrderName to be populated in the cart. There were set methods that did not seem to be used so I wrote this patch to fill the information.
>>    
>
>  

--
Stephen P Rufle
[hidden email]
H1:480-626-8022
H2:480-802-7173
Yahoo IM: stephen_rufle
AOL IM: stephen1rufle

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (OFBIZ-2079) ShoppingCartServices.loadCartFromOrder

Jacques Le Roux
Administrator
You can go for one issue if they are small changes as the ones I just commited

Jacques

From: "Stephen Rufle" <[hidden email]>

>I have two more patches to the same file. Should I create two new issues
> or just one with two patches attached?
>
> The patches will be retrieving OrderAttributes and OrderItemAttributes.
> I will also have to re do my braces.
>
> As to the code formatting is there an eclipse formatter file that I
> should be using?
>
>
> Jacques Le Roux (JIRA) wrote:
>>      [ https://issues.apache.org/jira/browse/OFBIZ-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Jacques Le Roux closed OFBIZ-2079.
>> ----------------------------------
>>
>>     Resolution: Fixed
>>       Assignee: Jacques Le Roux
>>
>> Thanks Stephen,
>>
>> Your patch is in trunk revision: 727075
>>
>>
>>> ShoppingCartServices.loadCartFromOrder
>>> --------------------------------------
>>>
>>>                 Key: OFBIZ-2079
>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2079
>>>             Project: OFBiz
>>>          Issue Type: Improvement
>>>          Components: order
>>>    Affects Versions: SVN trunk
>>>         Environment: Windows XP, eclipse
>>>            Reporter: Stephen Rufle
>>>            Assignee: Jacques Le Roux
>>>             Fix For: SVN trunk
>>>
>>>         Attachments: ShoppingCartServices.patch
>>>
>>>
>>> When the ShoppingCart is created I wanted the OrderDate, OrderId and OrderName to be populated in the cart. There were set
>>> methods that did not seem to be used so I wrote this patch to fill the information.
>>>
>>
>>
>
> --
> Stephen P Rufle
> [hidden email]
> H1:480-626-8022
> H2:480-802-7173
> Yahoo IM: stephen_rufle
> AOL IM: stephen1rufle
>