OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2106) Visual Themes for Ecommerce

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

50 messages Options

123

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2106) Visual Themes for Ecommerce

Visual Themes for Ecommerce
---------------------------

Key: OFBIZ-2106
URL: https://issues.apache.org/jira/browse/OFBIZ-2106
Project: OFBiz
Issue Type: New Feature
Components: ecommerce
Affects Versions: SVN trunk
Reporter: Bruno Busco
Attachments: EcommerceVisualTheme.patch

Hi,
in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.

One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: EcommerceVisualTheme.patch
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659365#action_12659365 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

In the next day I will hopefully submit an example alternative theme. But I would be happy if someone beats me! ;.)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659486#action_12659486 ]

Jacques Le Roux commented on OFBIZ-2106:
----------------------------------------

Hi Bruno,

This seems to introduce a lot of problems, did you test it ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Bruno Busco

Re: [jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Well...I am actually using it while designing a new them.
What kind of problems?

-Bruno

2008/12/29 Jacques Le Roux (JIRA) <[hidden email]>:

>
> [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659486#action_12659486 ]
>
> Jacques Le Roux commented on OFBIZ-2106:
> ----------------------------------------
>
> Hi Bruno,
>
> This seems to introduce a lot of problems, did you test it ?
>
>> Visual Themes for Ecommerce
>> ---------------------------
>>
>> Key: OFBIZ-2106
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>> Project: OFBiz
>> Issue Type: New Feature
>> Components: ecommerce
>> Affects Versions: SVN trunk
>> Reporter: Bruno Busco
>> Attachments: EcommerceVisualTheme.patch
>>
>>
>> Hi,
>> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
>> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
>> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
>> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
>> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
>> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659489#action_12659489 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Yes, Jacques I tested it and I am using right now.
Did you ant run-install ?

In the patch there is a new seed data that needs to be installed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659523#action_12659523 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

In any case it is better to use this issue as a working area for this
feature. (i.e. please do not commit yet)
I would like to add at least one theme to show how it works.

BTW, using it, I am seeing some other changes to do that I would like
to check with you:

The first one is:
Having a VisualTheme specified to be used for a ProductStore (with a
default one) we should not need any more several fields such as
("styleSheet", "headerLogo", "headerMiddleBackground",
"headerRightBackground") since everything is setup in the theme.

WDYT?

-
I am testing the patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659527#action_12659527 ]

Jacques Le Roux commented on OFBIZ-2106:
----------------------------------------

Bruno,

OK, it's because I did not follow the steps in issue description but used the Visual Theme option at right top. Try it ;)

I agree about removing multiple redundant fields a "facade" is better :)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659529#action_12659529 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Oh I see, doing this you used the ecommerce theme for the backoffice.
This is why I propose a flag in the VisualTheme to distinguish between
themes to be used by different applications.
In this way only the suitable thames will be listed.
Any suggestion on how this field could be named?

-Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2106:
-------------------------------

Attachment: vt_multiflex.zip
BrowseCategoryCSS.patch
EcommerceVisualTheme.patch

Hi devs,
I have completed my work on the VisualTheme for ecommerce and I have attached to this issues two patches ready for reviewing and eventually commiting.
In addition you can find an example of an alternative theme that can be installed and used for the ecommerce once the two patches are applied.

Here a detailed description of the patches:
1) EcommerceVisualTheme.patch
This patch has been already described before. In this version I added a visualThemeTypeId field to the VisualTheme entity that is now used to filter for the visual theme for the ecommerce and for the backoffice.

2) BrowseCategoryCSS.patch
This is a CSS cleanup patch that removes many style attribute in the browse category.
Basically this tag <div style='margin-left: 10px;'> is replaced by <div class="browsecategorylist">
and the new browsecategorylist rule has been added to both maincss.css and ecomcss.css
Another change is the replacement of the "- " in the html with a CSS that allows to replace the "-" with anything else in the theme.
This change allows the themes to have more control on the presentation.
Many occurrence of "tabletext" have been eliminated and replaced with a <p> tag. The tabletext elimination has been indicated in the UI refactor guideline on Confluence.

3) vt_multiflex.zip is an example theme that can be used for the ecommerce. It is intended for a demo and I did not developed it interely. But it is a good example. A screenshot is also attached to this issue.

4) An additional file "bin.zip" is attached to this patch in order to add a screenshot for the default ecommerce theme

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659887#action_12659887 ]

Adrian Crum commented on OFBIZ-2106:
------------------------------------

I don't like the idea of separate themes for eCommerce and the rest of the applications. Why should there be a distinction?

The eCommerce markup and stylesheet needs to be updated to be more like the back office applications - then we can share stylesheets and themes between them. There was a previous Jira issue about this - https://issues.apache.org/jira/browse/OFBIZ-1119

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659891#action_12659891 ]

Jacques Le Roux commented on OFBIZ-2106:
----------------------------------------

I agree that we should has much as possible keep the 2 themes types as closer as possible. But I'm not as point-blank as Adrian, if there are good reasons to "split them". I can't see any for now, but I guess that an e-commerce theme, even a demo theme, could need more sophistication than a backend theme...

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659894#action_12659894 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Adrian,
in principle I agree with you but. The theme separation is the last thing I did before submitting. This is to avoid that the user can select a ecommerce theme for the backoffice loosing completely the UI control.
We have to consider that a VT is not only a stylesheet but also i.e. header and footer. These can be completely different (in content and not in style only) beetween backoffice and ecommerce.

-Bruno

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659910#action_12659910 ]

Adrian Crum commented on OFBIZ-2106:
------------------------------------

Bruno,

I'm trying to be realistic. Look at OFBIZ-1119 - it is 18 months old and no progress has been made on it. That issue represents only one stylesheet. What you're suggesting is that we have multiple versions of stylesheets and other files for each theme - multiplied by the number of themes in the project (if we agree to have more than one) which yields potentially dozens of theme files that need to be maintained. Yet currently we can't keep only one updated.

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Bruno Busco

Re: [jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Adrian,
I cannot see the problem.

Right now we have and maintain two themes, one for ecommerce and one
for backoffice. Each theme is composed by an header, a footer, several
stylesheets and other related files.

These files are distributed into ofbiz folders and now, with the
introduction of VisualThemes, each set of file has been grouped and
labeled with a VisualTheme.

I think that we will never add more themes into the SVN (my
vt_multiflex.zip file is absolutely not intended to be commited).
So we should always take care, into the SVN, of only two themes as is
has been unitl now (no one more file).

In the theme gallery in Confluence there will be hopefully more themes
available to be downloaded and installed locally. The Theme manager
into OFBiz will let the user to have many of them to choose from.

In this case the new visualThemeTypeId field could be handy in a way
that only applicable themes out of what has been installed are offered
to the user to choose from.

If OFBIZ-1119 will go further and we will have both ecommerce and
backoffice to share the same stylesheets AND header AND footer (which
I really do not think be possible) we could then do not use the
visualTheme classification and use just one class.

-Bruno

2008/12/30 Adrian Crum (JIRA) <[hidden email]>:

>
> [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659910#action_12659910 ]
>
> Adrian Crum commented on OFBIZ-2106:
> ------------------------------------
>
> Bruno,
>
> I'm trying to be realistic. Look at OFBIZ-1119 - it is 18 months old and no progress has been made on it. That issue represents only one stylesheet. What you're suggesting is that we have multiple versions of stylesheets and other files for each theme - multiplied by the number of themes in the project (if we agree to have more than one) which yields potentially dozens of theme files that need to be maintained. Yet currently we can't keep only one updated.
>
>
>> Visual Themes for Ecommerce
>> ---------------------------
>>
>> Key: OFBIZ-2106
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>> Project: OFBiz
>> Issue Type: New Feature
>> Components: ecommerce
>> Affects Versions: SVN trunk
>> Reporter: Bruno Busco
>> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>>
>>
>> Hi,
>> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
>> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
>> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
>> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
>> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
>> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659944#action_12659944 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Adrian,
I cannot see the problem.

Right now we have and maintain two themes, one for ecommerce and one
for backoffice. Each theme is composed by an header, a footer, several
stylesheets and other related files.

These files are distributed into ofbiz folders and now, with the
introduction of VisualThemes, each set of file has been grouped and
labeled with a VisualTheme.

I think that we will never add more themes into the SVN (my
vt_multiflex.zip file is absolutely not intended to be commited).
So we should always take care, into the SVN, of only two themes as is
has been unitl now (no one more file).

In the theme gallery in Confluence there will be hopefully more themes
available to be downloaded and installed locally. The Theme manager
into OFBiz will let the user to have many of them to choose from.

In this case the new visualThemeTypeId field could be handy in a way
that only applicable themes out of what has been installed are offered
to the user to choose from.

If OFBIZ-1119 will go further and we will have both ecommerce and
backoffice to share the same stylesheets AND header AND footer (which
I really do not think be possible) we could then do not use the
visualTheme classification and use just one class.

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2106:
-------------------------------

Attachment: EcommerceVisualTheme.patch
vt_multiflex.zip

I discovered a problem in two of the files submitted.
Please consider this new version.

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

In reply to this post by Nicolas Malin (Jira)

> Visual Themes for Ecommerce
> ---------------------------
>
> Key: OFBIZ-2106
> URL: https://issues.apache.org/jira/browse/OFBIZ-2106
> Project: OFBiz
> Issue Type: New Feature
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123