[jira] Created: (OFBIZ-2106) Visual Themes for Ecommerce

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
50 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667055#action_12667055 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Hi Jacques,
I think that BrowseCategoryCSS.patch can be committed (if it still valid on current trunk). it is mainly a clean-up patch becouse remove styles from the FTL files that should not be used. I cannot commit it because it touches maincss and ecommain.css in the framework.

For the rest of the issue we need to implement the VisualThemeSet as specified by David in the ML. It is on my list.
When the VisualThemeSet will be done I think that the attached theme can be committed to the themes folder so that we have an alternative for the ecommerce too OOTB.

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667060#action_12667060 ]

Jacques Le Roux commented on OFBIZ-2106:
----------------------------------------

Hi Bruno,

Could you please re-create the BrowseCategoryCSS.patch, I got a merging issue with ecommain.css

Thanks

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2106:
-------------------------------

    Attachment: BrowseCategoryCSS.patch

Jacques,
please find an updated patch.
In any case the patch I got seems to change lot of ecommain.css but it is not.
The only change needed to the ecommain.css is:

===================================================================
--- framework/images/webapp/images/ecommain.css (revision 737492)
+++ framework/images/webapp/images/ecommain.css (working copy)
@@ -498,10 +498,15 @@
 color: red;
 }
 
+.browsecategorylist {
+margin-left: 10px;
+}
+
 .browsecategorytext {
 font-weight: bold;
 color: #000099;
-text-indent: -10px;
+padding-left: 10px;
+background:url(/images/bg_bullet_full_2.gif) no-repeat 0px 0.5em;
 }
 
 A.browsecategorybutton {


Moreover I forgot to mention you should also add the bin.zip binary files

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667075#action_12667075 ]

Jacques Le Roux commented on OFBIZ-2106:
----------------------------------------

Bruno,

Your patch (+ 2 images) is in trunk revision: 737506  


> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667086#action_12667086 ]

Jacques Le Roux commented on OFBIZ-2106:
----------------------------------------

Bruno, there is a side effect in backend : the bullet image is missing for categories and products in left bar (in Catalog and Order Creation at least). Could you please have a look at it ?

Thanks

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667086#action_12667086 ]

jacques.le.roux edited comment on OFBIZ-2106 at 1/25/09 5:59 AM:
-----------------------------------------------------------------

Bruno, there is a side effect in backend : the bullet image is missing for categories and products in left bar (in Catalog and Order Creation at least). Could you please have a look at it ?

Thanks
PS : only in the light-blue theme...

      was (Author: jacques.le.roux):
    Bruno, there is a side effect in backend : the bullet image is missing for categories and products in left bar (in Catalog and Order Creation at least). Could you please have a look at it ?

Thanks
 

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667156#action_12667156 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Fixed in rev. 737618

Thank you for reporting Jacques.

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reassigned OFBIZ-2106:
----------------------------------

    Assignee: Bruno Busco

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670912#action_12670912 ]

Bruno Busco commented on OFBIZ-2106:
------------------------------------

I preferred to open a new issue for the VisualThemeSets.
https://issues.apache.org/jira/browse/OFBIZ-2172
-Bruno



> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2106) Visual Themes for Ecommerce

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-2106.
------------------------------

    Resolution: Fixed

Implemented in trunk rev. 746544 and 746545

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: bin.zip, bin.zip, BrowseCategoryCSS.patch, BrowseCategoryCSS.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, screenshot_1.jpg, vt_multiflex.zip, vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) is to add a "typeId" field or similar to the VisualTheme entity that could be used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost application and this results in a mess if, for example, a theme for ecommerce is selected for the back-end and viceversa.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123