[jira] Created: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
Add description field to complete work on Pricing Breakdown
-----------------------------------------------------------

                 Key: OFBIZ-211
                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Tim Ruppert
         Attachments: productPriceRuleDescription.patch

This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .

It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.

Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-211?page=all ]

Tim Ruppert updated OFBIZ-211:
------------------------------

    Attachment: productPriceRuleDescriptionWithAdmin.patch

Sorry - disregard the first patch as this one incorporates it and adds all the necessary logic for the admin screens.  Will someone check my copy/paste for the ProductUiLabels in french, spanish and italian?  Thanks.

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescription.patch, productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-211?page=all ]

Tim Ruppert updated OFBIZ-211:
------------------------------

    Attachment: productPriceRuleDescriptionWithAdmin.patch

Updated for backward compatibility - my bad.  Whoever checks this out - just needs to apply the last patch - the other two are now incorporated.

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescription.patch, productPriceRuleDescriptionWithAdmin.patch, productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-211?page=all ]

Jacopo Cappellato updated OFBIZ-211:
------------------------------------

    Attachment:     (was: productPriceRuleDescription.patch)

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescriptionWithAdmin.patch, productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-211?page=all ]

Jacopo Cappellato updated OFBIZ-211:
------------------------------------

    Attachment:     (was: productPriceRuleDescriptionWithAdmin.patch)

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-211?page=comments#action_12433317 ]
           
Jacopo Cappellato commented on OFBIZ-211:
-----------------------------------------

Ok, I've removed the first two patches as requested by Tim.

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-211?page=comments#action_12433339 ]
           
Jacques Le Roux commented on OFBIZ-211:
---------------------------------------

Tim,

It's OK for me. I prefer to let David commit it if it's OK for him as he has already commited OFBIZ-160

Thanks

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-211?page=comments#action_12433421 ]
           
Tim Ruppert commented on OFBIZ-211:
-----------------------------------

David, when you get a chance - could you complete OFBIZ-160 by applying these patches?  Thanks.

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-211?page=comments#action_12433425 ]
           
Chris Howe commented on OFBIZ-211:
----------------------------------

I know the committers will disagree on the importance of this, but as far as design, this should really be considered an alias that allows a one (ProductPriceRule) to many (ProductPriceRuleAlias or something along those lines) relationship.

> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Attachments: productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-211) Add description field to complete work on Pricing Breakdown

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-211?page=all ]

David E. Jones closed OFBIZ-211.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: David E. Jones

Thanks Tim, this is now in SVN, rev 441701.

There was one file that failed, I guess a conflicting line or such: ProductUiLabels_es.properties


> Add description field to complete work on Pricing Breakdown
> -----------------------------------------------------------
>
>                 Key: OFBIZ-211
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-211
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Tim Ruppert
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: productPriceRuleDescriptionWithAdmin.patch
>
>
> This patch would complete the development of https://issues.apache.org/jira/browse/OFBIZ-160 .
> It adds a description field to the ProductPriceRule entity in order to allow administrators to give names they will remember in the backend to their pricing rules - without having to have such a long name print out if they want to display these values on the category or product detail pages.
> Will one of the ocmmitters take a quick peek at this? Thanks in advance.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira