[jira] Created: (OFBIZ-2110) Add initialAccount field to SalesOpportunity entity

[Nicolas Malin (Jira)]

Add initialAccount field to SalesOpportunity entity
---------------------------------------------------

                 Key: OFBIZ-2110
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Vince Clark
            Priority: Minor


There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666994#action_12666994 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

Not sure also why there are 2 "opportunityName"s and "initialAccount"s, I guess we should remove duplicate.
I will do and add the initialAccount field in SalesOpportunity if nobody sees another explanation.

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Priority: Minor
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667028#action_12667028 ]

Vince Clark commented on OFBIZ-2110:
------------------------------------

"initialAccount" is just the name used in the form. Not sure why it is called "initialAccount." I think "account" would be OK. Sales Opportunities just need to be linked to accounts.

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Priority: Minor
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Pierre Smits]

Not only that, but they should also be linkt to an employee in the role of
'account manager'.

2009/1/25 Vince Clark (JIRA) <[hidden email]>

>
>    [
> https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667028#action_12667028]
>
> Vince Clark commented on OFBIZ-2110:
> ------------------------------------
>
> "initialAccount" is just the name used in the form. Not sure why it is
> called "initialAccount." I think "account" would be OK. Sales Opportunities
> just need to be linked to accounts.
>
> > Add initialAccount field to SalesOpportunity entity
> > ---------------------------------------------------
> >
> >                 Key: OFBIZ-2110
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
> >             Project: OFBiz
> >          Issue Type: Bug
> >          Components: order
> >    Affects Versions: SVN trunk
> >            Reporter: Vince Clark
> >            Priority: Minor
> >
> > There is a field in the SalesOpportunity form to link to a Party but no
> field in the entity to store it in.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667249#action_12667249 ]

Vince Clark commented on OFBIZ-2110:
------------------------------------

Yes I agree. Currently a lead is automatically assigned to the user that is logged in and there is no way to reassign it to someone else.

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Priority: Minor
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Jacques Le Roux]

Please Pierre it's better to comment inside the Jira issue to keep history at hand.
I did it for you at    https://issues.apache.org/jira/browse/OFBIZ-2110?focusedCommentId=12667261#action_12667261

Thanks

Jacques

From: "Pierre Smits" <[hidden email]>

> Not only that, but they should also be linkt to an employee in the role of
> 'account manager'.
>
> 2009/1/25 Vince Clark (JIRA) <[hidden email]>
>
>>
>>    [
>> https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667028#action_12667028]
>>
>> Vince Clark commented on OFBIZ-2110:
>> ------------------------------------
>>
>> "initialAccount" is just the name used in the form. Not sure why it is
>> called "initialAccount." I think "account" would be OK. Sales Opportunities
>> just need to be linked to accounts.
>>
>> > Add initialAccount field to SalesOpportunity entity
>> > ---------------------------------------------------
>> >
>> >                 Key: OFBIZ-2110
>> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>> >             Project: OFBiz
>> >          Issue Type: Bug
>> >          Components: order
>> >    Affects Versions: SVN trunk
>> >            Reporter: Vince Clark
>> >            Priority: Minor
>> >
>> > There is a field in the SalesOpportunity form to link to a Party but no
>> field in the entity to store it in.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2110:
--------------------------------------

    Assignee: Jacques Le Roux

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667261#action_12667261 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

Vince's comment above was a reply to this Pierre Smits's comment on dev ML
{quote}Not only that, but they should also be linkt to an employee in the role of 'account manager'.{quote}

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Priority: Minor
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673927#action_12673927 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

Vince, Pierre,

Have you a patch for that ?

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vince Clark updated OFBIZ-2110:
-------------------------------

    Attachment: SalesOpportunityEntity.patch

All this patch does is add an "InitialAccount" field to the SalesOpportunity entity. I did not add any referential integrity so the only way it is being enforced as a partyId is the form. Not sure if this is the normal way to do things when referencing partyId's.

Also, as I commented in this issue, I don't know why it is called "InitialAccount" in the form. I inherited this name when I added it to the entity. But I think it should just be "Account". I don't see a reason to differentiate as "InitialAccount." If you go this route you will also need to change all references in applications/marketing/widget/sfa/forms/OpportunityForms.xml.

For clarity you should also change uiLabelMap.SfaInitialAccount.

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677794#action_12677794 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

Pierre,

You suggested " a link to an employee in the role of 'account manager". Have you a patch for that and/or a more complete patch in general ?

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719375#action_12719375 ]

Anil K Patel commented on OFBIZ-2110:
-------------------------------------

Vince, Pierre,
Early this month I worked on adding account and lead relation to Opportunity in SFA but did not know about this Jira issue. If you get chance please take a look at the recent enhancements and give your feedback.

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750278#action_12750278 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

If nobody cares I will close this issue...

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750289#action_12750289 ]

Scott Gray commented on OFBIZ-2110:
-----------------------------------

Why?

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750293#action_12750293 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

To speed up things, seems to work :)

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Scott Gray-2]

So long as we're in agreement that outstanding issues shouldn't be  
closed solely due to a lack of activity.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 2/09/2009, at 6:32 PM, Jacques Le Roux (JIRA) wrote:

>
>    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750293 
> #action_12750293 ]
>
> Jacques Le Roux commented on OFBIZ-2110:
> ----------------------------------------
>
> To speed up things, seems to work :)
>
>> Add initialAccount field to SalesOpportunity entity
>> ---------------------------------------------------
>>
>>                Key: OFBIZ-2110
>>                URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>>            Project: OFBiz
>>         Issue Type: Bug
>>         Components: order
>>   Affects Versions: SVN trunk
>>           Reporter: Vince Clark
>>           Assignee: Jacques Le Roux
>>           Priority: Minor
>>        Attachments: SalesOpportunityEntity.patch
>>
>>
>> There is a field in the SalesOpportunity form to link to a Party  
>> but no field in the entity to store it in.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757368#action_12757368 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

OK, will see next year...

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773863#action_12773863 ]

Pierre Smits commented on OFBIZ-2110:
-------------------------------------

It seems that this patch is included in the trunk.

So It can be closed.

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773867#action_12773867 ]

Jacques Le Roux commented on OFBIZ-2110:
----------------------------------------

Hi Pierre,

I don't see this line
<field name="opportunityStageId" type="id-ne"/>
in OFBiz, why did you felt we should close ?

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773887#action_12773887 ]

Pierre Smits commented on OFBIZ-2110:
-------------------------------------

Hi Jacques,

I thought this issue was about  InitialAccount not being set in the entity. That seems to be in the trunk.
 
Regarding opportunityStageID: this also seems to be in the entity model.

Regards,

Pierre

> Add initialAccount field to SalesOpportunity entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-2110
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2110
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Vince Clark
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SalesOpportunityEntity.patch
>
>
> There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.