[jira] Created: (OFBIZ-2119) Error in request overview screen when no party is given

[Nicolas Malin (Jira)]

Error in request overview screen when no party is given
-------------------------------------------------------

                 Key: OFBIZ-2119
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: any
            Reporter: Karim Rahimpur
            Priority: Minor
         Attachments: RequestForms.xml.patch

An error comes up on the overview screen of a request that has no requesting party.

Example:
1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
3. The error message shows up:
{panel}
* Request 10000 Information
:ERROR MESSAGE:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
{panel}

Problem:
RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.

Solution:
Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karim Rahimpur updated OFBIZ-2119:
----------------------------------

    Attachment: RequestForms.xml.patch

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666389#action_12666389 ]

Scott Gray commented on OFBIZ-2119:
-----------------------------------

Hi Karim

Your patch solves the problem, my only question is should we allow requests to be created without a from party in the first place?  Anyone else have any thoughts on this?

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667139#action_12667139 ]

Karim Rahimpur commented on OFBIZ-2119:
---------------------------------------

Hi Scott,
Thanks for looking into this. Thinking about your question, right now I can imagine only a couple of cases where this would make sense: in a case where the request taker does not have information about the requesting party at the time the request is registered, e.g. a customer asks for a quote and the request taker forgets to fill in the partyId. Or if anonymous requests were allowed because you really don't care about who made the request or that information is not available.
Anyhow, I think if we force users to input the from party then that should be done when creating the request so the error in the overview would be avoided.
What do you think?

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667170#action_12667170 ]

Jacques Le Roux commented on OFBIZ-2119:
----------------------------------------

I think forcing users to put a from party is the easier solution.

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667671#action_12667671 ]

Karim Rahimpur commented on OFBIZ-2119:
---------------------------------------

Jacques, I agree. I could provide an updated patch if there are no objections to this approach.

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667684#action_12667684 ]

Jacques Le Roux commented on OFBIZ-2119:
----------------------------------------

Please do

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2119:
--------------------------------------

    Assignee: Jacques Le Roux

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: RequestForms.xml.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2119:
-----------------------------------

    Attachment:     (was: RequestForms.xml.patch)

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Assignee: Jacques Le Roux
>            Priority: Minor
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karim Rahimpur updated OFBIZ-2119:
----------------------------------

    Attachment: CustRequest_party.patch

Here's the patch:
- when creating or updating a customer request, the requesting party's id must be given
- fix duplicate eca entry (2xcreateCustRequest)
- avoid error with missing fromPartyId (mainting this in case such entries already exist)

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CustRequest_party.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2119.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Karim,

Your patch is in trunk at revision: 746199  

> Error in request overview screen when no party is given
> -------------------------------------------------------
>
>                 Key: OFBIZ-2119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2119
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CustRequest_party.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> An error comes up on the overview screen of a request that has no requesting party.
> Example:
> 1. Create a new request and do not fill in Requesting Party [https://demo.hotwaxmedia.com/ordermgr/control/request]
> 2. Try to get the overview, assuming the newly created request's id is 10000 e.g. [https://demo.hotwaxmedia.com/ordermgr/control/ViewRequest?custRequestId=10000]
> 3. The error message shows up:
> {panel}
> * Request 10000 Information
> :ERROR MESSAGE:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId] (Error in form [requestInfo] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId])
> {panel}
> Problem:
> RequestForms.xml calls the service _getPartyNameForDate_ which expects a partyId as an input parameter. But there is no partyId associated to the request so the error shows up.
> Solution:
> Use __NA__ as default partyId. As per the attached patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.