[jira] Created: (OFBIZ-2120) Quote item view improvements (when productId is not specified)

[Nicolas Malin (Jira)]

Quote item view improvements (when productId is not specified)
--------------------------------------------------------------

                 Key: OFBIZ-2120
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2120
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
         Environment: any
            Reporter: Karim Rahimpur
            Priority: Minor
             Fix For: SVN trunk


These issues are approached:

1. If a quote has items with no productId specified, a link is shown that allows to create a new product. This can be misleading.
2. If a quote has two successive items where the first item has a product specified and the second does not, the second item will show the same product as the first item. This is due to a bug in ViewQuoteItemInfo.ftl: the product is not reset.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karim Rahimpur updated OFBIZ-2120:
----------------------------------

    Attachment: ViewQuoteItemInfo.ftl.patch

This patch resolves the issues mentioned.
It also changes the label for selected amount to OrderSelAmount instead of OrderAmount.

> Quote item view improvements (when productId is not specified)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ViewQuoteItemInfo.ftl.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> These issues are approached:
> 1. If a quote has items with no productId specified, a link is shown that allows to create a new product. This can be misleading.
> 2. If a quote has two successive items where the first item has a product specified and the second does not, the second item will show the same product as the first item. This is due to a bug in ViewQuoteItemInfo.ftl: the product is not reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2120.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Karim,

I commited a slightly modified vesion of your patch in trunk revision 741906.

I kept the possibility to create a product from a quote, but now it shows a clear label for that ("Create product")

> Quote item view improvements (when productId is not specified)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ViewQuoteItemInfo.ftl.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> These issues are approached:
> 1. If a quote has items with no productId specified, a link is shown that allows to create a new product. This can be misleading.
> 2. If a quote has two successive items where the first item has a product specified and the second does not, the second item will show the same product as the first item. This is due to a bug in ViewQuoteItemInfo.ftl: the product is not reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671491#action_12671491 ]

Jacques Le Roux commented on OFBIZ-2120:
----------------------------------------

I have added a complement in revision 741908 (to fix a bug when editing order items coming from a quote with - at least - a product not created)

> Quote item view improvements (when productId is not specified)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Karim Rahimpur
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ViewQuoteItemInfo.ftl.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> These issues are approached:
> 1. If a quote has items with no productId specified, a link is shown that allows to create a new product. This can be misleading.
> 2. If a quote has two successive items where the first item has a product specified and the second does not, the second item will show the same product as the first item. This is due to a bug in ViewQuoteItemInfo.ftl: the product is not reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.