[jira] Created: (OFBIZ-2126) add listPrice variable / method

[Nicolas Malin (Jira)]

add listPrice variable / method
-------------------------------

                 Key: OFBIZ-2126
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
             Project: OFBiz
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
         Environment: Linux Debian, OFBiz trunk rev. 735069
            Reporter: Eric DE MAULDE
            Priority: Trivial
             Fix For: SVN trunk


add listPrice method exactly similar to price method.
It allow to get the total list price from product configuration

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Attachment: ProductConfigWrapper_listPrice.patch

set methods :
getListPrice
getTotalListPrice

> add listPrice variable / method
> -------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735069
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper_listPrice.patch
>
>
> add listPrice method exactly similar to price method.
> It allow to get the total list price from product configuration

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Attachment:     (was: ProductConfigWrapper_listPrice.patch)

> add listPrice variable / method
> -------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735069
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> add listPrice method exactly similar to price method.
> It allow to get the total list price from product configuration

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Comment: was deleted

> add listPrice variable / method
> -------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735069
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> add listPrice method exactly similar to price method.
> It allow to get the total list price from product configuration

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

           Description:
into ProductConfigWrapper.class
add (total)listPrice method exactly same to price method.
It allows to get the total list price from a product configuration

Patch is doing

  was:
add listPrice method exactly similar to price method.
It allow to get the total list price from product configuration

    Remaining Estimate: 24h
     Original Estimate: 24h
               Summary: ProductConfigWrapper.class : listPrice  (was: add listPrice variable / method)

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735069
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Environment: Linux Debian, OFBiz trunk rev. 735315  (was: Linux Debian, OFBiz trunk rev. 735069)

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Attachment: ProductConfigWrapper.java_getTotalListPrice.patch

in ProductConfigWrapper.java
add method : getTotalListPrice
and other changes for listPrice

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735069
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE resolved OFBIZ-2126.
-----------------------------------

    Resolution: Fixed

Patch done

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664942#action_12664942 ]

Jacques Le Roux commented on OFBIZ-2126:
----------------------------------------

Hi Eric,

Same issue than in https://issues.apache.org/jira/browse/OFBIZ-2128?focusedCommentId=12664941#action_12664941

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Attachment:     (was: ProductConfigWrapper.java_getTotalListPrice.patch)

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2126:
----------------------------------

    Attachment: ProductConfigWrapper.java_getTotalListPrice.patch

This patch add the getTotalListPrice method for the ProductConfigWrapper class

(New patch with a right path to the file)

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665007#action_12665007 ]

Jacques Le Roux commented on OFBIZ-2126:
----------------------------------------

Eric,

It's ok for this patch because we don't need to merge any changes (no conflicts to be resolved automatically by a merge tool) But in general, we might need the right revision number to be able to merge your changes. I suggest that you use then a procedure like this one :

# Check out a fresh copy from OFBiz svn repo
# Make a diff from root with you working copy (svk). For that you may use WinMerge on WIndows, a such tool on Linux or even Subclipse by loading the 2 projects in Eclipse. This last possibilities may take sometimes to perform, WinMerge is really quick...
# Then put back your changes in the fresh svn working copy and create a patch using svn di

I will review your patch soon, thanks !

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2126.
----------------------------------

    Assignee: Jacques Le Roux

Thanks Eric,

Your patch is in trunk r736707  

> ProductConfigWrapper.class : listPrice
> --------------------------------------
>
>                 Key: OFBIZ-2126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 735315
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductConfigWrapper.java_getTotalListPrice.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> into ProductConfigWrapper.class
> add (total)listPrice method exactly same to price method.
> It allows to get the total list price from a product configuration
> Patch is doing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.