[jira] Created: (OFBIZ-2128) product image auto scale

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667241#action_12667241 ]

jacques.le.roux edited comment on OFBIZ-2128 at 1/26/09 5:32 AM:
-----------------------------------------------------------------

Hi Eric,

In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I  have still to figure out if we should not introduce rather an external API. BTW Imagero is not usable because of licence aspect, it's clearly a commercial product.
So the candidates seem to be so far
# [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp]
# [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to  [its licence|https://jai.dev.java.net/jdl-jai.pdf]

Any imputs appreciated



      was (Author: jacques.le.roux):
    Hi Eric,

In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I 'm still to figure out if we should onot introduce rather an external API for such tool. BTW Imagero is not usable because of licence aspects, it's clearly a commercial product.
So the candidates seem to be so far
# [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp]
# [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to  [its licence|https://jai.dev.java.net/jdl-jai.pdf]

Any imputs appreciated


 

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667243#action_12667243 ]

Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------

Finally JAI seems OK since it uses PMIW which is Apache licenced and used in Jakarta Image-Taglib Paul Piper said (but I will check I have already seen something which seamed OK but was not : Selenium). Anyway if it's OK it seems easier to use PMIW for our current needs...

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667244#action_12667244 ]

Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------

Clearly PMIW is ok : http://jakarta.apache.org/taglibs/

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2128:
-----------------------------------

    Attachment: productImageAutoScale.patch

New replacing patch, return in block added was not correct for a service

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2128:
-----------------------------------

    Attachment: productImageAutoScale.patch

Oops, I forgot new files :/

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2128:
-----------------------------------

    Attachment:     (was: productImageAutoScale.patch)

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2128:
-----------------------------------

    Attachment:     (was: productImageAutoScale.patch)

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2128:
-----------------------------------

    Attachment:     (was: productImageAutoScale.patch)

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2128:
-----------------------------------

    Attachment: productImageAutoScale.patch

Finally a correct patch  ? :)

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667295#action_12667295 ]

Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------

I don't have a lot of experience with Java and OFBiz.
Any new ideas and means are welcome.
Sure, it's more efficient to implement an API.

the main idea is to prepare and implement  images automation,
from the original images.

Thanks Jacques to improve this service

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667368#action_12667368 ]

Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------

Eric,

What are the problems you face so far ?  Because it's better to have something that works, even incomplete, than nothing, maybe we could already commit as is if the issues are not to annoying...

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667389#action_12667389 ]

Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------

Of course, I works with this service, even if the resize resolution isn't excellent.
If we save original images, one day with a better API we can resize again by example.
I'm not a comitter to decide ! Just I have suggested a solution

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667443#action_12667443 ]

Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------

So the only issues would be not optimal resize resolution, some JPG not working and no PNG at all ?

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667485#action_12667485 ]

Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------

JPG Images from one supplier can't be read with ImageIO.read, as all tried PNG images.
However documentation says these formats are compatible (http://java.sun.com/j2se/1.5.0/docs/api/javax/imageio/package-summary.html)
By example resizing resolution is a bit better with Gimp
It would be better to try with another API ?

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2128.
----------------------------------

    Resolution: Fixed

Thanks Eric,

Your patch is in trunk, revision: 739042 .

I finally decided to commit as it works well. We will see later if we find enough manpower to extend using a generic API

>  product image auto scale
> -------------------------
>
>                 Key: OFBIZ-2128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2128
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, OFBiz trunk rev. 737217
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.