product image auto scale
------------------------- Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 735315 Reporter: Eric DE MAULDE Fix For: SVN trunk This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Attachment: screenshot-1.jpg Product Content : Ovveride Simple Fields > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735315 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE resolved OFBIZ-2128. ----------------------------------- Resolution: Fixed Patch done > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735315 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: ProductImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Attachment: ProductImageAutoScale.patch Patch to implement product image auto scale when an user uploads an original image > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735315 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: ProductImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664941#action_12664941 ] Jacques Le Roux commented on OFBIZ-2128: ---------------------------------------- Hi Eric, Some issues with your patch * I guess you use a local repository because you have a revision 7215 number * I don't know how you generated your patch but I get this error D:\workspace\ofbizRun>patch -p0 0<ProductImageAutoScale.patch can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |´╗┐=== entitymodel.xml |================================================================== |--- entitymodel.xml (applications/product/entitydef/entitymodel.xml) (revision 7215) |+++ entitymodel.xml (applications/product/entitydef/entitymodel.xml) (revision 7215) Please (re)read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices Thanks -------------------------- File to patch: EOF > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735315 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: ProductImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Attachment: (was: ProductImageAutoScale.patch) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Environment: Linux Debian, OFBiz trunk rev. 735985 (was: Linux Debian, OFBiz trunk rev. 735315) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Attachment: productImageAutoScale.patch patch to implement product image auto scale into product content this patch is well formated (manually for the time being) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Attachment: (was: productImageAutoScale.patch) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666227#action_12666227 ] Eric DE MAULDE commented on OFBIZ-2128: --------------------------------------- I modified my main class I'm finishing to implement this function to product additional view > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666750#action_12666750 ] Jacques Le Roux commented on OFBIZ-2128: ---------------------------------------- Hi Eric, Should I review or wait ? > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Attachment: productImageAutoScale.patch Patch to automatic resize original Image in product content. It saves the original image. It resizes the original image into small, medium, large and detail size, related to the ImageProperties.xml file. In this file, we can define the final image extension. Same when an additionnal product view is added, but in this case, it doesn't save the related content of different sizes It doesn't work with some JPEG image. I don't kinow why ! It doesn't write an errror message in product content screen, if there has been an error during scalling (just in log) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666905#action_12666905 ] Eric DE MAULDE commented on OFBIZ-2128: --------------------------------------- This patch doesn't contains new image directories I wasn't abble to add these directories into my patch (with a diff) Because my configuration can't save a file if its directory isn't created, we have to create : framework/images/webapp/images/products/original framework/images/webapp/images/products/additional/small framework/images/webapp/images/products/additional/medium framework/images/webapp/images/products/additional/large framework/images/webapp/images/products/additional/detail Thanks for your comprehension Eric > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 735985 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: ---------------------------------- Environment: Linux Debian, OFBiz trunk rev. 737217 (was: Linux Debian, OFBiz trunk rev. 735985) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-2128: -------------------------------------- Assignee: Jacques Le Roux > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: ----------------------------------- Priority: Trivial (was: Major) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Assignee: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-2128: ------------------------------------ PLease Eric don' set the issue as Resolved or Fixed, we will do when commiting > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667211#action_12667211 ] Eric DE MAULDE commented on OFBIZ-2128: --------------------------------------- In this patch, the main thing is to save and keep the original image, in order to plan future developments and API improvement. Indeed from an original image, we able to work any changes. We can implement services to modify all images in one time : add a logo, resize, cut, compress ... The current "ImageIo.read(new File(filePath))" can't read some JPG images ? What do think about these API : JAI (Java Advanced Imaging from Sun http://java.sun.com/javase/technologies/desktop/media/jai/ ) Imagero (free for non-commercial use, http://reader.imagero.com/ ) > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Assignee: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: ----------------------------------- Attachment: productImageAutoScale.patch Hi Eric, In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I 'm still to figure out if we should onot introduce rather an external API for such tool. BTW Imagero is not usable because of licence aspects, it's clearly a commercial product. So the candidates seem to be so far # [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp] # [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf] Any imputs appreciated > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Assignee: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667242#action_12667242 ] Jacques Le Roux commented on OFBIZ-2128: ---------------------------------------- Note also that we should be able to deal with PNG files at least... > product image auto scale > ------------------------- > > Key: OFBIZ-2128 > URL: https://issues.apache.org/jira/browse/OFBIZ-2128 > Project: OFBiz > Issue Type: New Feature > Components: product > Affects Versions: SVN trunk > Environment: Linux Debian, OFBiz trunk rev. 737217 > Reporter: Eric DE MAULDE > Assignee: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg > > > This change allows to auto-scale product image when a user upload an original image. > The original image is saved into OFBiz. > Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml > When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |