[jira] Created: (OFBIZ-2146) Quote to order - manual adjustments amount not included in cart grand total

[Nicolas Malin (Jira)]

Quote to order - manual adjustments amount not included in cart grand total
---------------------------------------------------------------------------

                 Key: OFBIZ-2146
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2146
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total
            Reporter: Raj Saini


While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true.

One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in  OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-2146:
------------------------------------

    Assignee: Bilgin Ibryam

> Quote to order - manual adjustments amount not included in cart grand total
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-2146
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2146
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total
>            Reporter: Raj Saini
>            Assignee: Bilgin Ibryam
>
> While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true.
> One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in  OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-2146:
---------------------------------

    Attachment: order.diff

Raj, could you check if this patch solves the bug ?

> Quote to order - manual adjustments amount not included in cart grand total
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-2146
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2146
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total
>            Reporter: Raj Saini
>            Assignee: Bilgin Ibryam
>         Attachments: order.diff
>
>
> While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true.
> One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in  OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674050#action_12674050 ]

Jacques Le Roux commented on OFBIZ-2146:
----------------------------------------

Hi Raj,

DId you get a chance to test Bilgin's patch ?

> Quote to order - manual adjustments amount not included in cart grand total
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-2146
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2146
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total
>            Reporter: Raj Saini
>            Assignee: Bilgin Ibryam
>         Attachments: order.diff
>
>
> While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true.
> One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in  OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674063#action_12674063 ]

Raj Saini commented on OFBIZ-2146:
----------------------------------

Hi Jacques and Bilgin,

I am out of the office for a week and could not look test it personally. However, I has asked one of my team member to test and he confirmed that it is working. I will look into it next week and will update you.

> Quote to order - manual adjustments amount not included in cart grand total
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-2146
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2146
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total
>            Reporter: Raj Saini
>            Assignee: Bilgin Ibryam
>         Attachments: order.diff
>
>
> While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true.
> One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in  OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.