[jira] Created: (OFBIZ-2170) Providing Functionality of ProductFeatureIactn Entity

[Nicolas Malin (Jira)]

Providing Functionality of ProductFeatureIactn Entity
-----------------------------------------------------

                 Key: OFBIZ-2170
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
             Project: OFBiz
          Issue Type: Improvement
          Components: ecommerce, product
    Affects Versions: SVN trunk
            Reporter: Arpit Singh Pandya


ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2170:
--------------------------------------

    Attachment: ProductFeatureIactn.patch

The work I done in this patch to improve this functionality is as:
Make an entry of productId in ProductFeatureIactn entity of DemoProduct.xml file in ecommerce component. Uncomment the lines which are in use to implement this  functionality (ie it will work for functionality, which features are incompatible or depended with any particular product) in product component and also deleted some code of no use there.

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2170:
--------------------------------------

    Priority: Minor  (was: Major)

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2170:
--------------------------------------

    Assignee: Jacques Le Roux

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670916#action_12670916 ]

Jacques Le Roux commented on OFBIZ-2170:
----------------------------------------

Hi Arpit,

I did not test yet, but this introduces issues where ProductWorker.getVariantFromFeatureTree is used
ShoppingCartEvents.java[265]
ProductConfigWorker.java[154] (BTW there cart.addToCart.incompatibilityVariantFeatur should be also used)
For the moment, a null value is tested there not a non empty String.

Could you explain the problem you are tackling, issues you got, what you want to achieve and how the code you provided is doing that, with detailled steps please ?

Thanks

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671159#action_12671159 ]

Arpit Singh Pandya commented on OFBIZ-2170:
-------------------------------------------

Hello Jacques,

Thanks for the comment, its really very helpful to me and clear all my confusion regarding to this files(ProductWorker.java , ShoppingCartEvents.java and ProductConfigWorker.java). Its working fine as per your suggestion.
I was confused because of that useless commented code, and still I am confused about that commented code why it is there which is not in use.
If you suggest then i will clean up that commented code properly and upload a new patch here in place of this patch.

Once again Thanks a lot Jacques.

Kind Regards
Arpit Singh Pandya

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671173#action_12671173 ]

Jacques Le Roux commented on OFBIZ-2170:
----------------------------------------

Hi Arpit,

Yes, please provide a patch following my suggestions and the work you already done and proved to work.

Thanks

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2170:
--------------------------------------

    Attachment:     (was: ProductFeatureIactn.patch)

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2170:
--------------------------------------

    Attachment: ProductFeatureIactn.patch

Just Make little changes
1. Remove useless commented code
2. Complete the Entry in DemoProduct.xml for ProductFeatureIactn Entity

Regards
Arpit Singh Pandya

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671443#action_12671443 ]

Arpit Singh Pandya commented on OFBIZ-2170:
-------------------------------------------

Hello Jacques,
I upload the new patch as per your suggestion.

Thanks & Regards
Arpit Singh Pandya

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671493#action_12671493 ]

Jacques Le Roux commented on OFBIZ-2170:
----------------------------------------

Thanks Arpit,

I have added the 1st part of your patch in revision: 741912  
I'm waiting some information about cart.addToCart.incompatibilityVariantFeature and cart.addToCart.dependencyVariantFeature (which does not exist for the moment) before changing things about getVariantFromFeatureTree

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671524#action_12671524 ]

Jacques Le Roux commented on OFBIZ-2170:
----------------------------------------

BTW, it would be better if we could prevent to show the incompatible options as soon we know it (when we select other features). I know this is not so easy to do, because of the js functions embedded in groovy...

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2170.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Closed by revision 742163  

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671769#action_12671769 ]

Arpit Singh Pandya commented on OFBIZ-2170:
-------------------------------------------

Thanks Jacques,
I will definitely go for it, and try my best to solve this.
and always welcome your comments and suggestions.

Kind Regards
Arpit Singh Pandya

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671771#action_12671771 ]

Jacques Le Roux commented on OFBIZ-2170:
----------------------------------------

Thanks Arpit,

Looking forward for your efforts

> Providing Functionality of ProductFeatureIactn Entity
> -----------------------------------------------------
>
>                 Key: OFBIZ-2170
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2170
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureIactn.patch
>
>
> ProductFeatureIactn Entity is not working in current Scenario, it need some amendments in the DemoProduct.xml file in eccomerce component  and ProductWorker.java in Product component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.