[jira] Created: (OFBIZ-2172) Web Application / VisualTheme association

[Nicolas Malin (Jira)]

Web Application / VisualTheme association
-----------------------------------------

                 Key: OFBIZ-2172
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
             Project: OFBiz
          Issue Type: New Feature
            Reporter: Bruno Busco
         Attachments: VisualThemeSets.patch

Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
Along with any comments you will do on the patch I think now I need some hint to go further:

1) In order to have this model working we should have on every application's WEB.XML file something like this:
    <context-param>
        <param-name>webSiteId</param-name>
        <param-value>CONTENT_SITE</param-value>
    <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
    </context-param>
with a specific different param-name for every webapp. Is this correct?
If yes could we use the same webapp name for the webSiteId?

2) We should create a WebSite for every WebApp. Is this correct?

3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?

Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2172:
-------------------------------

    Attachment: VisualThemeSets.patch

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2172:
-------------------------------

    Fix Version/s: Release Branch 9.3

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672420#action_12672420 ]

Bruno Busco commented on OFBIZ-2172:
------------------------------------

Anybody interested in this?
Any review/comments?

Thank you,
Bruno

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reassigned OFBIZ-2172:
----------------------------------

    Assignee: Bruno Busco

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-2172.
---------------------------------

    Resolution: Fixed

Thanks Bruno, this looks like a good foundation (ie data model, etc looks good; even the seed data in ecommerce looks good given the definition that seed data is maintained with code so works well with the ecommerce templates).

I added some comments in the commit log about things that are not yet done... correct me if I missed something that is actually done though!

It is in SVN rev 743202.

Here's the commit log for convenience:

"Applied patch from Bruno Busco in Jira #OFBIZ-2172 with basics for VisualThemeSet; still not possible to change themes in ecommerce (should probably be supported on the back end instead of the front end, ie in the catalog manager and not by a customer in ecommerce, or perhaps only allowed in ecommerce if a flag on the ProductStore says its okay; also does not yet filter selectable themes in the back-end/manager applications"

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673023#action_12673023 ]

Bruno Busco commented on OFBIZ-2172:
------------------------------------

David,
thank you for committing this.
The Ecommerce theme change should be implemented by the patch attached to OFBIZ-2106
but may be I need to better review it.

In any case I am going to remove from the ProductStore entity all direct references to stylesheets, header images etc.
Only a VisualTheme selection will do the job.
Please provide any comment if somebody sees problems with this.

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673026#action_12673026 ]

David E. Jones commented on OFBIZ-2172:
---------------------------------------

For the ProductStore fields, it would be good to remove all references to them in code/templates/etc and then use the deprecation pattern in the entity definition (ie headerImageUrl becomes oldHeaderImageUrl and then a column-name of HEADER_IMAGE_URL is specified so it matches the old value). That way the fields are still accessible through the entity engine.

Yes, I think this is a good direction. Comments from others would be welcome as this is definitely a change...

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673674#action_12673674 ]

Jacques Le Roux commented on OFBIZ-2172:
----------------------------------------

I did not fin any headerImageUrl in ProductStore entity definition but I agree that ProductStore is bloated and some slimming can't hurt.
I suppose
* styleSheet
* headerLogo
* headerMiddleBackground
* headerRightBackground

are concerned ?

BTW there are still 72 references to headerImageUrl  in code (*.java, *.ftl, *.xml) but most are commented out in CommonScreens.xml files

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676986#action_12676986 ]

Matthias Häußer commented on OFBIZ-2172:
----------------------------------------

I added a new Visual Theme following the instructions in http://docs.ofbiz.org/display/OFBIZ/Visual+Themes+-+How+to, but the only themes I can see in https://localhost:8443/catalog/control/EditProductStore?productStoreId=10000 are EC_DEFAULT and MULTIFLEX.
Is this a bug? If not, how can I find out what's going on?

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677125#action_12677125 ]

Bruno Busco commented on OFBIZ-2172:
------------------------------------

Hi Matthias,
I will update the How To as soon as the VisualTheme for Ecommerce will be implemented in its final way. There is a work in progress right now.
In any case I think that in order to have your theme shown in https://localhost:8443/catalog/control/EditProductStore?productStoreId=10000
you only need to add this attribute:
visualThemeSetId="ECOMMERCE"
to your VisualTheme definition.

The VisualTheme definition line in your theme data should look similar to this:
    <VisualTheme visualThemeId="MULTIFLEX" visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for Ecommerce"/>

Hope this helps

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677970#action_12677970 ]

Matthias Häußer commented on OFBIZ-2172:
----------------------------------------

Hi Bruno,
thanks for your help. With the visualThemeSetId="ECOMMERCE" attribute I can select the Visual Theme in the backend. However, I run in all kinds of errors related to layoutSettings.companyName and layoutSettings.commonHeaderImageLinkUrl.
I also get
framework/common/script/org/ofbiz/common/CommonServices.xml#getVisualThemeResources]]: ; [Visual Theme resources not found.]

I exchanged the bg_head_middle.jpg file in the visual theme in the hot-deploy folder, but with no effect. Only when I exchanged the file contents in the themes folder, the change was visible.

Hm, I guess I'll stick with the old version (Stylesheet + Logo file) and see how this develops...

> Web Application / VisualTheme association
> -----------------------------------------
>
>                 Key: OFBIZ-2172
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2172
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: Release Branch 9.3
>
>         Attachments: VisualThemeSets.patch
>
>
> Following a recent discussion on the ML about an association model between WebApps and VisualThemes I would like to submit this "half baked" ;-) patch.
> Along with any comments you will do on the patch I think now I need some hint to go further:
> 1) In order to have this model working we should have on every application's WEB.XML file something like this:
>     <context-param>
>         <param-name>webSiteId</param-name>
>         <param-value>CONTENT_SITE</param-value>
>     <description>A unique ID used to look up the Content entity that serves as the root for publish points</description>
>     </context-param>
> with a specific different param-name for every webapp. Is this correct?
> If yes could we use the same webapp name for the webSiteId?
> 2) We should create a WebSite for every WebApp. Is this correct?
> 3) I have implemented a filter on the VisualTheme Lookup that let the user choose among all the applicable themes. (if a WebSiteId is defined)
> But doing this I realized that the user could choose a different theme for different applications and so these should be recorded as preferences. I mean we should record that a user has selected a theme _for a certain application_. is this correct?
> Thank you for supporting me.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.