[jira] Created: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

[Nicolas Malin (Jira)]

paginate-size-field and paginate-index-field on lists
-----------------------------------------------------

                 Key: OFBIZ-2175
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2175
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk


When adding parameters like those two in the definition of a list
paginate-size-field="3"
paginate-index-field="2"

The results shown are not those that we want, because there are no changes on the interface.
In this example, we want to have 3 results per page and start on the 2nd page.

Moreover the URL shown in the address bar is not the same as the other screens (3_1=10&2_1=1), where they are with VIEW_SIZE_1=3&VIEW_INDEX_1=2, for example.

This patch on the ModelForm.java file, made by 4 trainees, will correct the errors explained on the top of this description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2175:
--------------------------------------

    Attachment: ModelForm.java.patch

Made by Antoine Bourre , Louis Briolet, Alexandre Lassalle and Amady Diop

> paginate-size-field and paginate-index-field on lists
> -----------------------------------------------------
>
>                 Key: OFBIZ-2175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2175
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ModelForm.java.patch
>
>
> When adding parameters like those two in the definition of a list
> paginate-size-field="3"
> paginate-index-field="2"
> The results shown are not those that we want, because there are no changes on the interface.
> In this example, we want to have 3 results per page and start on the 2nd page.
> Moreover the URL shown in the address bar is not the same as the other screens (3_1=10&2_1=1), where they are with VIEW_SIZE_1=3&VIEW_INDEX_1=2, for example.
> This patch on the ModelForm.java file, made by 4 trainees, will correct the errors explained on the top of this description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671795#action_12671795 ]

David E. Jones commented on OFBIZ-2175:
---------------------------------------

Rejecting this initial patch. Even a few lines in I can see that it breaks existing functionality, namely using ONLY the default field (from DEFAULT_PAG_INDEX_FIELD) and not looking at all at the field name setting (from this.paginateIndexField.expandString(context)).

Also, the description of the issue doesn't make sense: "3" is not a valid field name, nor is "2". It appears that this patch is based on a misunderstanding of how these tools work.

If the above statement is not correct, please reply, otherwise we'll close this issue as rejected. If you have additional questions about how this is supposed to function, please send them to the mailing list instead of here as Jira is not meant for support.

> paginate-size-field and paginate-index-field on lists
> -----------------------------------------------------
>
>                 Key: OFBIZ-2175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2175
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ModelForm.java.patch
>
>
> When adding parameters like those two in the definition of a list
> paginate-size-field="3"
> paginate-index-field="2"
> The results shown are not those that we want, because there are no changes on the interface.
> In this example, we want to have 3 results per page and start on the 2nd page.
> Moreover the URL shown in the address bar is not the same as the other screens (3_1=10&2_1=1), where they are with VIEW_SIZE_1=3&VIEW_INDEX_1=2, for example.
> This patch on the ModelForm.java file, made by 4 trainees, will correct the errors explained on the top of this description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671798#action_12671798 ]

Erwan de FERRIERES commented on OFBIZ-2175:
-------------------------------------------

The problem is when you want to navigate in the results of this list for example :
https://localhost:8443/content/control/ContentSetupMenu

When you click on the next, the URL will be
https://localhost:8443/content/control/ContentSetupMenu?3_1=10&2_1=1#
then
https://localhost:8443/content/control/ContentSetupMenu?3_1=10&2_1=2#

And I totally agree when you said that 3 is not a valid field name, but it is what is written in the URL.

Hope that can explain the patch

> paginate-size-field and paginate-index-field on lists
> -----------------------------------------------------
>
>                 Key: OFBIZ-2175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2175
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ModelForm.java.patch
>
>
> When adding parameters like those two in the definition of a list
> paginate-size-field="3"
> paginate-index-field="2"
> The results shown are not those that we want, because there are no changes on the interface.
> In this example, we want to have 3 results per page and start on the 2nd page.
> Moreover the URL shown in the address bar is not the same as the other screens (3_1=10&2_1=1), where they are with VIEW_SIZE_1=3&VIEW_INDEX_1=2, for example.
> This patch on the ModelForm.java file, made by 4 trainees, will correct the errors explained on the top of this description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671801#action_12671801 ]

Jacopo Cappellato commented on OFBIZ-2175:
------------------------------------------

paginate-size-field and paginate-index-field are used to set the *names* of the variables (fields) that contain the size (e.g. 3) and page index (e.g. 2)

Jacopo

> paginate-size-field and paginate-index-field on lists
> -----------------------------------------------------
>
>                 Key: OFBIZ-2175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2175
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ModelForm.java.patch
>
>
> When adding parameters like those two in the definition of a list
> paginate-size-field="3"
> paginate-index-field="2"
> The results shown are not those that we want, because there are no changes on the interface.
> In this example, we want to have 3 results per page and start on the 2nd page.
> Moreover the URL shown in the address bar is not the same as the other screens (3_1=10&2_1=1), where they are with VIEW_SIZE_1=3&VIEW_INDEX_1=2, for example.
> This patch on the ModelForm.java file, made by 4 trainees, will correct the errors explained on the top of this description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-2175.
-------------------------------------

    Resolution: Invalid

My mistake.. A total misreading of the DTDs..

> paginate-size-field and paginate-index-field on lists
> -----------------------------------------------------
>
>                 Key: OFBIZ-2175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2175
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: ModelForm.java.patch
>
>
> When adding parameters like those two in the definition of a list
> paginate-size-field="3"
> paginate-index-field="2"
> The results shown are not those that we want, because there are no changes on the interface.
> In this example, we want to have 3 results per page and start on the 2nd page.
> Moreover the URL shown in the address bar is not the same as the other screens (3_1=10&2_1=1), where they are with VIEW_SIZE_1=3&VIEW_INDEX_1=2, for example.
> This patch on the ModelForm.java file, made by 4 trainees, will correct the errors explained on the top of this description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.