[jira] Created: (OFBIZ-2177) Error using the UtilDateTime.addDaysToTimestamp method

[Nicolas Malin (Jira)]

Error using the UtilDateTime.addDaysToTimestamp method
------------------------------------------------------

                 Key: OFBIZ-2177
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2177
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
         Environment: OS Windows XP SP3
            Reporter: Marco Ruocco
             Fix For: SVN trunk
         Attachments: UtilDateTime.patch

I try to use the UtilDateTime.addDaysToTimestamp method that accept the int parameters days. When you want add a number of day more the 24 it reach the limit of the int variable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Ruocco updated OFBIZ-2177:
--------------------------------

    Attachment: UtilDateTime.patch

I attach the patch tha solve this problem

> Error using the UtilDateTime.addDaysToTimestamp method
> ------------------------------------------------------
>
>                 Key: OFBIZ-2177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2177
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: OS Windows XP SP3
>            Reporter: Marco Ruocco
>             Fix For: SVN trunk
>
>         Attachments: UtilDateTime.patch
>
>
> I try to use the UtilDateTime.addDaysToTimestamp method that accept the int parameters days. When you want add a number of day more the 24 it reach the limit of the int variable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2177.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Marco,

Please update your working copy before making a patch. As your patch was outdated I was not able to merge. For this case it was really easy to do it by hand, so no worries. Your changes are in trunk at revision 742933.

> Error using the UtilDateTime.addDaysToTimestamp method
> ------------------------------------------------------
>
>                 Key: OFBIZ-2177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2177
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: OS Windows XP SP3
>            Reporter: Marco Ruocco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: UtilDateTime.patch
>
>
> I try to use the UtilDateTime.addDaysToTimestamp method that accept the int parameters days. When you want add a number of day more the 24 it reach the limit of the int variable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672296#action_12672296 ]

Adrian Crum commented on OFBIZ-2177:
------------------------------------

By the way, that method should not be used. Use the adjustTimestamp method instead.

> Error using the UtilDateTime.addDaysToTimestamp method
> ------------------------------------------------------
>
>                 Key: OFBIZ-2177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2177
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: OS Windows XP SP3
>            Reporter: Marco Ruocco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: UtilDateTime.patch
>
>
> I try to use the UtilDateTime.addDaysToTimestamp method that accept the int parameters days. When you want add a number of day more the 24 it reach the limit of the int variable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672303#action_12672303 ]

Jacques Le Roux commented on OFBIZ-2177:
----------------------------------------

Should we not remove them (or at least deprecate) then ?

> Error using the UtilDateTime.addDaysToTimestamp method
> ------------------------------------------------------
>
>                 Key: OFBIZ-2177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2177
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: OS Windows XP SP3
>            Reporter: Marco Ruocco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: UtilDateTime.patch
>
>
> I try to use the UtilDateTime.addDaysToTimestamp method that accept the int parameters days. When you want add a number of day more the 24 it reach the limit of the int variable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672309#action_12672309 ]

Adrian Crum commented on OFBIZ-2177:
------------------------------------

I suggested deprecating them a some time ago, and that suggestion was met with opposition - https://issues.apache.org/jira/browse/OFBIZ-1361.

> Error using the UtilDateTime.addDaysToTimestamp method
> ------------------------------------------------------
>
>                 Key: OFBIZ-2177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2177
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: OS Windows XP SP3
>            Reporter: Marco Ruocco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: UtilDateTime.patch
>
>
> I try to use the UtilDateTime.addDaysToTimestamp method that accept the int parameters days. When you want add a number of day more the 24 it reach the limit of the int variable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.