[jira] Created: (OFBIZ-2178) Create the promotion on the basis of shipping total condition.

[Nicolas Malin (Jira)]

Create the promotion on the basis of shipping total condition.
--------------------------------------------------------------

                 Key: OFBIZ-2178
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
             Project: OFBiz
          Issue Type: Improvement
          Components: product
            Reporter: Mukesh Manohar Marathe
            Priority: Minor


We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukesh Manohar Marathe updated OFBIZ-2178:
------------------------------------------

    Attachment: promos_set up_shipping_sub_total_condition.patch

> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2178
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Mukesh Manohar Marathe
>            Priority: Minor
>         Attachments: promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672237#action_12672237 ]

Jacques Le Roux commented on OFBIZ-2178:
----------------------------------------

Hi  Mukesh,

Could you please also provide a label
    <property key="Enumeration.description.PPIP_SHIP_SUB_TOTAL">
in CommonEntityLabels.xml

Else looks good, thanks!

> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2178
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Mukesh Manohar Marathe
>            Priority: Minor
>         Attachments: promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2178:
--------------------------------------

    Assignee: Jacques Le Roux

> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2178
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Mukesh Manohar Marathe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2178:
-----------------------------------

    Attachment: promos_set up_shipping_sub_total_condition.patch

Hi Mukesh,

I had a deeper look, here are my remarks, see attached patch for details

* I prefer to speak about Shipping total than sub_total
* I have used a BigDecimal in ProductPromoWorker.java instead of a Double
* there is an issue when you modify an order (adding an item or modifying one) : you loose the shipping total promotion. I guess it's because getShipEstimate is not called again but it's more a bet than anything else and I do not have enough time to look closer at it right now, help appreciated...

> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2178
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Mukesh Manohar Marathe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: promos_set up_shipping_sub_total_condition.patch, promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769921#action_12769921 ]

Mukesh Manohar Marathe commented on OFBIZ-2178:
-----------------------------------------------

Hi Jacques,

This improvement is now implemented at  https://issues.apache.org/jira/browse/OFBIZ-2488 

Mukesh

> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2178
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Mukesh Manohar Marathe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: promos_set up_shipping_sub_total_condition.patch, promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2178.
----------------------------------

    Resolution: Duplicate

Thanks Mukesh,

Closed as duplicate of OFBIZ-2488

> Create the promotion on the basis of shipping total condition.
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2178
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2178
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>            Reporter: Mukesh Manohar Marathe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: promos_set up_shipping_sub_total_condition.patch, promos_set up_shipping_sub_total_condition.patch
>
>
> We can not create the promotion on the basis of shipping total condition. We can add the new condition which will create the promotion on shipping total.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.