OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

11 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
----------------------------------------------------------------------------------------

Key: OFBIZ-2239
URL: https://issues.apache.org/jira/browse/OFBIZ-2239
Project: OFBiz
Issue Type: Sub-task
Components: order
Affects Versions: SVN trunk
Reporter: Pranay Pandey
Priority: Minor
Fix For: SVN trunk

Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.

*Implementation Notes:*
Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

[ https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2239:
--------------------------------

Attachment: Ofbiz-2239.patch

This patch fulfills the required functionality.

Steps for testing:

1) Create a purchase order
2) Then edit Order detail page
3) Fill up estimated ship date and estimated delivery date.
4) This dates will be saved in OrderItem and OrderItemShipGroup
5) Then create Shipment from Order detail page
6) These dates will be propagated .

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682239#action_12682239 ]

Jacques Le Roux commented on OFBIZ-2239:
----------------------------------------

Hi Divesh,

I just did a cursory review of your patch, some remarks:
* please use preferably FastList than LinkedList
* please use preferably new for loop (1.5) style instead of iterator (even if current code around still uses iterator)
* dont put any tabs in your code but 4 spaces (2 in .ftl, please be sure to check [Contributors Best Practices|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices])

Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2239.
----------------------------------

Resolution: Fixed
Assignee: Jacques Le Roux

Thanks Divesh,

Your patch is in trunk at revision: 755011

Some minor changes I did
public Map<Object, Object> shipItemInfo = FastMap.newInstance();
instead of
public LinkedHashMap<Object, Object> shipItemInfo = new LinkedHashMap();

if (estimatedDeliveryDates.size() > 0) {
instead of
if (UtilValidate.isNotEmpty(estimatedDeliveryDates)) {

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682554#action_12682554 ]

Pranay Pandey commented on OFBIZ-2239:
--------------------------------------

Thanks Jacques for taking care of this.

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey reopened OFBIZ-2239:
----------------------------------

There is one issue remains that we have to operate on these dates only for purchase orders.
So Divesh please provide the patch for the same.

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFbiz-2239.patch, Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFbiz-2239.patch, Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFbiz-2239.patch, Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2239) Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2239.
----------------------------------

Resolution: Fixed

I did not notice either as it was only in the main issue title. Anyway, now in trunk at revision: 755144

Thanks to both

> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFbiz-2239.patch, Ofbiz-2239.patch, Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and estimatedDeliveryDate to the buyer which can be entered by the buyer in the order detail page for the orderItems, which will be saved in OrderItem and OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding similar fields to OrderItemShipGroup with the last date amongst them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.