[jira] Created: (OFBIZ-2247) use order numbers as return ids

[Nicolas Malin (Jira)]

use order numbers as return ids
-------------------------------

                 Key: OFBIZ-2247
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2247
             Project: OFBiz
          Issue Type: New Feature
          Components: accounting
    Affects Versions: Release Branch 4.0
         Environment: all
            Reporter: Albert Mayo
            Priority: Minor
             Fix For: Release Branch 4.0


I needed functionality for the return numbers to pull from order sequence pool. I have programmed the feature, copying the functionality of returns using the invoice sequence pool.  I'm new at it, but I've attached what I think is an SVN patch.  I've done minimal testing and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Albert Mayo updated OFBIZ-2247:
-------------------------------

    Attachment: OrderIdForReturns.diff

> use order numbers as return ids
> -------------------------------
>
>                 Key: OFBIZ-2247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2247
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: Release Branch 4.0
>         Environment: all
>            Reporter: Albert Mayo
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: OrderIdForReturns.diff
>
>
> I needed functionality for the return numbers to pull from order sequence pool. I have programmed the feature, copying the functionality of returns using the invoice sequence pool.  I'm new at it, but I've attached what I think is an SVN patch.  I've done minimal testing and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683890#action_12683890 ]

Albert Mayo commented on OFBIZ-2247:
------------------------------------

Note about my code:

I'm also somewhat new at minilang.  I'm not sure if there is a better way to do an if/else statement, so I have to do add a couple extra lines when I modified OrderReturnServices.xml.

> use order numbers as return ids
> -------------------------------
>
>                 Key: OFBIZ-2247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2247
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: Release Branch 4.0
>         Environment: all
>            Reporter: Albert Mayo
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: OrderIdForReturns.diff
>
>
> I needed functionality for the return numbers to pull from order sequence pool. I have programmed the feature, copying the functionality of returns using the invoice sequence pool.  I'm new at it, but I've attached what I think is an SVN patch.  I've done minimal testing and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702872#action_12702872 ]

Jacques Le Roux commented on OFBIZ-2247:
----------------------------------------

There are 2 things weird  :
* Which repository are you using ? The release number, 2995, is odd
* We don't want to apply any new feature to a release, only bug fixes, so this should be a diff with trunk

> use order numbers as return ids
> -------------------------------
>
>                 Key: OFBIZ-2247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2247
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: Release Branch 4.0
>         Environment: all
>            Reporter: Albert Mayo
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: OrderIdForReturns.diff
>
>
> I needed functionality for the return numbers to pull from order sequence pool. I have programmed the feature, copying the functionality of returns using the invoice sequence pool.  I'm new at it, but I've attached what I think is an SVN patch.  I've done minimal testing and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702884#action_12702884 ]

Albert Mayo commented on OFBIZ-2247:
------------------------------------

I am using a repository specific to my project.  I provided the diff just to share what I did. The changes are so minimal I figured someone could integrate it manually into trunk without many problems.

> use order numbers as return ids
> -------------------------------
>
>                 Key: OFBIZ-2247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2247
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: Release Branch 4.0
>         Environment: all
>            Reporter: Albert Mayo
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: OrderIdForReturns.diff
>
>
> I needed functionality for the return numbers to pull from order sequence pool. I have programmed the feature, copying the functionality of returns using the invoice sequence pool.  I'm new at it, but I've attached what I think is an SVN patch.  I've done minimal testing and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2247.
----------------------------------

    Resolution: Won't Fix
      Assignee: Jacques Le Roux

We don't apply new feature to a release. Morevoer please read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices before submitting a patch

Thanks

> use order numbers as return ids
> -------------------------------
>
>                 Key: OFBIZ-2247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2247
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: Release Branch 4.0
>         Environment: all
>            Reporter: Albert Mayo
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: OrderIdForReturns.diff
>
>
> I needed functionality for the return numbers to pull from order sequence pool. I have programmed the feature, copying the functionality of returns using the invoice sequence pool.  I'm new at it, but I've attached what I think is an SVN patch.  I've done minimal testing and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.