[
https://issues.apache.org/jira/browse/OFBIZ-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688646#action_12688646 ]
Pranay Pandey commented on OFBIZ-2249:
--------------------------------------
Thanks Pratik, There few more things which should be improved in your patch to make code simpler:
* Use entity one without mapping field explicitly because auto-field-map will do the job.
* No need to set fields for orderId and orderItemSeqId as those can directly be accessed where needed from parameters.
* No need to iterate the list you are fetching for itemIssuance, first-from-list can be used.
* OrderId and OrderSeqId will be required attribute for the service, so optionality for them should be false and no need to have facilityId as a In attribute in the service def.
Please do the needful changes and upload the updated patch. Also please keep the name of the patch same as the last one.
> Adjust Purchase Order Items if received quantity is higher.
> -----------------------------------------------------------
>
> Key: OFBIZ-2249
> URL:
https://issues.apache.org/jira/browse/OFBIZ-2249> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2249, OFBIZ-2249.patch, OFBIZ-2249.patch
>
>
> While receiving inventory against a purchase order if received quantity is higher than the quantity on purchase order then adjust PO item. Also if a shipment was created the shipment item must be updated too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
