[jira] Created: (OFBIZ-2250) Generate Report for Externally Applied Promotion On Order

[Nicolas Malin (Jira)]

Generate Report for Externally Applied Promotion On Order
---------------------------------------------------------

                 Key: OFBIZ-2250
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2250
             Project: OFBiz
          Issue Type: New Feature
          Components: order
            Reporter: Nitesh Yetta
            Priority: Minor


Description:

In this Report
1> Admin can view all promotions that are applied on order externally.
   
Report consist of:

a> Promotion Name
b> Promo code
c> OrderId
d> PartyId
e> Total
f> Discount Ammount
g> Applied Date

2> On clicking Party Id admin can view party details.
3> On clicking Order Id admin can view order details
4> From Promotion count admin can get exact figure for how many times promotion is used.

Local view of Report video:
http://www.screencast.com/t/shGGE3QeZ

Note:
I have created UiLables in English only.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nitesh Yetta updated OFBIZ-2250:
--------------------------------

    Attachment: PromotionReport.patch

> Generate Report for Externally Applied Promotion On Order
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2250
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2250
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Nitesh Yetta
>            Priority: Minor
>         Attachments: PromotionReport.patch
>
>
> Description:
> In this Report
> 1> Admin can view all promotions that are applied on order externally.
>    
> Report consist of:
> a> Promotion Name
> b> Promo code
> c> OrderId
> d> PartyId
> e> Total
> f> Discount Ammount
> g> Applied Date
> 2> On clicking Party Id admin can view party details.
> 3> On clicking Order Id admin can view order details
> 4> From Promotion count admin can get exact figure for how many times promotion is used.
> Local view of Report video:
> http://www.screencast.com/t/shGGE3QeZ
> Note:
> I have created UiLables in English only.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688278#action_12688278 ]

Nitesh Yetta commented on OFBIZ-2250:
-------------------------------------

Hi All,

I have attached the patch for this issue, If any change is required then please let me know.

Thank,
Nitesh Yetta.

> Generate Report for Externally Applied Promotion On Order
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2250
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2250
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Nitesh Yetta
>            Priority: Minor
>         Attachments: PromotionReport.patch
>
>
> Description:
> In this Report
> 1> Admin can view all promotions that are applied on order externally.
>    
> Report consist of:
> a> Promotion Name
> b> Promo code
> c> OrderId
> d> PartyId
> e> Total
> f> Discount Ammount
> g> Applied Date
> 2> On clicking Party Id admin can view party details.
> 3> On clicking Order Id admin can view order details
> 4> From Promotion count admin can get exact figure for how many times promotion is used.
> Local view of Report video:
> http://www.screencast.com/t/shGGE3QeZ
> Note:
> I have created UiLables in English only.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688294#action_12688294 ]

Jacques Le Roux commented on OFBIZ-2250:
----------------------------------------

Hi Nithesh,

I quickly reviewed your patch. Please

* don't use tabs in your patches, try to keep good indentations (in ProductPromoAndCodeAndUseAndOrdHeader for instance), and read [Coding Conventions|http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions]
* for the sake of security use the new hyperlink target sub-attributes : param-name, from-field or value, and begin by component:// (even if it's not yet done around the code you add, it's a work in progress...)
* if possible, use UtilValidate methods, for instance UtilValidate.isDate (instead of fromDate.length() > 8)). Not sure it's relevant in your case, though : did not look into details...
* try to not use du.executeQuery(sqlCommand); but use regular OFBiz code for SQL requests

Else looks good at 1st glance.

Thanks

> Generate Report for Externally Applied Promotion On Order
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2250
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2250
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Nitesh Yetta
>            Priority: Minor
>         Attachments: PromotionReport.patch
>
>
> Description:
> In this Report
> 1> Admin can view all promotions that are applied on order externally.
>    
> Report consist of:
> a> Promotion Name
> b> Promo code
> c> OrderId
> d> PartyId
> e> Total
> f> Discount Ammount
> g> Applied Date
> 2> On clicking Party Id admin can view party details.
> 3> On clicking Order Id admin can view order details
> 4> From Promotion count admin can get exact figure for how many times promotion is used.
> Local view of Report video:
> http://www.screencast.com/t/shGGE3QeZ
> Note:
> I have created UiLables in English only.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688297#action_12688297 ]

Nitesh Yetta commented on OFBIZ-2250:
-------------------------------------

Thanks Jacques for your suggestions, I will definitely  try to provide the updated patch as soon as i get time.

> Generate Report for Externally Applied Promotion On Order
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2250
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2250
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Nitesh Yetta
>            Priority: Minor
>         Attachments: PromotionReport.patch
>
>
> Description:
> In this Report
> 1> Admin can view all promotions that are applied on order externally.
>    
> Report consist of:
> a> Promotion Name
> b> Promo code
> c> OrderId
> d> PartyId
> e> Total
> f> Discount Ammount
> g> Applied Date
> 2> On clicking Party Id admin can view party details.
> 3> On clicking Order Id admin can view order details
> 4> From Promotion count admin can get exact figure for how many times promotion is used.
> Local view of Report video:
> http://www.screencast.com/t/shGGE3QeZ
> Note:
> I have created UiLables in English only.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.