OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2252) Exception occurs while changing the order status

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2252) Exception occurs while changing the order status

Exception occurs while changing the order status
------------------------------------------------

Key: OFBIZ-2252
URL: https://issues.apache.org/jira/browse/OFBIZ-2252
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: SVN trunk
Reporter: Deepesh Kapoor
Fix For: SVN trunk

When the Status of the Order is changed then as parameters are passed as url parameters on the secured port, Exception org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [orderId] passed to secure (https) request-map with uri [changeOrderStatus] occurs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2252) Exception occurs while changing the order status

[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2252:
----------------------------------

Attachment: OFBIZ-2252.patch

This patch passes the needed parameters as form parameters rather than url parameters.

Currently this patch can be used for resolving exception while changing order status and generating pdf.
Please, provide suggestions over this patch if this is the correct approach for this issue, so that the same could be done for other pages also.

> Exception occurs while changing the order status
> ------------------------------------------------
>
> Key: OFBIZ-2252
> URL: https://issues.apache.org/jira/browse/OFBIZ-2252
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Deepesh Kapoor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2252.patch
>
>
> When the Status of the Order is changed then as parameters are passed as url parameters on the secured port, Exception org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [orderId] passed to secure (https) request-map with uri [changeOrderStatus] occurs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2252) Exception occurs while changing the order status

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688694#action_12688694 ]

Deepesh Kapoor commented on OFBIZ-2252:
---------------------------------------

In this patch i have made use of form inside orderinfo.ftl to pass the required parameters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2252) Exception occurs while changing the order status

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688809#action_12688809 ]

David E. Jones commented on OFBIZ-2252:
---------------------------------------

This looks good in general Deepesh, and thanks for looking at all of the links on that page.

Some opportunities for improvement:

1. keep things simple: instead of calling a JS method to submit the form just use a URL like "javascript:document.${formName}.submit()"

2. avoid reformatting the file and keep your changes localized (ie in small sets) so the patch is clean and it is easy to see what you have changed and what you haven't; when you're a committer feel free to do more reformatting, but for now this only delays reviews as it requires a lot more work from committers who review it; for example these lines don't seem to have any changes other than formatting:

- <div class="screenlet-title-bar">
- <ul>
- <#if orderHeader.externalId?has_content>
- <#assign externalOrder = "(" + orderHeader.externalId + ")"/>
- </#if>
- <#assign orderType = orderHeader.getRelatedOne("OrderType")/>

3. it was good that you followed up on the user mailing list, but a link to the issue would have been easier to follow than a link to the patch

Thanks again! Looking forward to updates...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2252) Exception occurs while changing the order status

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2252:
----------------------------------

Attachment: OFBIZ-2252.patch

Here is the updated patch according to the changes suggested. Please have a look and let me know if there are any other corrections to be done.

> Exception occurs while changing the order status
> ------------------------------------------------
>
> Key: OFBIZ-2252
> URL: https://issues.apache.org/jira/browse/OFBIZ-2252
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Deepesh Kapoor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2252.patch, OFBIZ-2252.patch
>
>
> When the Status of the Order is changed then as parameters are passed as url parameters on the secured port, Exception org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [orderId] passed to secure (https) request-map with uri [changeOrderStatus] occurs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-2252) Exception occurs while changing the order status

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones reassigned OFBIZ-2252:
-------------------------------------

Assignee: David E. Jones

> Exception occurs while changing the order status
> ------------------------------------------------
>
> Key: OFBIZ-2252
> URL: https://issues.apache.org/jira/browse/OFBIZ-2252
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Deepesh Kapoor
> Assignee: David E. Jones
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2252.patch, OFBIZ-2252.patch
>
>
> When the Status of the Order is changed then as parameters are passed as url parameters on the secured port, Exception org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [orderId] passed to secure (https) request-map with uri [changeOrderStatus] occurs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2252) Exception occurs while changing the order status

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-2252.
---------------------------------

Resolution: Fixed

I'm applying this patch and making some changes right away since this really needs to be fixed ASAP.

1. First and most important, please don't change links that still work, there is no need and it just makes the code more complicated without any benefit (for example the orderview and order.pdf links do not need to be changed). It is easy to figure this out, just click on the links and if it works then leave it as-is.

2. Second, there is no need to use the getElementById() function. It is better to just use the "name" attribute on the form instead of the "id" attribute and refer to it directly. Instead of:

document.getElementById('OrderCreated').submit()

simply use:

document.OrderCreated.submit()

3. The names of the forms could be better, ie be similar to the target they correspond to. For example for the form changing to the status ORDER_APPROVED instead of using "OrderCreated" for the name, I've changed it to OrderApproveOrder.

4. Kind of related to #1, there are a few more links on this page that need to be changed to forms, but that is fine in another issue.

Thanks again for your help. Some modified changes are in SVN rev 758502.

> Exception occurs while changing the order status
> ------------------------------------------------
>
> Key: OFBIZ-2252
> URL: https://issues.apache.org/jira/browse/OFBIZ-2252
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Deepesh Kapoor
> Assignee: David E. Jones
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2252.patch, OFBIZ-2252.patch
>
>
> When the Status of the Order is changed then as parameters are passed as url parameters on the secured port, Exception org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [orderId] passed to secure (https) request-map with uri [changeOrderStatus] occurs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.