[jira] Created: (OFBIZ-2275) /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml

[Nicolas Malin (Jira)]

/framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
-----------------------------------------------------------------------------------------------

                 Key: OFBIZ-2275
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: CJ Horton
            Priority: Minor
             Fix For: SVN trunk
         Attachments: services.xml.patch

It looks like the file PeriodServices.xml was moved from:

component://common/script/org/ofbiz/common/period/

to:

component://accounting/script/org/ofbiz/accounting/period

PeriodServices.xml is referenced in two files:
 
component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml

The location is correct in services_ledger.xml, but not services.xml.

I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CJ Horton updated OFBIZ-2275:
-----------------------------

    Attachment: services.xml.patch

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696261#action_12696261 ]

BJ Freeman commented on OFBIZ-2275:
-----------------------------------

if I understand this makes the framework dependent on an application.
should it not be the other way around?

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696284#action_12696284 ]

CJ Horton commented on OFBIZ-2275:
----------------------------------

Yes, you are correct..it should.

It looks like these service definitions are being brought into the accounting application.  findCustomTimePeriods was moved from /framework/common/servicedef/services.xml to component://accounting/servicedef/services_ledger.xml.  If this is correct then the other three service definitions: createCustomTimePeriod, updateCustomTimePeriod, and deleteCustomTimePeriod that are currently defined in /framework/common/servicedef/services.xml should be moved to component://accounting/servicedef/services_ledger.xml as well?

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CJ Horton updated OFBIZ-2275:
-----------------------------

    Attachment: 762561.patch

The 762561.patch removed the three service definitions from the common component services.xml and puts them in to the accounting component services-ledger.xml and updates to the correct PeriodServices.xml location in each.

There are some .ftl pages that I found while testing this that I will update on the other JIRA page when I get home later.

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 762561.patch, services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696363#action_12696363 ]

BJ Freeman commented on OFBIZ-2275:
-----------------------------------

I am kind of sketchy here maybe someone else can jump in
but the time periord entities are in  framework/common/entitydef/
with automatic CRUD service creation would not they be recreated in framework/common/servicedef

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 762561.patch, services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696409#action_12696409 ]

David E. Jones commented on OFBIZ-2275:
---------------------------------------

Thanks for reporting this CJ. I must have slipped these over when I was moving the find server. This should be fixed in SVN rev 762624.

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 762561.patch, services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-2275.
---------------------------------

    Resolution: Fixed
      Assignee: David E. Jones

> /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2275
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2275
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 762561.patch, services.xml.patch
>
>
> It looks like the file PeriodServices.xml was moved from:
> component://common/script/org/ofbiz/common/period/
> to:
> component://accounting/script/org/ofbiz/accounting/period
> PeriodServices.xml is referenced in two files:
>  
> component://accounting/servicedef/services_ledger.xml and component://common/servicedef/services.xml
> The location is correct in services_ledger.xml, but not services.xml.
> I attached a patch that points /framework/common/servicedef/services.xml to the current location of PeriodServices.xml.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.