[jira] Created: (OFBIZ-2283) Add Cancel Order Functionality to https://localhost:8443/ordermgr/control/orderview

[Nicolas Malin (Jira)]

Add Cancel Order Functionality to https://localhost:8443/ordermgr/control/orderview
-----------------------------------------------------------------------------------

                 Key: OFBIZ-2283
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2283
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: CJ Horton
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: orderinfo.ftl.patch

This is a simple patch that adds a "Cancel Order" link on https://localhost:8443/ordermgr/control/orderview

It adds some code to applications/order/webapp/ordermgr/order/orderinfo.ftl

I have it check that the currentStatus.statusId is not "ORDER_COMPLETED" and not "ORDER_CANCELLED" and if this is true then it renders the cancel link.

This submits the OrderCancel form which calls the changeOrderStatus controller request which in turn calls the changeOrderStatus service.

Should there be other checks done before this allowed?  If a production run has been started should the order be allowed to be canceled this way?  Is there anything else I am not thinking of?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CJ Horton updated OFBIZ-2283:
-----------------------------

    Attachment: orderinfo.ftl.patch

> Add Cancel Order Functionality to https://localhost:8443/ordermgr/control/orderview
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2283
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2283
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: orderinfo.ftl.patch
>
>
> This is a simple patch that adds a "Cancel Order" link on https://localhost:8443/ordermgr/control/orderview
> It adds some code to applications/order/webapp/ordermgr/order/orderinfo.ftl
> I have it check that the currentStatus.statusId is not "ORDER_COMPLETED" and not "ORDER_CANCELLED" and if this is true then it renders the cancel link.
> This submits the OrderCancel form which calls the changeOrderStatus controller request which in turn calls the changeOrderStatus service.
> Should there be other checks done before this allowed?  If a production run has been started should the order be allowed to be canceled this way?  Is there anything else I am not thinking of?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2283:
--------------------------------------

    Assignee: Jacques Le Roux

> Add Cancel Order Functionality to https://localhost:8443/ordermgr/control/orderview
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2283
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2283
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: orderinfo.ftl.patch
>
>
> This is a simple patch that adds a "Cancel Order" link on https://localhost:8443/ordermgr/control/orderview
> It adds some code to applications/order/webapp/ordermgr/order/orderinfo.ftl
> I have it check that the currentStatus.statusId is not "ORDER_COMPLETED" and not "ORDER_CANCELLED" and if this is true then it renders the cancel link.
> This submits the OrderCancel form which calls the changeOrderStatus controller request which in turn calls the changeOrderStatus service.
> Should there be other checks done before this allowed?  If a production run has been started should the order be allowed to be canceled this way?  Is there anything else I am not thinking of?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2283.
----------------------------------

    Resolution: Fixed

Thanks CJ,

Your patch is in trunk at revision: 768212  

> Add Cancel Order Functionality to https://localhost:8443/ordermgr/control/orderview
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2283
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2283
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: CJ Horton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: orderinfo.ftl.patch
>
>
> This is a simple patch that adds a "Cancel Order" link on https://localhost:8443/ordermgr/control/orderview
> It adds some code to applications/order/webapp/ordermgr/order/orderinfo.ftl
> I have it check that the currentStatus.statusId is not "ORDER_COMPLETED" and not "ORDER_CANCELLED" and if this is true then it renders the cancel link.
> This submits the OrderCancel form which calls the changeOrderStatus controller request which in turn calls the changeOrderStatus service.
> Should there be other checks done before this allowed?  If a production run has been started should the order be allowed to be canceled this way?  Is there anything else I am not thinking of?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.