[jira] Created: (OFBIZ-2297) Misc improvements on Payment Gateway Config

[Nicolas Malin (Jira)]

Misc improvements on Payment Gateway Config
-------------------------------------------

                 Key: OFBIZ-2297
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
            Reporter: Marco Risaliti
            Assignee: Marco Risaliti
            Priority: Minor


1) encrypt passwords.
2) service names changed.
3) request map entries changed.
4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2297:
----------------------------------

    Attachment: MiscImprPaymentGateway.patch

Forgot to upload this patch.

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700145#action_12700145 ]

Ashish Vijaywargiya commented on OFBIZ-2297:
--------------------------------------------

Hello Marco,

Thanks for working on this.
I have reviewed your patch and it looks almost good.

One change that I would like to see before committing it to trunk.
Instead of "EditGatewayConfig" we should use "EditPaymentGatewayConfig".
And same applies to other places (request, service definition & implementation for other)

This helps to easily identify the name of entity if we exclude prefix that we use in general. For ex : Update, Edit, Create, Delete etc.
Let's see what other has to say on this. If others are fine then you can go ahead and commit the code.

Thanks !
--
Ashish Vijaywargiya

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700151#action_12700151 ]

Jacques Le Roux commented on OFBIZ-2297:
----------------------------------------

I already said on del ML that I agree with Ashish. I'm for conventions. They often prove useful (S/R with regex is a good example) not using them don't

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2297:
----------------------------------

    Attachment: MiscImprPaymentGateway2.patch

Updated patch that now contains always PaymentGatewayConfig as prefix.

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch, MiscImprPaymentGateway2.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-2297:
---------------------------------------

    Attachment: MiscImprPaymentGateway.patch

Patch from Marco without any change. (Renaming the patch as the previous one)
In future please keep the patch name same and let Jira notify the recently uploaded one.

--
Ashish

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch, MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-2297:
---------------------------------------

    Attachment:     (was: MiscImprPaymentGateway2.patch)

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch, MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700421#action_12700421 ]

Ashish Vijaywargiya commented on OFBIZ-2297:
--------------------------------------------

Hello Marco,

The recently updated patch looks good to me.
We are safe and you can commit it on the trunk.

Thanks for your fast turn around on this.
Much appreciated.

--
Ashish Vijaywargiya

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch, MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-2297.
---------------------------------

    Resolution: Fixed

Fixed into rev. 767278.

Please take care of Revisions Requiring Data Migration into confluence.

> Misc improvements on Payment Gateway Config
> -------------------------------------------
>
>                 Key: OFBIZ-2297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2297
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>         Attachments: MiscImprPaymentGateway.patch, MiscImprPaymentGateway.patch
>
>
> 1) encrypt passwords.
> 2) service names changed.
> 3) request map entries changed.
> 4) now the Payment Gateway Config menu is visible only to user having PAYPROC_ADMIN permission.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.